mirror of
https://github.com/PaperMC/Paper.git
synced 2024-11-29 22:13:42 +01:00
764 lines
41 KiB
Diff
764 lines
41 KiB
Diff
--- a/net/minecraft/server/PlayerList.java
|
|
+++ b/net/minecraft/server/PlayerList.java
|
|
@@ -21,6 +21,27 @@
|
|
import org.apache.logging.log4j.LogManager;
|
|
import org.apache.logging.log4j.Logger;
|
|
|
|
+// CraftBukkit start
|
|
+import com.google.common.base.Predicate;
|
|
+import com.google.common.collect.Iterables;
|
|
+
|
|
+import org.bukkit.craftbukkit.CraftServer;
|
|
+import org.bukkit.craftbukkit.CraftWorld;
|
|
+
|
|
+import org.bukkit.Bukkit;
|
|
+import org.bukkit.Location;
|
|
+import org.bukkit.craftbukkit.util.CraftChatMessage;
|
|
+import org.bukkit.entity.Player;
|
|
+import org.bukkit.event.player.PlayerChangedWorldEvent;
|
|
+import org.bukkit.event.player.PlayerPortalEvent;
|
|
+import org.bukkit.event.player.PlayerJoinEvent;
|
|
+import org.bukkit.event.player.PlayerLoginEvent;
|
|
+import org.bukkit.event.player.PlayerQuitEvent;
|
|
+import org.bukkit.event.player.PlayerRespawnEvent;
|
|
+import org.bukkit.event.player.PlayerTeleportEvent.TeleportCause;
|
|
+import org.bukkit.util.Vector;
|
|
+// CraftBukkit end
|
|
+
|
|
public abstract class PlayerList {
|
|
|
|
public static final File b = new File("banned-players.json");
|
|
@@ -30,14 +51,16 @@
|
|
private static final Logger LOGGER = LogManager.getLogger();
|
|
private static final SimpleDateFormat g = new SimpleDateFormat("yyyy-MM-dd 'at' HH:mm:ss z");
|
|
private final MinecraftServer server;
|
|
- public final List<EntityPlayer> players = Lists.newArrayList();
|
|
+ public final List<EntityPlayer> players = new java.util.concurrent.CopyOnWriteArrayList(); // CraftBukkit - ArrayList -> CopyOnWriteArrayList: Iterator safety
|
|
private final Map<UUID, EntityPlayer> j = Maps.newHashMap();
|
|
private final GameProfileBanList k;
|
|
private final IpBanList l;
|
|
private final OpList operators;
|
|
private final WhiteList whitelist;
|
|
- private final Map<UUID, ServerStatisticManager> o;
|
|
- private final Map<UUID, AdvancementDataPlayer> p;
|
|
+ // CraftBukkit start
|
|
+ // private final Map<UUID, ServerStatisticManager> o;
|
|
+ // private final Map<UUID, AdvancementDataPlayer> p;
|
|
+ // CraftBukkit end
|
|
public final WorldNBTStorage playerFileData;
|
|
private boolean hasWhitelist;
|
|
private final IRegistryCustom.Dimension s;
|
|
@@ -47,13 +70,23 @@
|
|
private boolean v;
|
|
private int w;
|
|
|
|
+ // CraftBukkit start
|
|
+ private CraftServer cserver;
|
|
+
|
|
public PlayerList(MinecraftServer minecraftserver, IRegistryCustom.Dimension iregistrycustom_dimension, WorldNBTStorage worldnbtstorage, int i) {
|
|
+ this.cserver = minecraftserver.server = new CraftServer((DedicatedServer) minecraftserver, this);
|
|
+ minecraftserver.console = org.bukkit.craftbukkit.command.ColouredConsoleSender.getInstance();
|
|
+ minecraftserver.reader.addCompleter(new org.bukkit.craftbukkit.command.ConsoleCommandCompleter(minecraftserver.server));
|
|
+ // CraftBukkit end
|
|
+
|
|
this.k = new GameProfileBanList(PlayerList.b);
|
|
this.l = new IpBanList(PlayerList.c);
|
|
this.operators = new OpList(PlayerList.d);
|
|
this.whitelist = new WhiteList(PlayerList.e);
|
|
- this.o = Maps.newHashMap();
|
|
- this.p = Maps.newHashMap();
|
|
+ // CraftBukkit start
|
|
+ // this.o = Maps.newHashMap();
|
|
+ // this.p = Maps.newHashMap();
|
|
+ // CraftBukkit end
|
|
this.server = minecraftserver;
|
|
this.s = iregistrycustom_dimension;
|
|
this.maxPlayers = i;
|
|
@@ -69,6 +102,12 @@
|
|
usercache.a(gameprofile);
|
|
NBTTagCompound nbttagcompound = this.a(entityplayer);
|
|
ResourceKey resourcekey;
|
|
+ // CraftBukkit start - Better rename detection
|
|
+ if (nbttagcompound != null && nbttagcompound.hasKey("bukkit")) {
|
|
+ NBTTagCompound bukkit = nbttagcompound.getCompound("bukkit");
|
|
+ s = bukkit.hasKeyOfType("lastKnownName", 8) ? bukkit.getString("lastKnownName") : s;
|
|
+ }
|
|
+ // CraftBukkit end
|
|
|
|
if (nbttagcompound != null) {
|
|
DataResult dataresult = DimensionManager.a(new Dynamic(DynamicOpsNBT.a, nbttagcompound.get("Dimension")));
|
|
@@ -99,7 +138,8 @@
|
|
s1 = networkmanager.getSocketAddress().toString();
|
|
}
|
|
|
|
- PlayerList.LOGGER.info("{}[{}] logged in with entity id {} at ({}, {}, {})", entityplayer.getDisplayName().getString(), s1, entityplayer.getId(), entityplayer.locX(), entityplayer.locY(), entityplayer.locZ());
|
|
+ // CraftBukkit - Moved message to after join
|
|
+ // PlayerList.LOGGER.info("{}[{}] logged in with entity id {} at ({}, {}, {})", entityplayer.getDisplayName().getString(), s1, entityplayer.getId(), entityplayer.locX(), entityplayer.locY(), entityplayer.locZ());
|
|
WorldData worlddata = worldserver1.getWorldData();
|
|
|
|
this.a(entityplayer, (EntityPlayer) null, worldserver1);
|
|
@@ -109,6 +149,7 @@
|
|
boolean flag1 = gamerules.getBoolean(GameRules.REDUCED_DEBUG_INFO);
|
|
|
|
playerconnection.sendPacket(new PacketPlayOutLogin(entityplayer.getId(), entityplayer.playerInteractManager.getGameMode(), entityplayer.playerInteractManager.c(), BiomeManager.a(worldserver1.getSeed()), worlddata.isHardcore(), this.server.E(), this.s, worldserver1.getTypeKey(), worldserver1.getDimensionKey(), this.getMaxPlayers(), this.viewDistance, flag1, !flag, worldserver1.isDebugWorld(), worldserver1.isFlatWorld()));
|
|
+ entityplayer.getBukkitEntity().sendSupportedChannels(); // CraftBukkit
|
|
playerconnection.sendPacket(new PacketPlayOutCustomPayload(PacketPlayOutCustomPayload.a, (new PacketDataSerializer(Unpooled.buffer())).a(this.getServer().getServerModName())));
|
|
playerconnection.sendPacket(new PacketPlayOutServerDifficulty(worlddata.getDifficulty(), worlddata.isDifficultyLocked()));
|
|
playerconnection.sendPacket(new PacketPlayOutAbilities(entityplayer.abilities));
|
|
@@ -127,19 +168,61 @@
|
|
} else {
|
|
chatmessage = new ChatMessage("multiplayer.player.joined.renamed", new Object[]{entityplayer.getScoreboardDisplayName(), s});
|
|
}
|
|
+ // CraftBukkit start
|
|
+ chatmessage.a(EnumChatFormat.YELLOW);
|
|
+ String joinMessage = CraftChatMessage.fromComponent(chatmessage);
|
|
|
|
- this.sendMessage(chatmessage.a(EnumChatFormat.YELLOW), ChatMessageType.SYSTEM, SystemUtils.b);
|
|
playerconnection.a(entityplayer.locX(), entityplayer.locY(), entityplayer.locZ(), entityplayer.yaw, entityplayer.pitch);
|
|
this.players.add(entityplayer);
|
|
this.j.put(entityplayer.getUniqueID(), entityplayer);
|
|
- this.sendAll(new PacketPlayOutPlayerInfo(PacketPlayOutPlayerInfo.EnumPlayerInfoAction.ADD_PLAYER, new EntityPlayer[]{entityplayer}));
|
|
+ // this.sendAll(new PacketPlayOutPlayerInfo(PacketPlayOutPlayerInfo.EnumPlayerInfoAction.ADD_PLAYER, new EntityPlayer[]{entityplayer})); // CraftBukkit - replaced with loop below
|
|
+
|
|
+ // CraftBukkit start
|
|
+ PlayerJoinEvent playerJoinEvent = new PlayerJoinEvent(cserver.getPlayer(entityplayer), joinMessage);
|
|
+ cserver.getPluginManager().callEvent(playerJoinEvent);
|
|
+
|
|
+ if (!entityplayer.playerConnection.networkManager.isConnected()) {
|
|
+ return;
|
|
+ }
|
|
+
|
|
+ joinMessage = playerJoinEvent.getJoinMessage();
|
|
+
|
|
+ if (joinMessage != null && joinMessage.length() > 0) {
|
|
+ for (IChatBaseComponent line : org.bukkit.craftbukkit.util.CraftChatMessage.fromString(joinMessage)) {
|
|
+ server.getPlayerList().sendAll(new PacketPlayOutChat(line, ChatMessageType.SYSTEM, SystemUtils.b));
|
|
+ }
|
|
+ }
|
|
+ // CraftBukkit end
|
|
+
|
|
+ // CraftBukkit start - sendAll above replaced with this loop
|
|
+ PacketPlayOutPlayerInfo packet = new PacketPlayOutPlayerInfo(PacketPlayOutPlayerInfo.EnumPlayerInfoAction.ADD_PLAYER, entityplayer);
|
|
|
|
for (int i = 0; i < this.players.size(); ++i) {
|
|
- entityplayer.playerConnection.sendPacket(new PacketPlayOutPlayerInfo(PacketPlayOutPlayerInfo.EnumPlayerInfoAction.ADD_PLAYER, new EntityPlayer[]{(EntityPlayer) this.players.get(i)}));
|
|
+ EntityPlayer entityplayer1 = (EntityPlayer) this.players.get(i);
|
|
+
|
|
+ if (entityplayer1.getBukkitEntity().canSee(entityplayer.getBukkitEntity())) {
|
|
+ entityplayer1.playerConnection.sendPacket(packet);
|
|
+ }
|
|
+
|
|
+ if (!entityplayer.getBukkitEntity().canSee(entityplayer1.getBukkitEntity())) {
|
|
+ continue;
|
|
+ }
|
|
+
|
|
+ entityplayer.playerConnection.sendPacket(new PacketPlayOutPlayerInfo(PacketPlayOutPlayerInfo.EnumPlayerInfoAction.ADD_PLAYER, new EntityPlayer[] { entityplayer1}));
|
|
+ }
|
|
+ entityplayer.sentListPacket = true;
|
|
+ // CraftBukkit end
|
|
+
|
|
+ entityplayer.playerConnection.sendPacket(new PacketPlayOutEntityMetadata(entityplayer.getId(), entityplayer.datawatcher, true)); // CraftBukkit - BungeeCord#2321, send complete data to self on spawn
|
|
+
|
|
+ // CraftBukkit start - Only add if the player wasn't moved in the event
|
|
+ if (entityplayer.world == worldserver1 && !worldserver1.getPlayers().contains(entityplayer)) {
|
|
+ worldserver1.addPlayerJoin(entityplayer);
|
|
+ this.server.getBossBattleCustomData().a(entityplayer);
|
|
}
|
|
|
|
- worldserver1.addPlayerJoin(entityplayer);
|
|
- this.server.getBossBattleCustomData().a(entityplayer);
|
|
+ worldserver1 = entityplayer.getWorldServer(); // CraftBukkit - Update in case join event changed it
|
|
+ // CraftBukkit end
|
|
this.a(entityplayer, worldserver1);
|
|
if (!this.server.getResourcePack().isEmpty()) {
|
|
entityplayer.setResourcePack(this.server.getResourcePack(), this.server.getResourcePackHash());
|
|
@@ -155,8 +238,11 @@
|
|
|
|
if (nbttagcompound != null && nbttagcompound.hasKeyOfType("RootVehicle", 10)) {
|
|
NBTTagCompound nbttagcompound1 = nbttagcompound.getCompound("RootVehicle");
|
|
- Entity entity = EntityTypes.a(nbttagcompound1.getCompound("Entity"), worldserver1, (entity1) -> {
|
|
- return !worldserver1.addEntitySerialized(entity1) ? null : entity1;
|
|
+ // CraftBukkit start
|
|
+ WorldServer finalWorldServer = worldserver1;
|
|
+ Entity entity = EntityTypes.a(nbttagcompound1.getCompound("Entity"), finalWorldServer, (entity1) -> {
|
|
+ return !finalWorldServer.addEntitySerialized(entity1) ? null : entity1;
|
|
+ // CraftBukkit end
|
|
});
|
|
|
|
if (entity != null) {
|
|
@@ -199,6 +285,8 @@
|
|
}
|
|
|
|
entityplayer.syncInventory();
|
|
+ // CraftBukkit - Moved from above, added world
|
|
+ PlayerList.LOGGER.info("{}[{}] logged in with entity id {} at ([{}]{}, {}, {})", entityplayer.getDisplayName().getString(), s1, entityplayer.getId(), worldserver1.worldDataServer.getName(), entityplayer.locX(), entityplayer.locY(), entityplayer.locZ());
|
|
}
|
|
|
|
public void sendScoreboard(ScoreboardServer scoreboardserver, EntityPlayer entityplayer) {
|
|
@@ -231,30 +319,31 @@
|
|
}
|
|
|
|
public void setPlayerFileData(WorldServer worldserver) {
|
|
+ if (playerFileData != null) return; // CraftBukkit
|
|
worldserver.getWorldBorder().a(new IWorldBorderListener() {
|
|
@Override
|
|
public void a(WorldBorder worldborder, double d0) {
|
|
- PlayerList.this.sendAll(new PacketPlayOutWorldBorder(worldborder, PacketPlayOutWorldBorder.EnumWorldBorderAction.SET_SIZE));
|
|
+ PlayerList.this.sendAll(new PacketPlayOutWorldBorder(worldborder, PacketPlayOutWorldBorder.EnumWorldBorderAction.SET_SIZE), worldborder.world);
|
|
}
|
|
|
|
@Override
|
|
public void a(WorldBorder worldborder, double d0, double d1, long i) {
|
|
- PlayerList.this.sendAll(new PacketPlayOutWorldBorder(worldborder, PacketPlayOutWorldBorder.EnumWorldBorderAction.LERP_SIZE));
|
|
+ PlayerList.this.sendAll(new PacketPlayOutWorldBorder(worldborder, PacketPlayOutWorldBorder.EnumWorldBorderAction.LERP_SIZE), worldborder.world);
|
|
}
|
|
|
|
@Override
|
|
public void a(WorldBorder worldborder, double d0, double d1) {
|
|
- PlayerList.this.sendAll(new PacketPlayOutWorldBorder(worldborder, PacketPlayOutWorldBorder.EnumWorldBorderAction.SET_CENTER));
|
|
+ PlayerList.this.sendAll(new PacketPlayOutWorldBorder(worldborder, PacketPlayOutWorldBorder.EnumWorldBorderAction.SET_CENTER), worldborder.world);
|
|
}
|
|
|
|
@Override
|
|
public void a(WorldBorder worldborder, int i) {
|
|
- PlayerList.this.sendAll(new PacketPlayOutWorldBorder(worldborder, PacketPlayOutWorldBorder.EnumWorldBorderAction.SET_WARNING_TIME));
|
|
+ PlayerList.this.sendAll(new PacketPlayOutWorldBorder(worldborder, PacketPlayOutWorldBorder.EnumWorldBorderAction.SET_WARNING_TIME), worldborder.world);
|
|
}
|
|
|
|
@Override
|
|
public void b(WorldBorder worldborder, int i) {
|
|
- PlayerList.this.sendAll(new PacketPlayOutWorldBorder(worldborder, PacketPlayOutWorldBorder.EnumWorldBorderAction.SET_WARNING_BLOCKS));
|
|
+ PlayerList.this.sendAll(new PacketPlayOutWorldBorder(worldborder, PacketPlayOutWorldBorder.EnumWorldBorderAction.SET_WARNING_BLOCKS), worldborder.world);
|
|
}
|
|
|
|
@Override
|
|
@@ -282,14 +371,15 @@
|
|
}
|
|
|
|
protected void savePlayerFile(EntityPlayer entityplayer) {
|
|
+ if (!entityplayer.getBukkitEntity().isPersistent()) return; // CraftBukkit
|
|
this.playerFileData.save(entityplayer);
|
|
- ServerStatisticManager serverstatisticmanager = (ServerStatisticManager) this.o.get(entityplayer.getUniqueID());
|
|
+ ServerStatisticManager serverstatisticmanager = (ServerStatisticManager) entityplayer.getStatisticManager(); // CraftBukkit
|
|
|
|
if (serverstatisticmanager != null) {
|
|
serverstatisticmanager.save();
|
|
}
|
|
|
|
- AdvancementDataPlayer advancementdataplayer = (AdvancementDataPlayer) this.p.get(entityplayer.getUniqueID());
|
|
+ AdvancementDataPlayer advancementdataplayer = (AdvancementDataPlayer) entityplayer.getAdvancementData(); // CraftBukkit
|
|
|
|
if (advancementdataplayer != null) {
|
|
advancementdataplayer.b();
|
|
@@ -297,10 +387,21 @@
|
|
|
|
}
|
|
|
|
- public void disconnect(EntityPlayer entityplayer) {
|
|
+ public String disconnect(EntityPlayer entityplayer) { // CraftBukkit - return string
|
|
WorldServer worldserver = entityplayer.getWorldServer();
|
|
|
|
entityplayer.a(StatisticList.LEAVE_GAME);
|
|
+
|
|
+ // CraftBukkit start - Quitting must be before we do final save of data, in case plugins need to modify it
|
|
+ entityplayer.closeInventory();
|
|
+
|
|
+ PlayerQuitEvent playerQuitEvent = new PlayerQuitEvent(cserver.getPlayer(entityplayer), "\u00A7e" + entityplayer.getName() + " left the game");
|
|
+ cserver.getPluginManager().callEvent(playerQuitEvent);
|
|
+ entityplayer.getBukkitEntity().disconnect(playerQuitEvent.getQuitMessage());
|
|
+
|
|
+ entityplayer.playerTick(); // SPIGOT-924
|
|
+ // CraftBukkit end
|
|
+
|
|
this.savePlayerFile(entityplayer);
|
|
if (entityplayer.isPassenger()) {
|
|
Entity entity = entityplayer.getRootVehicle();
|
|
@@ -332,18 +433,66 @@
|
|
|
|
if (entityplayer1 == entityplayer) {
|
|
this.j.remove(uuid);
|
|
- this.o.remove(uuid);
|
|
- this.p.remove(uuid);
|
|
+ // CraftBukkit start
|
|
+ // this.o.remove(uuid);
|
|
+ // this.p.remove(uuid);
|
|
+ // CraftBukkit end
|
|
+ }
|
|
+
|
|
+ // CraftBukkit start
|
|
+ // this.sendAll(new PacketPlayOutPlayerInfo(PacketPlayOutPlayerInfo.EnumPlayerInfoAction.REMOVE_PLAYER, new EntityPlayer[]{entityplayer}));
|
|
+ PacketPlayOutPlayerInfo packet = new PacketPlayOutPlayerInfo(PacketPlayOutPlayerInfo.EnumPlayerInfoAction.REMOVE_PLAYER, entityplayer);
|
|
+ for (int i = 0; i < players.size(); i++) {
|
|
+ EntityPlayer entityplayer2 = (EntityPlayer) this.players.get(i);
|
|
+
|
|
+ if (entityplayer2.getBukkitEntity().canSee(entityplayer.getBukkitEntity())) {
|
|
+ entityplayer2.playerConnection.sendPacket(packet);
|
|
+ } else {
|
|
+ entityplayer2.getBukkitEntity().removeDisconnectingPlayer(entityplayer.getBukkitEntity());
|
|
+ }
|
|
}
|
|
+ // This removes the scoreboard (and player reference) for the specific player in the manager
|
|
+ cserver.getScoreboardManager().removePlayer(entityplayer.getBukkitEntity());
|
|
+ // CraftBukkit end
|
|
|
|
- this.sendAll(new PacketPlayOutPlayerInfo(PacketPlayOutPlayerInfo.EnumPlayerInfoAction.REMOVE_PLAYER, new EntityPlayer[]{entityplayer}));
|
|
+ return playerQuitEvent.getQuitMessage(); // CraftBukkit
|
|
}
|
|
|
|
- @Nullable
|
|
- public IChatBaseComponent attemptLogin(SocketAddress socketaddress, GameProfile gameprofile) {
|
|
+ // CraftBukkit start - Whole method, SocketAddress to LoginListener, added hostname to signature, return EntityPlayer
|
|
+ public EntityPlayer attemptLogin(LoginListener loginlistener, GameProfile gameprofile, String hostname) {
|
|
ChatMessage chatmessage;
|
|
|
|
- if (this.k.isBanned(gameprofile)) {
|
|
+ // Moved from processLogin
|
|
+ UUID uuid = EntityHuman.a(gameprofile);
|
|
+ List<EntityPlayer> list = Lists.newArrayList();
|
|
+
|
|
+ EntityPlayer entityplayer;
|
|
+
|
|
+ for (int i = 0; i < this.players.size(); ++i) {
|
|
+ entityplayer = (EntityPlayer) this.players.get(i);
|
|
+ if (entityplayer.getUniqueID().equals(uuid)) {
|
|
+ list.add(entityplayer);
|
|
+ }
|
|
+ }
|
|
+
|
|
+ Iterator iterator = list.iterator();
|
|
+
|
|
+ while (iterator.hasNext()) {
|
|
+ entityplayer = (EntityPlayer) iterator.next();
|
|
+ savePlayerFile(entityplayer); // CraftBukkit - Force the player's inventory to be saved
|
|
+ entityplayer.playerConnection.disconnect(new ChatMessage("multiplayer.disconnect.duplicate_login", new Object[0]));
|
|
+ }
|
|
+
|
|
+ // Instead of kicking then returning, we need to store the kick reason
|
|
+ // in the event, check with plugins to see if it's ok, and THEN kick
|
|
+ // depending on the outcome.
|
|
+ SocketAddress socketaddress = loginlistener.networkManager.getSocketAddress();
|
|
+
|
|
+ EntityPlayer entity = new EntityPlayer(this.server, this.server.getWorldServer(World.OVERWORLD), gameprofile, new PlayerInteractManager(this.server.getWorldServer(World.OVERWORLD)));
|
|
+ Player player = entity.getBukkitEntity();
|
|
+ PlayerLoginEvent event = new PlayerLoginEvent(player, hostname, ((java.net.InetSocketAddress) socketaddress).getAddress());
|
|
+
|
|
+ if (getProfileBans().isBanned(gameprofile) && !getProfileBans().get(gameprofile).hasExpired()) {
|
|
GameProfileBanEntry gameprofilebanentry = (GameProfileBanEntry) this.k.get(gameprofile);
|
|
|
|
chatmessage = new ChatMessage("multiplayer.disconnect.banned.reason", new Object[]{gameprofilebanentry.getReason()});
|
|
@@ -351,10 +500,12 @@
|
|
chatmessage.addSibling(new ChatMessage("multiplayer.disconnect.banned.expiration", new Object[]{PlayerList.g.format(gameprofilebanentry.getExpires())}));
|
|
}
|
|
|
|
- return chatmessage;
|
|
+ // return chatmessage;
|
|
+ event.disallow(PlayerLoginEvent.Result.KICK_BANNED, CraftChatMessage.fromComponent(chatmessage));
|
|
} else if (!this.isWhitelisted(gameprofile)) {
|
|
- return new ChatMessage("multiplayer.disconnect.not_whitelisted");
|
|
- } else if (this.l.isBanned(socketaddress)) {
|
|
+ chatmessage = new ChatMessage("multiplayer.disconnect.not_whitelisted");
|
|
+ event.disallow(PlayerLoginEvent.Result.KICK_WHITELIST, CraftChatMessage.fromComponent(chatmessage));
|
|
+ } else if (getIPBans().isBanned(socketaddress) && !getIPBans().get(socketaddress).hasExpired()) {
|
|
IpBanEntry ipbanentry = this.l.get(socketaddress);
|
|
|
|
chatmessage = new ChatMessage("multiplayer.disconnect.banned_ip.reason", new Object[]{ipbanentry.getReason()});
|
|
@@ -362,13 +513,25 @@
|
|
chatmessage.addSibling(new ChatMessage("multiplayer.disconnect.banned_ip.expiration", new Object[]{PlayerList.g.format(ipbanentry.getExpires())}));
|
|
}
|
|
|
|
- return chatmessage;
|
|
+ // return chatmessage;
|
|
+ event.disallow(PlayerLoginEvent.Result.KICK_BANNED, CraftChatMessage.fromComponent(chatmessage));
|
|
} else {
|
|
- return this.players.size() >= this.maxPlayers && !this.f(gameprofile) ? new ChatMessage("multiplayer.disconnect.server_full") : null;
|
|
+ // return this.players.size() >= this.maxPlayers && !this.f(gameprofile) ? new ChatMessage("multiplayer.disconnect.server_full") : null;
|
|
+ if (this.players.size() >= this.maxPlayers && !this.f(gameprofile)) {
|
|
+ event.disallow(PlayerLoginEvent.Result.KICK_FULL, "The server is full");
|
|
+ }
|
|
}
|
|
+
|
|
+ cserver.getPluginManager().callEvent(event);
|
|
+ if (event.getResult() != PlayerLoginEvent.Result.ALLOWED) {
|
|
+ loginlistener.disconnect(event.getKickMessage());
|
|
+ return null;
|
|
+ }
|
|
+ return entity;
|
|
}
|
|
|
|
- public EntityPlayer processLogin(GameProfile gameprofile) {
|
|
+ public EntityPlayer processLogin(GameProfile gameprofile, EntityPlayer player) { // CraftBukkit - added EntityPlayer
|
|
+ /* CraftBukkit startMoved up
|
|
UUID uuid = EntityHuman.a(gameprofile);
|
|
List<EntityPlayer> list = Lists.newArrayList();
|
|
|
|
@@ -404,13 +567,23 @@
|
|
}
|
|
|
|
return new EntityPlayer(this.server, worldserver, gameprofile, (PlayerInteractManager) object);
|
|
+ */
|
|
+ return player;
|
|
+ // CraftBukkit end
|
|
}
|
|
|
|
+ // CraftBukkit start
|
|
public EntityPlayer moveToWorld(EntityPlayer entityplayer, boolean flag) {
|
|
+ return this.moveToWorld(entityplayer, this.server.getWorldServer(entityplayer.getSpawnDimension()), flag, null, true);
|
|
+ }
|
|
+
|
|
+ public EntityPlayer moveToWorld(EntityPlayer entityplayer, WorldServer worldserver, boolean flag, Location location, boolean avoidSuffocation) {
|
|
+ entityplayer.stopRiding(); // CraftBukkit
|
|
this.players.remove(entityplayer);
|
|
entityplayer.getWorldServer().removePlayer(entityplayer);
|
|
BlockPosition blockposition = entityplayer.getSpawn();
|
|
boolean flag1 = entityplayer.isSpawnForced();
|
|
+ /* CraftBukkit start
|
|
WorldServer worldserver = this.server.getWorldServer(entityplayer.getSpawnDimension());
|
|
Optional optional;
|
|
|
|
@@ -430,6 +603,11 @@
|
|
}
|
|
|
|
EntityPlayer entityplayer1 = new EntityPlayer(this.server, worldserver1, entityplayer.getProfile(), (PlayerInteractManager) object);
|
|
+ // */
|
|
+ EntityPlayer entityplayer1 = entityplayer;
|
|
+ org.bukkit.World fromWorld = entityplayer.getBukkitEntity().getWorld();
|
|
+ entityplayer.viewingCredits = false;
|
|
+ // CraftBukkit end
|
|
|
|
entityplayer1.playerConnection = entityplayer.playerConnection;
|
|
entityplayer1.copyFrom(entityplayer, flag);
|
|
@@ -443,41 +621,103 @@
|
|
entityplayer1.addScoreboardTag(s);
|
|
}
|
|
|
|
- this.a(entityplayer1, entityplayer, worldserver1);
|
|
+ // this.a(entityplayer1, entityplayer, worldserver1); // CraftBukkit - removed
|
|
boolean flag2 = false;
|
|
|
|
- if (optional.isPresent()) {
|
|
- Vec3D vec3d = (Vec3D) optional.get();
|
|
+ // CraftBukkit start - fire PlayerRespawnEvent
|
|
+ if (location == null) {
|
|
+ boolean isBedSpawn = false;
|
|
+ WorldServer worldserver1 = this.server.getWorldServer(entityplayer.getSpawnDimension());
|
|
+ if (worldserver1 != null) {
|
|
+ Optional optional;
|
|
+
|
|
+ if (blockposition != null) {
|
|
+ optional = EntityHuman.getBed(worldserver1, blockposition, flag1, flag);
|
|
+ } else {
|
|
+ optional = Optional.empty();
|
|
+ }
|
|
|
|
- entityplayer1.setPositionRotation(vec3d.x, vec3d.y, vec3d.z, 0.0F, 0.0F);
|
|
- entityplayer1.setRespawnPosition(worldserver1.getDimensionKey(), blockposition, flag1, false);
|
|
- flag2 = !flag && worldserver1.getType(blockposition).getBlock() instanceof BlockRespawnAnchor;
|
|
- } else if (blockposition != null) {
|
|
- entityplayer1.playerConnection.sendPacket(new PacketPlayOutGameStateChange(PacketPlayOutGameStateChange.a, 0.0F));
|
|
+ if (optional.isPresent()) {
|
|
+ Vec3D vec3d = (Vec3D) optional.get();
|
|
+
|
|
+ isBedSpawn = true;
|
|
+ location = new Location(worldserver1.getWorld(), vec3d.x, vec3d.y, vec3d.z);
|
|
+
|
|
+ entityplayer1.setRespawnPosition(worldserver1.getDimensionKey(), blockposition, flag1, false);
|
|
+ flag2 = !flag && worldserver1.getType(blockposition).getBlock() instanceof BlockRespawnAnchor;
|
|
+ } else if (blockposition != null) {
|
|
+ entityplayer1.playerConnection.sendPacket(new PacketPlayOutGameStateChange(PacketPlayOutGameStateChange.a, 0.0F));
|
|
+ }
|
|
+ }
|
|
+
|
|
+ if (location == null) {
|
|
+ worldserver1 = this.server.getWorldServer(World.OVERWORLD);
|
|
+ blockposition = entityplayer1.getSpawnPoint(worldserver1);
|
|
+ location = new Location(worldserver1.getWorld(), (double) ((float) blockposition.getX() + 0.5F), (double) ((float) blockposition.getY() + 0.1F), (double) ((float) blockposition.getZ() + 0.5F));
|
|
+ }
|
|
+
|
|
+ Player respawnPlayer = cserver.getPlayer(entityplayer1);
|
|
+ PlayerRespawnEvent respawnEvent = new PlayerRespawnEvent(respawnPlayer, location, isBedSpawn && !flag2, flag2);
|
|
+ cserver.getPluginManager().callEvent(respawnEvent);
|
|
+
|
|
+ location = respawnEvent.getRespawnLocation();
|
|
+ if (!flag) entityplayer.reset(); // SPIGOT-4785
|
|
+ } else {
|
|
+ location.setWorld(worldserver.getWorld());
|
|
}
|
|
+ WorldServer worldserver1 = ((CraftWorld) location.getWorld()).getHandle();
|
|
+ entityplayer1.forceSetPositionRotation(location.getX(), location.getY(), location.getZ(), location.getYaw(), location.getPitch());
|
|
+ // CraftBukkit end
|
|
|
|
- while (!worldserver1.getCubes(entityplayer1) && entityplayer1.locY() < 256.0D) {
|
|
+ while (avoidSuffocation && !worldserver1.getCubes(entityplayer1) && entityplayer1.locY() < 256.0D) {
|
|
entityplayer1.setPosition(entityplayer1.locX(), entityplayer1.locY() + 1.0D, entityplayer1.locZ());
|
|
}
|
|
+ // CraftBukkit start
|
|
+ WorldData worlddata = worldserver1.getWorldData();
|
|
+ entityplayer1.playerConnection.sendPacket(new PacketPlayOutRespawn(worldserver1.getTypeKey(), worldserver1.getDimensionKey(), BiomeManager.a(worldserver1.getSeed()), entityplayer1.playerInteractManager.getGameMode(), entityplayer1.playerInteractManager.c(), worldserver1.isDebugWorld(), worldserver1.isFlatWorld(), flag));
|
|
+ entityplayer1.spawnIn(worldserver1);
|
|
+ entityplayer1.dead = false;
|
|
+ entityplayer1.playerConnection.teleport(new Location(worldserver1.getWorld(), entityplayer1.locX(), entityplayer1.locY(), entityplayer1.locZ(), entityplayer1.yaw, entityplayer1.pitch));
|
|
+ entityplayer1.setSneaking(false);
|
|
|
|
- WorldData worlddata = entityplayer1.world.getWorldData();
|
|
-
|
|
- entityplayer1.playerConnection.sendPacket(new PacketPlayOutRespawn(entityplayer1.world.getTypeKey(), entityplayer1.world.getDimensionKey(), BiomeManager.a(entityplayer1.getWorldServer().getSeed()), entityplayer1.playerInteractManager.getGameMode(), entityplayer1.playerInteractManager.c(), entityplayer1.getWorldServer().isDebugWorld(), entityplayer1.getWorldServer().isFlatWorld(), flag));
|
|
- entityplayer1.playerConnection.a(entityplayer1.locX(), entityplayer1.locY(), entityplayer1.locZ(), entityplayer1.yaw, entityplayer1.pitch);
|
|
+ // entityplayer1.playerConnection.a(entityplayer1.locX(), entityplayer1.locY(), entityplayer1.locZ(), entityplayer1.yaw, entityplayer1.pitch);
|
|
entityplayer1.playerConnection.sendPacket(new PacketPlayOutSpawnPosition(worldserver1.getSpawn()));
|
|
entityplayer1.playerConnection.sendPacket(new PacketPlayOutServerDifficulty(worlddata.getDifficulty(), worlddata.isDifficultyLocked()));
|
|
entityplayer1.playerConnection.sendPacket(new PacketPlayOutExperience(entityplayer1.exp, entityplayer1.expTotal, entityplayer1.expLevel));
|
|
this.a(entityplayer1, worldserver1);
|
|
this.d(entityplayer1);
|
|
- worldserver1.addPlayerRespawn(entityplayer1);
|
|
- this.players.add(entityplayer1);
|
|
- this.j.put(entityplayer1.getUniqueID(), entityplayer1);
|
|
- entityplayer1.syncInventory();
|
|
+ if (!entityplayer.playerConnection.isDisconnected()) {
|
|
+ worldserver1.addPlayerRespawn(entityplayer1);
|
|
+ this.players.add(entityplayer1);
|
|
+ this.j.put(entityplayer1.getUniqueID(), entityplayer1);
|
|
+ }
|
|
+ // entityplayer1.syncInventory();
|
|
entityplayer1.setHealth(entityplayer1.getHealth());
|
|
if (flag2) {
|
|
entityplayer1.playerConnection.sendPacket(new PacketPlayOutNamedSoundEffect(SoundEffects.BLOCK_RESPAWN_ANCHOR_DEPLETE, SoundCategory.BLOCKS, (double) blockposition.getX(), (double) blockposition.getY(), (double) blockposition.getZ(), 1.0F, 1.0F));
|
|
}
|
|
+ // Added from changeDimension
|
|
+ updateClient(entityplayer); // Update health, etc...
|
|
+ entityplayer.updateAbilities();
|
|
+ for (Object o1 : entityplayer.getEffects()) {
|
|
+ MobEffect mobEffect = (MobEffect) o1;
|
|
+ entityplayer.playerConnection.sendPacket(new PacketPlayOutEntityEffect(entityplayer.getId(), mobEffect));
|
|
+ }
|
|
+
|
|
+ // Fire advancement trigger
|
|
+ entityplayer.triggerDimensionAdvancements(((CraftWorld) fromWorld).getHandle());
|
|
+
|
|
+ // Don't fire on respawn
|
|
+ if (fromWorld != location.getWorld()) {
|
|
+ PlayerChangedWorldEvent event = new PlayerChangedWorldEvent(entityplayer.getBukkitEntity(), fromWorld);
|
|
+ server.server.getPluginManager().callEvent(event);
|
|
+ }
|
|
|
|
+ // Save player file again if they were disconnected
|
|
+ if (entityplayer.playerConnection.isDisconnected()) {
|
|
+ this.savePlayerFile(entityplayer);
|
|
+ }
|
|
+ // CraftBukkit end
|
|
return entityplayer1;
|
|
}
|
|
|
|
@@ -490,7 +730,18 @@
|
|
|
|
public void tick() {
|
|
if (++this.w > 600) {
|
|
- this.sendAll(new PacketPlayOutPlayerInfo(PacketPlayOutPlayerInfo.EnumPlayerInfoAction.UPDATE_LATENCY, this.players));
|
|
+ // CraftBukkit start
|
|
+ for (int i = 0; i < this.players.size(); ++i) {
|
|
+ final EntityPlayer target = (EntityPlayer) this.players.get(i);
|
|
+
|
|
+ target.playerConnection.sendPacket(new PacketPlayOutPlayerInfo(PacketPlayOutPlayerInfo.EnumPlayerInfoAction.UPDATE_LATENCY, Iterables.filter(this.players, new Predicate<EntityPlayer>() {
|
|
+ @Override
|
|
+ public boolean apply(EntityPlayer input) {
|
|
+ return target.getBukkitEntity().canSee(input.getBukkitEntity());
|
|
+ }
|
|
+ })));
|
|
+ }
|
|
+ // CraftBukkit end
|
|
this.w = 0;
|
|
}
|
|
|
|
@@ -503,6 +754,25 @@
|
|
|
|
}
|
|
|
|
+ // CraftBukkit start - add a world/entity limited version
|
|
+ public void sendAll(Packet packet, EntityHuman entityhuman) {
|
|
+ for (int i = 0; i < this.players.size(); ++i) {
|
|
+ EntityPlayer entityplayer = this.players.get(i);
|
|
+ if (entityhuman != null && entityhuman instanceof EntityPlayer && !entityplayer.getBukkitEntity().canSee(((EntityPlayer) entityhuman).getBukkitEntity())) {
|
|
+ continue;
|
|
+ }
|
|
+ ((EntityPlayer) this.players.get(i)).playerConnection.sendPacket(packet);
|
|
+ }
|
|
+ }
|
|
+
|
|
+ public void sendAll(Packet packet, World world) {
|
|
+ for (int i = 0; i < world.getPlayers().size(); ++i) {
|
|
+ ((EntityPlayer) world.getPlayers().get(i)).playerConnection.sendPacket(packet);
|
|
+ }
|
|
+
|
|
+ }
|
|
+ // CraftBukkit end
|
|
+
|
|
public void a(Packet<?> packet, ResourceKey<World> resourcekey) {
|
|
for (int i = 0; i < this.players.size(); ++i) {
|
|
EntityPlayer entityplayer = (EntityPlayer) this.players.get(i);
|
|
@@ -603,6 +873,7 @@
|
|
entityplayer.playerConnection.sendPacket(new PacketPlayOutEntityStatus(entityplayer, b0));
|
|
}
|
|
|
|
+ entityplayer.getBukkitEntity().recalculatePermissions(); // CraftBukkit
|
|
this.server.getCommandDispatcher().a(entityplayer);
|
|
}
|
|
|
|
@@ -635,6 +906,12 @@
|
|
for (int i = 0; i < this.players.size(); ++i) {
|
|
EntityPlayer entityplayer = (EntityPlayer) this.players.get(i);
|
|
|
|
+ // CraftBukkit start - Test if player receiving packet can see the source of the packet
|
|
+ if (entityhuman != null && entityhuman instanceof EntityPlayer && !entityplayer.getBukkitEntity().canSee(((EntityPlayer) entityhuman).getBukkitEntity())) {
|
|
+ continue;
|
|
+ }
|
|
+ // CraftBukkit end
|
|
+
|
|
if (entityplayer != entityhuman && entityplayer.world.getDimensionKey() == resourcekey) {
|
|
double d4 = d0 - entityplayer.locX();
|
|
double d5 = d1 - entityplayer.locY();
|
|
@@ -674,23 +951,34 @@
|
|
public void reloadWhitelist() {}
|
|
|
|
public void a(EntityPlayer entityplayer, WorldServer worldserver) {
|
|
- WorldBorder worldborder = this.server.D().getWorldBorder();
|
|
+ WorldBorder worldborder = entityplayer.world.getWorldBorder(); // CraftBukkit
|
|
|
|
entityplayer.playerConnection.sendPacket(new PacketPlayOutWorldBorder(worldborder, PacketPlayOutWorldBorder.EnumWorldBorderAction.INITIALIZE));
|
|
entityplayer.playerConnection.sendPacket(new PacketPlayOutUpdateTime(worldserver.getTime(), worldserver.getDayTime(), worldserver.getGameRules().getBoolean(GameRules.DO_DAYLIGHT_CYCLE)));
|
|
entityplayer.playerConnection.sendPacket(new PacketPlayOutSpawnPosition(worldserver.getSpawn()));
|
|
if (worldserver.isRaining()) {
|
|
- entityplayer.playerConnection.sendPacket(new PacketPlayOutGameStateChange(PacketPlayOutGameStateChange.b, 0.0F));
|
|
- entityplayer.playerConnection.sendPacket(new PacketPlayOutGameStateChange(PacketPlayOutGameStateChange.h, worldserver.d(1.0F)));
|
|
- entityplayer.playerConnection.sendPacket(new PacketPlayOutGameStateChange(PacketPlayOutGameStateChange.i, worldserver.b(1.0F)));
|
|
+ // CraftBukkit start - handle player weather
|
|
+ // entityplayer.playerConnection.sendPacket(new PacketPlayOutGameStateChange(PacketPlayOutGameStateChange.b, 0.0F));
|
|
+ // entityplayer.playerConnection.sendPacket(new PacketPlayOutGameStateChange(PacketPlayOutGameStateChange.h, worldserver.d(1.0F)));
|
|
+ // entityplayer.playerConnection.sendPacket(new PacketPlayOutGameStateChange(PacketPlayOutGameStateChange.i, worldserver.b(1.0F)));
|
|
+ entityplayer.setPlayerWeather(org.bukkit.WeatherType.DOWNFALL, false);
|
|
+ entityplayer.updateWeather(-worldserver.rainLevel, worldserver.rainLevel, -worldserver.thunderLevel, worldserver.thunderLevel);
|
|
+ // CraftBukkit end
|
|
}
|
|
|
|
}
|
|
|
|
public void updateClient(EntityPlayer entityplayer) {
|
|
entityplayer.updateInventory(entityplayer.defaultContainer);
|
|
- entityplayer.triggerHealthUpdate();
|
|
+ // entityplayer.triggerHealthUpdate();
|
|
+ entityplayer.getBukkitEntity().updateScaledHealth(); // CraftBukkit - Update scaled health on respawn and worldchange
|
|
entityplayer.playerConnection.sendPacket(new PacketPlayOutHeldItemSlot(entityplayer.inventory.itemInHandIndex));
|
|
+ // CraftBukkit start - from GameRules
|
|
+ int i = entityplayer.world.getGameRules().getBoolean(GameRules.REDUCED_DEBUG_INFO) ? 22 : 23;
|
|
+ entityplayer.playerConnection.sendPacket(new PacketPlayOutEntityStatus(entityplayer, (byte) i));
|
|
+ float immediateRespawn = entityplayer.world.getGameRules().getBoolean(GameRules.DO_IMMEDIATE_RESPAWN) ? 1.0F: 0.0F;
|
|
+ entityplayer.playerConnection.sendPacket(new PacketPlayOutGameStateChange(PacketPlayOutGameStateChange.l, immediateRespawn));
|
|
+ // CraftBukkit end
|
|
}
|
|
|
|
public int getPlayerCount() {
|
|
@@ -747,27 +1035,50 @@
|
|
}
|
|
|
|
public void shutdown() {
|
|
- for (int i = 0; i < this.players.size(); ++i) {
|
|
- ((EntityPlayer) this.players.get(i)).playerConnection.disconnect(new ChatMessage("multiplayer.disconnect.server_shutdown"));
|
|
+ // CraftBukkit start - disconnect safely
|
|
+ for (EntityPlayer player : this.players) {
|
|
+ player.playerConnection.disconnect(this.server.server.getShutdownMessage()); // CraftBukkit - add custom shutdown message
|
|
}
|
|
+ // CraftBukkit end
|
|
+
|
|
+ }
|
|
|
|
+ // CraftBukkit start
|
|
+ public void sendMessage(IChatBaseComponent[] iChatBaseComponents) {
|
|
+ for (IChatBaseComponent component : iChatBaseComponents) {
|
|
+ sendMessage(component, ChatMessageType.SYSTEM, SystemUtils.b);
|
|
+ }
|
|
}
|
|
+ // CraftBukkit end
|
|
|
|
public void sendMessage(IChatBaseComponent ichatbasecomponent, ChatMessageType chatmessagetype, UUID uuid) {
|
|
this.server.sendMessage(ichatbasecomponent, uuid);
|
|
- this.sendAll(new PacketPlayOutChat(ichatbasecomponent, chatmessagetype, uuid));
|
|
+ // CraftBukkit start - we run this through our processor first so we can get web links etc
|
|
+ this.sendAll(new PacketPlayOutChat(CraftChatMessage.fixComponent(ichatbasecomponent), chatmessagetype, uuid));
|
|
+ // CraftBukkit end
|
|
+ }
|
|
+
|
|
+ public void sendMessage(IChatBaseComponent ichatbasecomponent) {
|
|
+ this.sendMessage(ichatbasecomponent, ChatMessageType.SYSTEM, SystemUtils.b);
|
|
}
|
|
|
|
- public ServerStatisticManager getStatisticManager(EntityHuman entityhuman) {
|
|
- UUID uuid = entityhuman.getUniqueID();
|
|
- ServerStatisticManager serverstatisticmanager = uuid == null ? null : (ServerStatisticManager) this.o.get(uuid);
|
|
+ // CraftBukkit start
|
|
+ public ServerStatisticManager getStatisticManager(EntityPlayer entityhuman) {
|
|
+ ServerStatisticManager serverstatisticmanager = entityhuman.getStatisticManager();
|
|
+ return serverstatisticmanager == null ? getStatisticManager(entityhuman.getUniqueID(), entityhuman.getDisplayName().getString()) : serverstatisticmanager;
|
|
+ }
|
|
+
|
|
+ public ServerStatisticManager getStatisticManager(UUID uuid, String displayName) {
|
|
+ EntityPlayer entityhuman = this.getPlayer(uuid);
|
|
+ ServerStatisticManager serverstatisticmanager = entityhuman == null ? null : (ServerStatisticManager) entityhuman.getStatisticManager();
|
|
+ // CraftBukkit end
|
|
|
|
if (serverstatisticmanager == null) {
|
|
File file = this.server.a(SavedFile.STATS).toFile();
|
|
File file1 = new File(file, uuid + ".json");
|
|
|
|
if (!file1.exists()) {
|
|
- File file2 = new File(file, entityhuman.getDisplayName().getString() + ".json");
|
|
+ File file2 = new File(file, displayName + ".json"); // CraftBukkit
|
|
|
|
if (file2.exists() && file2.isFile()) {
|
|
file2.renameTo(file1);
|
|
@@ -775,7 +1086,7 @@
|
|
}
|
|
|
|
serverstatisticmanager = new ServerStatisticManager(this.server, file1);
|
|
- this.o.put(uuid, serverstatisticmanager);
|
|
+ // this.o.put(uuid, serverstatisticmanager); // CraftBukkit
|
|
}
|
|
|
|
return serverstatisticmanager;
|
|
@@ -783,14 +1094,14 @@
|
|
|
|
public AdvancementDataPlayer f(EntityPlayer entityplayer) {
|
|
UUID uuid = entityplayer.getUniqueID();
|
|
- AdvancementDataPlayer advancementdataplayer = (AdvancementDataPlayer) this.p.get(uuid);
|
|
+ AdvancementDataPlayer advancementdataplayer = (AdvancementDataPlayer) entityplayer.getAdvancementData(); // CraftBukkit
|
|
|
|
if (advancementdataplayer == null) {
|
|
File file = this.server.a(SavedFile.ADVANCEMENTS).toFile();
|
|
File file1 = new File(file, uuid + ".json");
|
|
|
|
advancementdataplayer = new AdvancementDataPlayer(this.server.getDataFixer(), this, this.server.getAdvancementData(), file1, entityplayer);
|
|
- this.p.put(uuid, advancementdataplayer);
|
|
+ // this.p.put(uuid, advancementdataplayer); // CraftBukkit
|
|
}
|
|
|
|
advancementdataplayer.a(entityplayer);
|
|
@@ -826,13 +1137,20 @@
|
|
}
|
|
|
|
public void reload() {
|
|
- Iterator iterator = this.p.values().iterator();
|
|
+ // CraftBukkit start
|
|
+ /*Iterator iterator = this.p.values().iterator();
|
|
|
|
while (iterator.hasNext()) {
|
|
AdvancementDataPlayer advancementdataplayer = (AdvancementDataPlayer) iterator.next();
|
|
|
|
advancementdataplayer.a(this.server.getAdvancementData());
|
|
+ }*/
|
|
+
|
|
+ for (EntityPlayer player : players) {
|
|
+ player.getAdvancementData().a(this.server.getAdvancementData());
|
|
+ player.getAdvancementData().b(player); // CraftBukkit - trigger immediate flush of advancements
|
|
}
|
|
+ // CraftBukkit end
|
|
|
|
this.sendAll(new PacketPlayOutTags(this.server.getTagRegistry()));
|
|
PacketPlayOutRecipeUpdate packetplayoutrecipeupdate = new PacketPlayOutRecipeUpdate(this.server.getCraftingManager().b());
|