mirror of
https://github.com/PaperMC/Paper.git
synced 2024-12-28 20:07:41 +01:00
c5a10665b8
Spigot still maintains some partial implementation of "tick skipping", a practice in which the MinecraftServer.currentTick field is updated not by an increment of one per actual tick, but instead set to System.currentTimeMillis() / 50. This behaviour means that the tracked tick may "skip" a tick value in case a previous tick took more than the expected 50ms. To compensate for this in important paths, spigot/craftbukkit implements "wall-time". Instead of incrementing/decrementing ticks on block entities/entities by one for each call to their tick() method, they instead increment/decrement important values, like an ItemEntity's age or pickupDelay, by the difference of `currentTick - lastTick`, where `lastTick` is the value of `currentTick` during the last tick() call. These "fixes" however do not play nicely with minecraft's simulation distance as entities/block entities implementing the above behaviour would "catch up" their values when moving from a non-ticking chunk to a ticking one as their `lastTick` value remains stuck on the last tick in a ticking chunk and hence lead to a large "catch up" once ticked again. Paper completely removes the "tick skipping" behaviour (See patch "Further-improve-server-tick-loop"), making the above precautions completely unnecessary, which also rids paper of the previous described incompatibility with non-ticking chunks.
45 lines
1.7 KiB
Diff
45 lines
1.7 KiB
Diff
From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
|
|
From: FireInstall <kettnerl@hu-berlin.de>
|
|
Date: Sat, 20 Jan 2024 16:20:06 +0100
|
|
Subject: [PATCH] Expose LootTable of DecoratedPot
|
|
|
|
|
|
diff --git a/src/main/java/org/bukkit/craftbukkit/block/CraftDecoratedPot.java b/src/main/java/org/bukkit/craftbukkit/block/CraftDecoratedPot.java
|
|
index 6e0258d4d6a07e0f471640a9edda0adf7ef6cd9e..47cc3ec5ccd3bb51a08b3f179cb29030948b8c11 100644
|
|
--- a/src/main/java/org/bukkit/craftbukkit/block/CraftDecoratedPot.java
|
|
+++ b/src/main/java/org/bukkit/craftbukkit/block/CraftDecoratedPot.java
|
|
@@ -43,6 +43,33 @@ public class CraftDecoratedPot extends CraftBlockEntityState<DecoratedPotBlockEn
|
|
return new CraftInventoryDecoratedPot(this.getTileEntity());
|
|
}
|
|
|
|
+ // Paper start - expose loot table
|
|
+ @Override
|
|
+ public void setLootTable(final org.bukkit.loot.LootTable table) {
|
|
+ this.setLootTable(table, this.getSeed());
|
|
+ }
|
|
+
|
|
+ @Override
|
|
+ public void setLootTable(org.bukkit.loot.LootTable table, long seed) {
|
|
+ this.getSnapshot().setLootTable(org.bukkit.craftbukkit.CraftLootTable.bukkitToMinecraft(table), seed);
|
|
+ }
|
|
+
|
|
+ @Override
|
|
+ public org.bukkit.loot.LootTable getLootTable() {
|
|
+ return org.bukkit.craftbukkit.CraftLootTable.minecraftToBukkit(this.getSnapshot().getLootTable());
|
|
+ }
|
|
+
|
|
+ @Override
|
|
+ public void setSeed(final long seed) {
|
|
+ this.getSnapshot().setLootTableSeed(seed);
|
|
+ }
|
|
+
|
|
+ @Override
|
|
+ public long getSeed() {
|
|
+ return this.getSnapshot().getLootTableSeed();
|
|
+ }
|
|
+ // Paper end - expose loot table
|
|
+
|
|
@Override
|
|
public void setSherd(Side face, Material sherd) {
|
|
Preconditions.checkArgument(face != null, "face must not be null");
|