From 08ce920727b1c6f289690190c1e3d24741859f3e Mon Sep 17 00:00:00 2001 From: Rsl1122 Date: Thu, 1 Aug 2019 19:48:02 +0300 Subject: [PATCH] Changed language for Extension errors: This redirects blame away from the plugin that the extension is about. --- .../plan/extension/ExtensionServiceImplementation.java | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/Plan/common/src/main/java/com/djrapitops/plan/extension/ExtensionServiceImplementation.java b/Plan/common/src/main/java/com/djrapitops/plan/extension/ExtensionServiceImplementation.java index 6a0da2372..dc1302d1a 100644 --- a/Plan/common/src/main/java/com/djrapitops/plan/extension/ExtensionServiceImplementation.java +++ b/Plan/common/src/main/java/com/djrapitops/plan/extension/ExtensionServiceImplementation.java @@ -159,7 +159,7 @@ public class ExtensionServiceImplementation implements ExtensionService { // Try again updatePlayerValues(gatherer, playerUUID, playerName, event); } catch (Exception | NoClassDefFoundError | NoSuchFieldError | NoSuchMethodError unexpectedError) { - logger.warn(gatherer.getPluginName() + " ran into unexpected error (please report this)" + unexpectedError + + logger.warn("Encountered unexpected error with " + gatherer.getPluginName() + " Extension (please report this): " + unexpectedError + " (but failed safely) when updating value for '" + playerName + "', stack trace to follow:"); errorHandler.log(L.WARN, gatherer.getClass(), unexpectedError); @@ -169,8 +169,8 @@ public class ExtensionServiceImplementation implements ExtensionService { private void logFailure(String playerName, DataExtensionMethodCallException methodCallFailed) { Throwable cause = methodCallFailed.getCause(); String causeName = cause.getClass().getSimpleName(); - logger.warn(methodCallFailed.getPluginName() + " ran into " + causeName + - " (but failed safely) when updating value for '" + playerName + + logger.warn("Encountered " + causeName + " with " + methodCallFailed.getPluginName() + " Extension (please report this)" + + " (failed safely) when updating value for '" + playerName + "', the method was disabled temporarily (won't be called until next Plan reload)" + ", stack trace to follow:"); errorHandler.log(L.WARN, getClass(), cause); @@ -198,8 +198,8 @@ public class ExtensionServiceImplementation implements ExtensionService { // Try again updateServerValues(gatherer, event); } catch (Exception | NoClassDefFoundError | NoSuchFieldError | NoSuchMethodError unexpectedError) { - logger.warn(gatherer.getPluginName() + " ran into unexpected error (please report this)" + unexpectedError + - " (but failed safely) when updating value for server, stack trace to follow:"); + logger.warn("Encountered unexpected error with " + gatherer.getPluginName() + " Extension (please report this): " + unexpectedError + + " (failed safely) when updating value for server, stack trace to follow:"); errorHandler.log(L.WARN, gatherer.getClass(), unexpectedError); } }