From e8515915cdc3dbfd7e1844d415d2c338c6458dd6 Mon Sep 17 00:00:00 2001
From: Aurora Lahtela <24460436+AuroraLS3@users.noreply.github.com>
Date: Thu, 28 Mar 2024 20:15:40 +0200
Subject: [PATCH] Disable Apply button when things are up to date or if
 selected addresses is empty

---
 .../dashboard/src/components/cards/common/AddressListCard.jsx  | 3 ++-
 .../components/cards/server/graphs/JoinAddressGraphCard.jsx    | 2 +-
 2 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/Plan/react/dashboard/src/components/cards/common/AddressListCard.jsx b/Plan/react/dashboard/src/components/cards/common/AddressListCard.jsx
index 679672a1b..85fda0db8 100644
--- a/Plan/react/dashboard/src/components/cards/common/AddressListCard.jsx
+++ b/Plan/react/dashboard/src/components/cards/common/AddressListCard.jsx
@@ -19,7 +19,6 @@ const AddressListCard = ({n, group, editGroup, allAddresses, remove}) => {
         }
     }, [selectedIndexes, group, allAddresses])
 
-    const isUpToDate = group.addresses === allAddresses.filter((a, i) => selectedIndexes.includes(i));
     const applySelected = useCallback(() => {
         editGroup({...group, addresses: allAddresses.filter((a, i) => selectedIndexes.includes(i))})
     }, [editGroup, group, allAddresses, selectedIndexes]);
@@ -30,6 +29,8 @@ const AddressListCard = ({n, group, editGroup, allAddresses, remove}) => {
         if (!editingName && name !== group.name) editName(name);
     }, [editName, editingName, name])
 
+    const selectedAddresses = allAddresses.filter((a, i) => selectedIndexes.includes(i));
+    const isUpToDate = !selectedIndexes.length || selectedAddresses.length === group.addresses.length && selectedAddresses.every((a, i) => a === group.addresses[i]);
     return (
         <Card>
             <CardHeader icon={faList} color={"amber"} label={
diff --git a/Plan/react/dashboard/src/components/cards/server/graphs/JoinAddressGraphCard.jsx b/Plan/react/dashboard/src/components/cards/server/graphs/JoinAddressGraphCard.jsx
index 73fc80255..f105005b0 100644
--- a/Plan/react/dashboard/src/components/cards/server/graphs/JoinAddressGraphCard.jsx
+++ b/Plan/react/dashboard/src/components/cards/server/graphs/JoinAddressGraphCard.jsx
@@ -26,7 +26,7 @@ const JoinAddressGraphCard = ({identifier}) => {
 
         let colors = ['#4ab4de'];
         const dataByGroup = [];
-        for (const group of list) {
+        for (const group of list.filter(group => group.addresses.length)) {
             const {data, error} = await fetchJoinAddressByDay(updateRequested, group.addresses, identifier);
             if (error) {
                 setLoadingError(error);