From f846bd5b0eda6ef907bc8a7f48fb32acb165c22b Mon Sep 17 00:00:00 2001 From: Rsl1122 Date: Sat, 15 Sep 2018 10:03:35 +0300 Subject: [PATCH] AnalysisContainer no longer held in memory by PluginData objects. Since PluginData objects are more persistent than AnalysisContainer, objects related to the each analysis can not be freed until the next analysis has been performed, because a reference was held in each PluginData object. Change: set the reference to point to null in a finally block after getServerData call. AnalysisContainer can now be freed by GC at any time Affected issues: #685 --- .../html/structure/AnalysisPluginsTabContentCreator.java | 1 + 1 file changed, 1 insertion(+) diff --git a/Plan/src/main/java/com/djrapitops/plan/utilities/html/structure/AnalysisPluginsTabContentCreator.java b/Plan/src/main/java/com/djrapitops/plan/utilities/html/structure/AnalysisPluginsTabContentCreator.java index c8094884a..50d6ee6cc 100644 --- a/Plan/src/main/java/com/djrapitops/plan/utilities/html/structure/AnalysisPluginsTabContentCreator.java +++ b/Plan/src/main/java/com/djrapitops/plan/utilities/html/structure/AnalysisPluginsTabContentCreator.java @@ -118,6 +118,7 @@ public class AnalysisPluginsTabContentCreator { Log.toLog(AnalysisPluginsTabContentCreator.class, e); } finally { Benchmark.stop("Analysis", "Analysis: Source " + source.getSourcePlugin()); + source.setAnalysisData(null); } }); return containers;