- No need to wrap the final analysis into another async method. It's already contained in an async task
- Don't overstretch a chunk bounday when setting blocks to newBlocks array
* Implement tile entities to generation using Populators
- Fixes#3051
* Javadocs
* Don't do the big error if heads don't work
* Address comments regarding javadocs/comments
* Ensure Location is still sealed, and add api description annotation to public methods in UncheckedWorldLocation
* Clean up HybridGen
- There's no need for while loops acting as a modulo after we've already performed a modulo
- Make the code-sections calculating if positions are in the wall/road more readable
- Collaps duplicate if-elseif bodies
* Better exception handling when setting data to LimitedRegion during chunk population
* Address comments
Co-authored-by: Alexander Brandes <mc.cache@web.de>
* Better naming for "legacy" block state populator
Co-authored-by: Alexander Brandes <mc.cache@web.de>
- Begin by implementing forceSync to the queue system as we know the chunk will be accessible to edits in some cases (i.e. population).
- Also implement custom SideEffectSets to override any decided by the default chunk consumer, as we do NOT want to update neighbours in population (this caused infinite generation to be required causing the lag and server death). We also do not want to enqueue the QueueCoordinator in AugmentedUtils as this would write to the world and update neighbours before we might want to (plus it's just used to restrict and offset the blocks being set)
- Then implement disabling any biomes from being saved/set to the queue to prevent augmented worlds having their biomes overridden in roads
- Consequently fix ScopedQueueCoordinator, preventing the y value of blocks being set from needlessly being changed, fixing road heights in augmented worlds
- Finally we do not need a method with chunkObject in the signature in AugmentedUtils as this is no longer used by the method
* Fix plot analysis
- Stop using deprecated ChunkQueueCoordinator and create a new purpose-built coordinator
- Generation is chunk-by-chunk thus the old blocks cache needs to be filled accordingly
- Remove the **four** System#gc calls
- Fixes#3464
- Fix really weird dumb... maths? in ExpiryTask
- Fixes#3600
* Add since annotation
* Address comments and maxY should be inclusive
* Annotate new queue as internal use only
* Begin to implement extended world heights:
- Implemented in Bukkit module (and where required in Core module)
* Implement extended world heights into core module
* Add min gen height to setup,
* Default gen/build heights based on minecraft version
* Few fixes
* Fix up queues
* Address comments
* Make road schematic stuff slightly more efficient by sharing queues
* Minor fixes, don't overlay error many times for the same y
* Fix incorrect schematic paste height, undo changes to HybridUtils
* Overhall regenallroads method to make it work, make sure BukkitChunkCoordinator can/will finish
* Process chunks in order when regenerating all roads
* Address comments
* Address comments
* Ground level//bedrock is at min gen height
- Add comment on == rather than <= being used
- It's because it's only checking for the bedrock layer being broken if that's disabled
* Fix offset for min build height in SchematicHandler
* Better javadoc
Co-authored-by: Hannes Greule <SirYwell@users.noreply.github.com>
* Address inclusivity issues for max world height
* Javadocs/comments/deprecation
* Use world min/max heights if present in QueueCoordinator
* Address some deprecations for regions and biome setting
* Add a count for chunks we're currently trying to load to not skip chunks at the end of a queue's edit
* Use minGenHeight + 1 rather than build height in AugmentedUtils
* Create utility method for layer index in GenChunk
* Correct height in HybridUtils, also use minGenHeight + 1
* Don't magically split to 128 height in regeneration
* Add utility methods for world height in QueueCoordinator
* Clean up ClassicPlotManager road creation/removal
* Start generation at min gen height if bedrock is disabled
* min gen height is set in PlotArea
* Add note on schem y normalisation
* Improve plot getVolume method readability
* Don't overly extend height when regenerating road region
* y index utility method in ChunknQueueCoordinator
* Layer index utility method in LocalChunk
* Use version min/max heights if world not present in QueueCoordinator
* Fix min -> max
* Don't allow players to modify outside build height when using plot set / schematics.
- Also fixes schematic height issues
* Remove debug
* Address comments
* Switch loadingChunks to AtomicInteger to be safe (in case of multi-threaded)
* Fix "security" issue that was already present
* Ensure sign isn't physicsed
Co-authored-by: Hannes Greule <SirYwell@users.noreply.github.com>
* feat: unknown owner(s) for plot expiry
* Sort plugins on `/plot debugpaste` alphabetically (#3447)
* feat: Sort plugins on debugpaste alphabetically
* Put (F[A])WE at the top
* feat: Add 1.18's music disc additions to `/plot music` (#3446)
* refactor: Prepare removal of our maven repository (#3451)
* Allow restoration of road schematic height calculation behaviour from pre 6.1.4 (#3444)
* refactor: Update SquirrelID GAV
* build: Release 6.3.0
* build: Back to snapshot for development
* fix: fallback method in BukkitQueueCoordinator uses world coordinates
* mark since tags as TODO
* fix: get the lowest diff for plot age
* fix: initialize with high value and better readability
* fix: no need for multiple age checks
* fix: address exceptions in plot analysis
* chore: address requested changes
* chore: Fix introduced violations
Co-authored-by: Alex <mc.cache@web.de>
Co-authored-by: Jordan <dordsor21@gmail.com>
* Better deciding of heights to use for generation and schematics
- If bedrock is disabled, we should still be filling the space with something
- Use minBuildHeight instead of hardcoding "1" for schematics (it is still 1 by default) to ensure all-encompassing schematics
- Schematic generation/handling for roads etc. should be accounting for all of wall, road, and plot heights for deciding point of origin
- Fixes#3269
- Starts to address #3175
* Also do for HybridPlotManager clear
- Ditch slf4j in favor of log4j. slf4j is (unfortunately) very much unmaintained at this time and future versions of MC (1.17+) will use log4j version 2.14.1 onwards over some ancient sfl4j version.
- Using log4j reduces our jar size as well, because we don't need to bridge it as the game provides it natively.
- Addressing a few command deprecations during the major release superseded by toggles
- Don't swallow SQL warnings in loggers behind debug, as it's often set to false
- Deleted JavaVersionCheck, it's part of ServerLib.
* Start working on Arkitektonika support
* Progress on Arkitektonika
* Add license headers
* Some QoL and javadocs
* Fix maximum calculation
* Fix minor formatting
* Reimplement legacy webinterface support
* Add documentation and fix deletion link
* Resolve conflicts/gradle stuff
* Fix links
* Make message readable
* Do not allow download of merged plots
