From 260cb22f53b7f5f62d6698efd3a43bf52ec076c7 Mon Sep 17 00:00:00 2001 From: Dan Mulloy Date: Wed, 7 Jun 2023 22:26:16 -0500 Subject: [PATCH] Fix logging issue hiding underlying issue --- .../protocol/error/DetailedErrorReporter.java | 14 ++++++++++++-- 1 file changed, 12 insertions(+), 2 deletions(-) diff --git a/src/main/java/com/comphenix/protocol/error/DetailedErrorReporter.java b/src/main/java/com/comphenix/protocol/error/DetailedErrorReporter.java index 90c83cbd..0d7299ab 100644 --- a/src/main/java/com/comphenix/protocol/error/DetailedErrorReporter.java +++ b/src/main/java/com/comphenix/protocol/error/DetailedErrorReporter.java @@ -30,6 +30,8 @@ import java.util.concurrent.atomic.AtomicInteger; import java.util.logging.Level; import java.util.logging.Logger; +import com.comphenix.protocol.ProtocolConfig; +import com.comphenix.protocol.ProtocolLib; import com.comphenix.protocol.ProtocolLibrary; import com.comphenix.protocol.ProtocolLogger; import com.comphenix.protocol.collections.ExpireHashMap; @@ -391,7 +393,7 @@ public class DetailedErrorReporter implements ErrorReporter { writer.println(addPrefix(Bukkit.getServer().getVersion(), SECOND_LEVEL_PREFIX)); // Inform of this occurrence - if (ERROR_PERMISSION != null && ProtocolLibrary.getConfig().isChatWarnings()) { + if (isChatWarnings()) { Bukkit.getServer().broadcast( String.format("Error %s (%s) occurred in %s.", report.getReportMessage(), report.getException(), sender), ERROR_PERMISSION @@ -402,7 +404,15 @@ public class DetailedErrorReporter implements ErrorReporter { // Make sure it is reported logger.severe(addPrefix(text.toString(), prefix)); } - + + private boolean isChatWarnings() { + try { + ProtocolConfig config = ProtocolLibrary.getConfig(); + return config != null && config.isChatWarnings(); + } catch (Exception ignored) {} + return false; + } + /** * Print the call stack to the given logger. * @param logger - the logger.