Upstream/ProtocolLib
1
0
Fork 0
mirror of https://github.com/dmulloy2/ProtocolLib.git synced 2024-11-27 21:26:17 +01:00
Code Issues Projects Releases Wiki Activity

cleanup MonitorAdapter (#1831)

Browse Source
This commit is contained in:
Pasqual Koschmieder 2022-08-24 02:53:55 +02:00 committed by GitHub
parent b7c1e096c4
commit 43145bd478
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 36 additions and 42 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

56
src/main/java/com/comphenix/protocol/events/MonitorAdapter.java
View File

@ -17,10 +17,11 @@
package com.comphenix.protocol.events; package com.comphenix.protocol.events;
import java.util.Collection;
import java.util.logging.Logger; import java.util.logging.Logger;
import com.comphenix.protocol.PacketType;
import com.comphenix.protocol.injector.packet.PacketRegistry; import com.comphenix.protocol.injector.packet.PacketRegistry;
import org.bukkit.plugin.Plugin; import org.bukkit.plugin.Plugin;
/** /**
@ -30,54 +31,47 @@ import org.bukkit.plugin.Plugin;
*/ */
public abstract class MonitorAdapter implements PacketListener { public abstract class MonitorAdapter implements PacketListener {
private Plugin plugin; private final Plugin plugin;
private ListeningWhitelist sending = ListeningWhitelist.EMPTY_WHITELIST; private final ListeningWhitelist sending;
private ListeningWhitelist receiving = ListeningWhitelist.EMPTY_WHITELIST; private final ListeningWhitelist receiving;
public MonitorAdapter(Plugin plugin, ConnectionSide side) { public MonitorAdapter(Plugin plugin, ConnectionSide side) {
initialize(plugin, side, getLogger(plugin));
}
public MonitorAdapter(Plugin plugin, ConnectionSide side, Logger logger) {
initialize(plugin, side, logger);
}
private void initialize(Plugin plugin, ConnectionSide side, Logger logger) {
this.plugin = plugin; this.plugin = plugin;
// Recover in case something goes wrong // check the connection side and register the packets for the given side
if (side.isForServer()) this.sending = side.isForServer() ? buildWhitelist(PacketRegistry.getServerPacketTypes()) : ListeningWhitelist.EMPTY_WHITELIST;
this.sending = ListeningWhitelist.newBuilder().monitor().types(PacketRegistry.getServerPacketTypes()).gamePhaseBoth().build(); this.receiving = side.isForClient() ? buildWhitelist(PacketRegistry.getClientPacketTypes()) : ListeningWhitelist.EMPTY_WHITELIST;
if (side.isForClient())
this.receiving = ListeningWhitelist.newBuilder().monitor().types(PacketRegistry.getClientPacketTypes()).gamePhaseBoth().build();
} }
/** @Deprecated
* Retrieve a logger, even if we're running in a CraftBukkit version that doesn't support it. public MonitorAdapter(Plugin plugin, ConnectionSide side, Logger logger) {
* @param plugin - the plugin to retrieve. this(plugin, side);
* @return The logger.
*/
private Logger getLogger(Plugin plugin) {
try {
return plugin.getLogger();
} catch (NoSuchMethodError e) {
return Logger.getLogger("Minecraft");
} }
private static ListeningWhitelist buildWhitelist(Collection<PacketType> packetTypes) {
return ListeningWhitelist.newBuilder().monitor().gamePhaseBoth().types(packetTypes).build();
} }
@Override @Override
public ListeningWhitelist getSendingWhitelist() { public ListeningWhitelist getSendingWhitelist() {
return sending; return this.sending;
} }
@Override @Override
public ListeningWhitelist getReceivingWhitelist() { public ListeningWhitelist getReceivingWhitelist() {
return receiving; return this.receiving;
} }
@Override @Override
public Plugin getPlugin() { public Plugin getPlugin() {
return plugin; return this.plugin;
}
@Override
public void onPacketSending(PacketEvent event) {
}
@Override
public void onPacketReceiving(PacketEvent event) {
} }
} }