Upstream/ProtocolLib
1
0
Fork 0
mirror of https://github.com/dmulloy2/ProtocolLib.git synced 2024-12-26 11:08:12 +01:00
Code Issues Projects Releases Wiki Activity

Use an atomic integer instead of a volatile field.

Browse Source 
Incrementing and decrementing is not thread-safe on volatile variables.
This commit is contained in:
Kristian S. Stangeland 2012-10-03 23:13:05 +02:00
parent c6fb01e1e1
commit 558eab2253
1 changed files with 5 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
ProtocolLib/src/com/comphenix/protocol/async/AsyncListenerHandler.java
View File

@ -1,6 +1,7 @@
package com.comphenix.protocol.async;
import java.util.concurrent.ArrayBlockingQueue;
import java.util.concurrent.atomic.AtomicInteger;
import java.util.logging.Level;
import org.bukkit.plugin.Plugin;
@ -28,7 +29,7 @@ public class AsyncListenerHandler {
private volatile boolean cancelled;
// If we've started the listener loop before
private volatile int started;
private AtomicInteger started = new AtomicInteger();
// The packet listener
private PacketListener listener;
@ -153,7 +154,7 @@ public class AsyncListenerHandler {
throw new IllegalStateException("Listener has been cancelled. Create a new listener instead.");
// Proceed
started++;
started.incrementAndGet();
try {
mainLoop:
@ -198,7 +199,7 @@ public class AsyncListenerHandler {
// We're done
} finally {
// Clean up
started--;
started.decrementAndGet();
close();
}
}
@ -221,7 +222,7 @@ public class AsyncListenerHandler {
// Poison Pill Shutdown
queuedPackets.clear();
for (int i = 0; i < started; i++)
for (int i = 0; i < started.get(); i++)
queuedPackets.add(INTERUPT_PACKET);
}
}