Upstream/ProtocolLib
1
0
Fork 0
mirror of https://github.com/dmulloy2/ProtocolLib.git synced 2025-02-18 21:41:48 +01:00
Code Issues Projects Releases Wiki Activity

Mark connectionHandler as sharable (#1179)

Browse Source 
Fixes #1170.

The reasoning for this PR is largely outlined in the above issue. As the ChannelInboundHandlerAdapter has no private class, a race condition cannot occur and therefore marking the class as sharable should incur no cost.
This commit is contained in:
Camotoy 2021-05-29 13:00:58 -04:00 committed by GitHub
parent 72c1f3e26c
commit 5acdb2b3c5
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 6 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/main/java/com/comphenix/protocol/injector/netty/ProtocolInjector.java
View File

@ -186,6 +186,12 @@ public class ProtocolInjector implements ChannelListener {
channel.pipeline().addFirst(beginInitProtocol); channel.pipeline().addFirst(beginInitProtocol);
ctx.fireChannelRead(msg); ctx.fireChannelRead(msg);
} }
@Override
public boolean isSharable() {
// Needed if multiple objects are stored in the bootstrap list
return true;
}
}; };
FuzzyReflection fuzzy = FuzzyReflection.fromObject(serverConnection, true); FuzzyReflection fuzzy = FuzzyReflection.fromObject(serverConnection, true);