Upstream/ProtocolLib
1
0
Fork 0
mirror of https://github.com/dmulloy2/ProtocolLib.git synced 2024-11-27 13:15:52 +01:00
Code Issues Projects Releases Wiki Activity

don't suppress deserialization issues (#1759)

Browse Source
This commit is contained in:
Pasqual Koschmieder 2022-07-24 16:08:35 +02:00 committed by GitHub
parent 96155b1065
commit 7f0bc7fd24
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 5 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/main/java/com/comphenix/protocol/events/PacketContainer.java
View File

@ -307,7 +307,7 @@ public class PacketContainer extends AbstractStructure implements Serializable {
handle = type.getPacketClass() handle = type.getPacketClass()
.getConstructor(MinecraftReflection.getPacketDataSerializerClass()) .getConstructor(MinecraftReflection.getPacketDataSerializerClass())
.newInstance(serializer); .newInstance(serializer);
} catch (ReflectiveOperationException ex) { } catch (NoSuchMethodException | IllegalAccessException | InstantiationException ex) {
// they might have a static method to create them instead // they might have a static method to create them instead
Method method = FuzzyReflection.fromClass(type.getPacketClass(), true) Method method = FuzzyReflection.fromClass(type.getPacketClass(), true)
.getMethod(FuzzyMethodContract .getMethod(FuzzyMethodContract
@ -318,9 +318,11 @@ public class PacketContainer extends AbstractStructure implements Serializable {
.build()); .build());
try { try {
handle = method.invoke(null, serializer); handle = method.invoke(null, serializer);
} catch (ReflectiveOperationException ignored) { } catch (ReflectiveOperationException exception) {
throw new RuntimeException("Failed to construct packet for " + type, ex); throw new RuntimeException("Failed to construct packet for " + type, exception);
} }
} catch (InvocationTargetException ex) {
throw new RuntimeException("Unable to clone packet " + type + " using constructor", ex.getCause());
} }
} else { } else {
handle = StructureCache.newPacket(type); handle = StructureCache.newPacket(type);