Upstream/ProtocolLib
1
0
Fork 0
mirror of https://github.com/dmulloy2/ProtocolLib.git synced 2024-06-26 23:04:44 +02:00
Code Issues Projects Releases Wiki Activity

Make sure the packet IDs are actually valid.

Browse Source
This commit is contained in:
Kristian S. Stangeland 2012-09-27 05:26:02 +02:00
parent eb8abd4635
commit 8293c71a4c
1 changed files with 16 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
ProtocolLib/src/com/comphenix/protocol/injector/PacketFilterManager.java
View File

@ -180,10 +180,12 @@ public final class PacketFilterManager implements ProtocolManager {
if (hasSending || hasReceiving) {
// Add listeners and hooks
if (hasSending) {
verifyWhitelist(listener, sending);
sendingListeners.addListener(listener, sending);
enablePacketFilters(ConnectionSide.SERVER_SIDE, sending.getWhitelist());
}
if (hasReceiving) {
verifyWhitelist(listener, receiving);
recievedListeners.addListener(listener, receiving);
enablePacketFilters(ConnectionSide.CLIENT_SIDE, receiving.getWhitelist());
@ -196,6 +198,20 @@ public final class PacketFilterManager implements ProtocolManager {
}
}
/**
* Determine if the packet IDs in a whitelist is valid.
* @param whitelist - whitelist of packet IDs.
*/
private void verifyWhitelist(PacketListener listener, ListeningWhitelist whitelist) {
for (Integer id : whitelist.getWhitelist()) {
if (id >= 256 || id < 0) {
throw new IllegalArgumentException(String.format("Invalid packet id %s in listener %s.",
id, PacketAdapter.getPluginName(listener))
);
}
}
}
/**
* Determine if a listener is valid or not.
* @param listener - listener to check.