Only compile pattern once

This commit is contained in:
Techcable 2015-03-15 23:01:24 -07:00
parent c7b9600c21
commit a078ddb6e6

View File

@ -42,7 +42,7 @@ public class MinecraftVersion implements Comparable<MinecraftVersion>, Serializa
/** /**
* Regular expression used to parse version strings. * Regular expression used to parse version strings.
*/ */
private static final String VERSION_PATTERN = ".*\\(.*MC.\\s*([a-zA-z0-9\\-\\.]+)\\s*\\)"; private static final Pattern VERSION_PATTERN = Pattern.compile(".*\\(.*MC.\\s*([a-zA-z0-9\\-\\.]+)\\s*\\)");
/** /**
* Version 1.8 - the "bountiful" update. * Version 1.8 - the "bountiful" update.
@ -293,8 +293,7 @@ public class MinecraftVersion implements Comparable<MinecraftVersion>, Serializa
* @throws IllegalStateException If we could not parse the version string. * @throws IllegalStateException If we could not parse the version string.
*/ */
public static String extractVersion(String text) { public static String extractVersion(String text) {
Pattern versionPattern = Pattern.compile(VERSION_PATTERN); Matcher version = VERSION_PATTERN.matcher(text);
Matcher version = versionPattern.matcher(text);
if (version.matches() && version.group(1) != null) { if (version.matches() && version.group(1) != null) {
return version.group(1); return version.group(1);