Upstream/ProtocolLib
1
0
Fork 0
mirror of https://github.com/dmulloy2/ProtocolLib.git synced 2024-10-04 10:37:32 +02:00
Code Issues Projects Releases Wiki Activity

Don't load classes when we're checking for them

Browse Source 
This causes a ton of lag and doesn't seem to ever work
Addresses #124
This commit is contained in:
Dan Mulloy 2015-10-31 13:47:45 -04:00
parent c40d9c1e6c
commit bd28035024
1 changed files with 14 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
ProtocolLib/src/main/java/com/comphenix/protocol/reflect/compiler/StructureCompiler.java
View File

@ -146,7 +146,9 @@ public final class StructureCompiler {
private static String SUPER_CLASS = "com/comphenix/protocol/reflect/StructureModifier";
private static String COMPILED_CLASS = PACKAGE_NAME + "/CompiledStructureModifier";
private static String FIELD_EXCEPTION_CLASS = "com/comphenix/protocol/reflect/FieldAccessException";
public static boolean attemptClassLoad = false;
/**
* Construct a structure compiler.
* @param loader - main class loader.
@ -163,18 +165,24 @@ public final class StructureCompiler {
*/
public <TField> boolean lookupClassLoader(StructureModifier<TField> source) {
StructureKey key = new StructureKey(source);
// See if there's a need to lookup the class name
if (compiledCache.containsKey(key)) {
return true;
}
if (! attemptClassLoad) {
return false;
}
// This causes a ton of lag and doesn't seem to work
try {
String className = getCompiledName(source);
// This class might have been generated before. Try to load it.
Class<?> before = loader.loadClass(PACKAGE_NAME.replace('/', '.') + "." + className);
if (before != null) {
compiledCache.put(key, before);
return true;
@ -182,7 +190,7 @@ public final class StructureCompiler {
} catch (ClassNotFoundException e) {
// That's ok.
}
// We need to compile the class
return false;
}