Upstream/ProtocolLib
1
0
Fork 0
mirror of https://github.com/dmulloy2/ProtocolLib.git synced 2024-11-09 12:20:16 +01:00
Code Issues Projects Releases Wiki Activity

Don't remove channel handlers in the main thread - can case deadlock.

Browse Source
This commit is contained in:
Kristian S. Stangeland 2014-04-09 02:57:52 +02:00
parent 8cb9e050a5
commit be238f6ac6
1 changed files with 12 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
Examples/TinyProtocol/src/main/java/com/comphenix/tinyprotocol/TinyProtocol.java
View File

@ -187,10 +187,20 @@ public abstract class TinyProtocol {
public final void close() { public final void close() {
if (!closed) { if (!closed) {
closed = true; closed = true;
// Compute this once
final String handlerName = getHandlerName();
// Remove our handlers // Remove our handlers
for (Player player : plugin.getServer().getOnlinePlayers()) { for (Player player : plugin.getServer().getOnlinePlayers()) {
getChannel(player).pipeline().remove(getHandlerName()); final Channel channel = getChannel(player);
// See ChannelInjector in ProtocolLib, line 590
channel.eventLoop().execute(new Runnable() {
@Override
public void run() {
channel.pipeline().remove(handlerName);
}
});
} }
// Clean up Bukkit // Clean up Bukkit