mirror of
https://github.com/dmulloy2/ProtocolLib.git
synced 2024-11-09 12:20:16 +01:00
Clean up every static field, preempting potential ClassLoader leaks.
Note that this method is using some fairly ugly hacks and must be maintained/updated manually whenever a new class is added or removed.
This commit is contained in:
parent
bdc41221db
commit
dfba924561
@ -0,0 +1,135 @@
|
|||||||
|
package com.comphenix.protocol;
|
||||||
|
|
||||||
|
import java.lang.reflect.Field;
|
||||||
|
import java.lang.reflect.Modifier;
|
||||||
|
import java.util.ArrayList;
|
||||||
|
import java.util.List;
|
||||||
|
import java.util.logging.Level;
|
||||||
|
import java.util.logging.Logger;
|
||||||
|
|
||||||
|
import com.comphenix.protocol.async.AsyncListenerHandler;
|
||||||
|
import com.comphenix.protocol.events.ListeningWhitelist;
|
||||||
|
import com.comphenix.protocol.events.PacketContainer;
|
||||||
|
import com.comphenix.protocol.injector.BukkitUnwrapper;
|
||||||
|
import com.comphenix.protocol.reflect.FieldUtils;
|
||||||
|
import com.comphenix.protocol.reflect.FuzzyReflection;
|
||||||
|
import com.comphenix.protocol.reflect.MethodUtils;
|
||||||
|
import com.comphenix.protocol.reflect.ObjectCloner;
|
||||||
|
import com.comphenix.protocol.reflect.PrimitiveUtils;
|
||||||
|
import com.comphenix.protocol.reflect.compiler.BackgroundCompiler;
|
||||||
|
import com.comphenix.protocol.reflect.compiler.StructureCompiler;
|
||||||
|
import com.comphenix.protocol.reflect.instances.CollectionGenerator;
|
||||||
|
import com.comphenix.protocol.reflect.instances.DefaultInstances;
|
||||||
|
import com.comphenix.protocol.reflect.instances.PrimitiveGenerator;
|
||||||
|
|
||||||
|
/**
|
||||||
|
* Used to fix ClassLoader leaks that may lead to filling up the permanent generation.
|
||||||
|
*
|
||||||
|
* @author Kristian
|
||||||
|
*/
|
||||||
|
class CleanupStaticMembers {
|
||||||
|
|
||||||
|
private ClassLoader loader;
|
||||||
|
private Logger logger;
|
||||||
|
|
||||||
|
public CleanupStaticMembers(ClassLoader loader, Logger logger) {
|
||||||
|
this.loader = loader;
|
||||||
|
this.logger = logger;
|
||||||
|
}
|
||||||
|
|
||||||
|
/**
|
||||||
|
* Ensure that the previous ClassLoader is not leaking.
|
||||||
|
*/
|
||||||
|
public void resetAll() {
|
||||||
|
// This list must always be updated
|
||||||
|
Class<?>[] publicClasses = {
|
||||||
|
AsyncListenerHandler.class, ListeningWhitelist.class, PacketContainer.class,
|
||||||
|
BukkitUnwrapper.class, CollectionGenerator.class, DefaultInstances.class,
|
||||||
|
PrimitiveGenerator.class, FuzzyReflection.class, MethodUtils.class,
|
||||||
|
BackgroundCompiler.class, StructureCompiler.class,
|
||||||
|
ObjectCloner.class, PrimitiveUtils.class, Packets.Server.class,
|
||||||
|
Packets.Client.class
|
||||||
|
};
|
||||||
|
|
||||||
|
String[] internalClasses = {
|
||||||
|
"com.comphenix.protocol.events.SerializedOfflinePlayer",
|
||||||
|
"com.comphenix.protocol.injector.player.InjectedServerConnection",
|
||||||
|
"com.comphenix.protocol.injector.player.NetworkFieldInjector",
|
||||||
|
"com.comphenix.protocol.injector.player.NetworkObjectInjector",
|
||||||
|
"com.comphenix.protocol.injector.player.NetworkServerInjector",
|
||||||
|
"com.comphenix.protocol.injector.player.PlayerInjector",
|
||||||
|
"com.comphenix.protocol.injector.player.TemporaryPlayerFactory",
|
||||||
|
"com.comphenix.protocol.injector.EntityUtilities",
|
||||||
|
"com.comphenix.protocol.injector.MinecraftRegistry",
|
||||||
|
"com.comphenix.protocol.injector.PacketInjector",
|
||||||
|
"com.comphenix.protocol.injector.ReadPacketModifier",
|
||||||
|
"com.comphenix.protocol.injector.StructureCache",
|
||||||
|
"com.comphenix.protocol.reflect.compiler.BoxingHelper",
|
||||||
|
"com.comphenix.protocol.reflect.compiler.MethodDescriptor"
|
||||||
|
};
|
||||||
|
|
||||||
|
resetClasses(publicClasses);
|
||||||
|
resetClasses(getClasses(loader, internalClasses));
|
||||||
|
}
|
||||||
|
|
||||||
|
private void resetClasses(Class<?>[] classes) {
|
||||||
|
// Reset each class one by one
|
||||||
|
for (Class<?> clazz : classes) {
|
||||||
|
resetClass(clazz);
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
private void resetClass(Class<?> clazz) {
|
||||||
|
for (Field field : clazz.getFields()) {
|
||||||
|
Class<?> type = field.getType();
|
||||||
|
|
||||||
|
// Only check static non-primitive fields. We also skip strings.
|
||||||
|
if (Modifier.isStatic(field.getModifiers()) &&
|
||||||
|
!type.isPrimitive() && !type.equals(String.class)) {
|
||||||
|
|
||||||
|
try {
|
||||||
|
setFinalStatic(field, null);
|
||||||
|
} catch (IllegalAccessException e) {
|
||||||
|
// Just inform us
|
||||||
|
logger.warning("Unable to reset field " + field.getName() + ": " + e.getMessage());
|
||||||
|
}
|
||||||
|
}
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
// HACK! HAACK!
|
||||||
|
private static void setFinalStatic(Field field, Object newValue) throws IllegalAccessException {
|
||||||
|
int modifier = field.getModifiers();
|
||||||
|
boolean isFinal = Modifier.isFinal(modifier);
|
||||||
|
|
||||||
|
Field modifiersField = isFinal ? FieldUtils.getField(Field.class, "modifiers", true) : null;
|
||||||
|
|
||||||
|
// We have to remove the final field first
|
||||||
|
if (isFinal) {
|
||||||
|
FieldUtils.writeField(modifiersField, field, modifier & ~Modifier.FINAL, true);
|
||||||
|
}
|
||||||
|
|
||||||
|
// Now we can safely modify the field
|
||||||
|
FieldUtils.writeStaticField(field, newValue, true);
|
||||||
|
|
||||||
|
// Revert modifier
|
||||||
|
if (isFinal) {
|
||||||
|
FieldUtils.writeField(modifiersField, field, modifier, true);
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
private Class<?>[] getClasses(ClassLoader loader, String[] names) {
|
||||||
|
List<Class<?>> output = new ArrayList<Class<?>>();
|
||||||
|
|
||||||
|
for (String name : names) {
|
||||||
|
try {
|
||||||
|
output.add(loader.loadClass(name));
|
||||||
|
} catch (ClassNotFoundException e) {
|
||||||
|
// Warn the user
|
||||||
|
logger.log(Level.WARNING, "Unable to unload class " + name, e);
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
return output.toArray(new Class<?>[0]);
|
||||||
|
}
|
||||||
|
}
|
@ -77,6 +77,8 @@ public class ProtocolLibrary extends JavaPlugin {
|
|||||||
Server server = getServer();
|
Server server = getServer();
|
||||||
PluginManager manager = server.getPluginManager();
|
PluginManager manager = server.getPluginManager();
|
||||||
|
|
||||||
|
System.out.println("Created using ClassLoader " + getClassLoader().hashCode());
|
||||||
|
|
||||||
// Initialize background compiler
|
// Initialize background compiler
|
||||||
if (backgroundCompiler == null) {
|
if (backgroundCompiler == null) {
|
||||||
backgroundCompiler = new BackgroundCompiler(getClassLoader());
|
backgroundCompiler = new BackgroundCompiler(getClassLoader());
|
||||||
|
Loading…
Reference in New Issue
Block a user