Upstream
/
ProtocolLib
mirror of https://github.com/dmulloy2/ProtocolLib.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

prevent buffer memory leaks

This commit is contained in:
derklaro 2022-07-30 13:38:48 +02:00 committed by Dan Mulloy
parent b02d2bec32
commit e337035a68
1 changed files with 9 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
src/main/java/com/comphenix/protocol/events/PacketContainer.java
View File

@ -21,6 +21,8 @@ import com.comphenix.protocol.reflect.accessors.Accessors;
import com.comphenix.protocol.reflect.accessors.ConstructorAccessor;
import com.comphenix.protocol.reflect.accessors.MethodAccessor;
import com.comphenix.protocol.reflect.instances.DefaultInstances;
import io.netty.buffer.ByteBufUtil;
import io.netty.util.ReferenceCountUtil;
import java.util.List;
import java.util.Map;
import java.util.Objects;
@ -241,6 +243,8 @@ public class PacketContainer extends AbstractStructure implements Serializable {
Object serialized = this.serializeToBuffer();
Object deserialized = deserializeFromBuffer(this.type, serialized);
// ensure that we don't leak memory
ReferenceCountUtil.safeRelease(serialized);
return new PacketContainer(this.type, deserialized);
}
@ -277,6 +281,9 @@ public class PacketContainer extends AbstractStructure implements Serializable {
output.writeBoolean(true);
output.writeInt(buffer.readableBytes());
buffer.readBytes(output, buffer.readableBytes());
// ensure that we don't leak memory
ReferenceCountUtil.safeRelease(buffer);
} else {
output.writeBoolean(false);
}
@ -305,7 +312,9 @@ public class PacketContainer extends AbstractStructure implements Serializable {
}
}
// deserialize & ensure that we don't leak memory
Object packet = deserializeFromBuffer(this.type, byteBuf);
ReferenceCountUtil.safeRelease(byteBuf);
this.handle = packet;
this.structureModifier = this.structureModifier.withTarget(packet);