Inspect code

This commit is contained in:
AppleDash 2016-09-18 05:11:22 -04:00
parent 66dfba087e
commit 1c217be26a
5 changed files with 7 additions and 21 deletions

View File

@ -1,23 +1,14 @@
package org.appledash.saneeconomy;
import com.google.common.base.Strings;
import org.appledash.saneeconomy.command.SaneEconomyCommand;
import org.appledash.saneeconomy.command.type.*;
import org.appledash.saneeconomy.economy.Currency;
import org.appledash.saneeconomy.economy.EconomyManager;
import org.appledash.saneeconomy.economy.backend.EconomyStorageBackend;
import org.appledash.saneeconomy.economy.backend.type.EconomyStorageBackendFlatfile;
import org.appledash.saneeconomy.economy.backend.type.EconomyStorageBackendMySQL;
import org.appledash.saneeconomy.economy.economable.EconomableGeneric;
import org.appledash.saneeconomy.economy.logger.TransactionLogger;
import org.appledash.saneeconomy.listeners.JoinQuitListener;
import org.appledash.saneeconomy.updates.GithubVersionChecker;
import org.appledash.saneeconomy.utils.DatabaseCredentials;
import org.appledash.saneeconomy.utils.I18n;
import org.appledash.saneeconomy.utils.SaneEconomyConfiguration;
import org.appledash.saneeconomy.vault.VaultHook;
import org.bukkit.configuration.Configuration;
import org.bukkit.configuration.ConfigurationSection;
import org.bukkit.plugin.java.JavaPlugin;
import java.io.File;
@ -28,8 +19,6 @@ import java.util.logging.Logger;
/**
* Created by AppleDash on 6/13/2016.
* Blackjack is still best pony.
*
* FIXME: Why is the backend and config loading so complex and why is it even in this class?
*/
public class SaneEconomy extends JavaPlugin implements ISaneEconomy {
private static SaneEconomy instance;
@ -103,6 +92,8 @@ public class SaneEconomy extends JavaPlugin implements ISaneEconomy {
economyManager = saneEconomyConfiguration.loadEconomyBackend();
saveConfig();
return economyManager != null;
}

View File

@ -4,7 +4,6 @@ import org.appledash.saneeconomy.SaneEconomy;
import org.appledash.saneeconomy.command.exception.CommandException;
import org.appledash.saneeconomy.command.exception.type.NoPermissionException;
import org.appledash.saneeconomy.command.exception.type.usage.UsageException;
import org.appledash.saneeconomy.command.type.SaneEcoCommand;
import org.appledash.saneeconomy.utils.MessageUtils;
import org.bukkit.command.Command;
import org.bukkit.command.CommandExecutor;
@ -15,7 +14,7 @@ import org.bukkit.command.CommandSender;
* Blackjack is still best pony.
*/
public abstract class SaneEconomyCommand implements CommandExecutor {
protected SaneEconomy saneEconomy;
protected final SaneEconomy saneEconomy;
public SaneEconomyCommand(SaneEconomy saneEconomy) {
this.saneEconomy = saneEconomy;

View File

@ -1,7 +1,6 @@
package org.appledash.saneeconomy.economy;
import org.bukkit.configuration.Configuration;
import org.bukkit.configuration.file.FileConfiguration;
import java.text.DecimalFormat;

View File

@ -1,7 +1,6 @@
package org.appledash.saneeconomy.economy;
import org.appledash.saneeconomy.ISaneEconomy;
import org.appledash.saneeconomy.SaneEconomy;
import org.appledash.saneeconomy.economy.backend.EconomyStorageBackend;
import org.appledash.saneeconomy.economy.economable.Economable;
import org.appledash.saneeconomy.utils.NumberUtils;
@ -19,7 +18,7 @@ import java.util.UUID;
* Represents our EconomyManager, which manages players' balances.
*/
public class EconomyManager {
private ISaneEconomy saneEconomy;
private final ISaneEconomy saneEconomy;
private final Currency currency;
private final EconomyStorageBackend backend;

View File

@ -1,7 +1,6 @@
package org.appledash.saneeconomy.utils;
import com.google.common.base.Strings;
import org.appledash.saneeconomy.ISaneEconomy;
import org.appledash.saneeconomy.SaneEconomy;
import org.appledash.saneeconomy.economy.Currency;
import org.appledash.saneeconomy.economy.EconomyManager;
@ -9,7 +8,6 @@ import org.appledash.saneeconomy.economy.backend.EconomyStorageBackend;
import org.appledash.saneeconomy.economy.backend.type.EconomyStorageBackendFlatfile;
import org.appledash.saneeconomy.economy.backend.type.EconomyStorageBackendMySQL;
import org.appledash.saneeconomy.economy.economable.EconomableGeneric;
import org.appledash.saneeconomy.economy.logger.TransactionLogger;
import org.bukkit.configuration.Configuration;
import org.bukkit.configuration.ConfigurationSection;
@ -21,9 +19,9 @@ import java.util.logging.Logger;
* Blackjack is best pony.
*/
public class SaneEconomyConfiguration {
private Logger logger;
private SaneEconomy saneEconomy;
private Configuration rootConfig;
private final Logger logger;
private final SaneEconomy saneEconomy;
private final Configuration rootConfig;
public SaneEconomyConfiguration(SaneEconomy saneEconomy) {
this.saneEconomy = saneEconomy;