Upstream
/
SongodaCore
mirror of https://github.com/songoda/SongodaCore.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

Fix error handling of SongodaYamlConfig#load(Reader)

This commit is contained in:
Christian Koop 2022-08-21 20:44:41 +02:00
parent eea951ecc6
commit 163e4d9eaf
No known key found for this signature in database
GPG Key ID: 89A8181384E010A3
1 changed files with 2 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
Core/src/main/java/com/songoda/core/configuration/songoda/SongodaYamlConfig.java
View File

@ -150,21 +150,10 @@ public class SongodaYamlConfig extends YamlConfiguration {
}
@Override
public void load(Reader reader) {
public void load(Reader reader) throws IOException {
super.load(reader);
// FIXME: The interface does not allow to throw an exception, so we log it instead.
try {
upgradeOldConfigVersion();
} catch (IOException ex) {
if (ex.getMessage().startsWith(this.cannotCreateBackupCopyExceptionPrefix)) {
// Failed to create backup copy, but we can still continue.
this.logger.log(Level.SEVERE, null, ex);
} else {
// This is a real unexpected exception, so we rethrow it.
throw new IllegalStateException(ex);
}
}
upgradeOldConfigVersion();
for (ConfigEntry entry : this.configEntries.values()) {
if (entry.get() == null && entry.getDefaultValue() != null) {