diff --git a/SubServers.Bungee/common/src/net/ME1312/SubServers/Bungee/Library/Compatibility/Logger.java b/SubServers.Bungee/common/src/net/ME1312/SubServers/Bungee/Library/Compatibility/Logger.java index adff8d37..d7d03292 100644 --- a/SubServers.Bungee/common/src/net/ME1312/SubServers/Bungee/Library/Compatibility/Logger.java +++ b/SubServers.Bungee/common/src/net/ME1312/SubServers/Bungee/Library/Compatibility/Logger.java @@ -19,7 +19,7 @@ public class Logger { * @return Logger */ public static java.util.logging.Logger get(String prefix) { - if (!existing.keySet().contains(prefix)) { + if (!existing.containsKey(prefix)) { java.util.logging.Logger log = java.util.logging.Logger.getAnonymousLogger(); log.setUseParentHandlers(false); log.addHandler(new Handler() { diff --git a/SubServers.Bungee/common/src/net/ME1312/SubServers/Bungee/Library/Fallback/SmartFallback.java b/SubServers.Bungee/common/src/net/ME1312/SubServers/Bungee/Library/Fallback/SmartFallback.java index ee4286a3..e93386bb 100644 --- a/SubServers.Bungee/common/src/net/ME1312/SubServers/Bungee/Library/Fallback/SmartFallback.java +++ b/SubServers.Bungee/common/src/net/ME1312/SubServers/Bungee/Library/Fallback/SmartFallback.java @@ -153,7 +153,7 @@ public class SmartFallback implements ReconnectHandler { } if (valid) { - List servers = (score.keySet().contains(confidence))?score.get(confidence):new LinkedList(); + List servers = (score.containsKey(confidence))?score.get(confidence):new LinkedList(); servers.add(server); score.put(confidence, servers); } diff --git a/SubServers.Bungee/src/net/ME1312/SubServers/Bungee/Host/External/ExternalHost.java b/SubServers.Bungee/src/net/ME1312/SubServers/Bungee/Host/External/ExternalHost.java index feaee927..d734abb3 100644 --- a/SubServers.Bungee/src/net/ME1312/SubServers/Bungee/Host/External/ExternalHost.java +++ b/SubServers.Bungee/src/net/ME1312/SubServers/Bungee/Host/External/ExternalHost.java @@ -81,7 +81,7 @@ public class ExternalHost extends Host implements ClientHandler { if (channel < 0) throw new IllegalArgumentException("Subchannel ID cannot be less than zero"); if (client == null && channel == 0) available = false; if (client != null || channel == 0) { - if (!subdata.keySet().contains(channel) || (channel == 0 && (client == null || subdata.get(channel) == null))) { + if (!subdata.containsKey(channel) || (channel == 0 && (client == null || subdata.get(channel) == null))) { subdata.put(channel, (SubDataClient) client); if (client != null && (client.getHandler() == null || !equals(client.getHandler()))) ((SubDataClient) client).setHandler(this); } diff --git a/SubServers.Bungee/src/net/ME1312/SubServers/Bungee/Host/External/ExternalSubCreator.java b/SubServers.Bungee/src/net/ME1312/SubServers/Bungee/Host/External/ExternalSubCreator.java index 6cd0e1ec..9da2fd6b 100644 --- a/SubServers.Bungee/src/net/ME1312/SubServers/Bungee/Host/External/ExternalSubCreator.java +++ b/SubServers.Bungee/src/net/ME1312/SubServers/Bungee/Host/External/ExternalSubCreator.java @@ -94,7 +94,7 @@ public class ExternalSubCreator extends SubCreator { @Override public boolean create(UUID player, String name, ServerTemplate template, Version version, Integer port, Consumer callback) { Util.nullpo(name, template); - if (host.isAvailable() && host.isEnabled() && template.isEnabled() && !SubAPI.getInstance().getSubServers().keySet().contains(name.toLowerCase()) && !SubCreator.isReserved(name) && (version != null || !template.requiresVersion())) { + if (host.isAvailable() && host.isEnabled() && template.isEnabled() && !SubAPI.getInstance().getSubServers().containsKey(name.toLowerCase()) && !SubCreator.isReserved(name) && (version != null || !template.requiresVersion())) { StackTraceElement[] origin = new Throwable().getStackTrace(); if (port == null) { @@ -174,7 +174,7 @@ public class ExternalSubCreator extends SubCreator { Logger.get(prefix).info("Saving..."); SubServer subserver = update; if (update == null || update.getTemplate() != template || template.getBuildOptions().getBoolean("Update-Settings", false)) { - if (host.plugin.exServers.keySet().contains(name.toLowerCase())) + if (host.plugin.exServers.containsKey(name.toLowerCase())) host.plugin.exServers.remove(name.toLowerCase()); ObjectMap server = new ObjectMap(); @@ -257,7 +257,7 @@ public class ExternalSubCreator extends SubCreator { @Override public void terminate(String name) { - if (this.thread.keySet().contains(name.toLowerCase())) { + if (this.thread.containsKey(name.toLowerCase())) { ((SubDataClient) host.getSubData()[0]).sendPacket(new PacketExCreateServer(name.toLowerCase())); thread.remove(name.toLowerCase()); } @@ -274,7 +274,7 @@ public class ExternalSubCreator extends SubCreator { @Override public void waitFor(String name) throws InterruptedException { - while (this.thread.keySet().contains(name.toLowerCase()) && host.getSubData()[0] != null) { + while (this.thread.containsKey(name.toLowerCase()) && host.getSubData()[0] != null) { Thread.sleep(250); } } diff --git a/SubServers.Bungee/src/net/ME1312/SubServers/Bungee/Host/Internal/InternalSubCreator.java b/SubServers.Bungee/src/net/ME1312/SubServers/Bungee/Host/Internal/InternalSubCreator.java index 716e0a3f..59dca698 100644 --- a/SubServers.Bungee/src/net/ME1312/SubServers/Bungee/Host/Internal/InternalSubCreator.java +++ b/SubServers.Bungee/src/net/ME1312/SubServers/Bungee/Host/Internal/InternalSubCreator.java @@ -276,7 +276,7 @@ public class InternalSubCreator extends SubCreator { Logger.get(prefix).info("Saving..."); SubServer subserver = update; if (update == null || update.getTemplate() != template || template.getBuildOptions().getBoolean("Update-Settings", false)) { - if (host.plugin.exServers.keySet().contains(name.toLowerCase())) + if (host.plugin.exServers.containsKey(name.toLowerCase())) host.plugin.exServers.remove(name.toLowerCase()); config = new ObjectMap((Map) replacements.replace(config.get())); @@ -389,7 +389,7 @@ public class InternalSubCreator extends SubCreator { @Override public boolean create(UUID player, String name, ServerTemplate template, Version version, Integer port, Consumer callback) { Util.nullpo(name, template); - if (host.isAvailable() && host.isEnabled() && template.isEnabled() && !SubAPI.getInstance().getSubServers().keySet().contains(name.toLowerCase()) && !SubCreator.isReserved(name) && (version != null || !template.requiresVersion())) { + if (host.isAvailable() && host.isEnabled() && template.isEnabled() && !SubAPI.getInstance().getSubServers().containsKey(name.toLowerCase()) && !SubCreator.isReserved(name) && (version != null || !template.requiresVersion())) { StackTraceElement[] origin = new Throwable().getStackTrace(); if (port == null) { @@ -470,7 +470,7 @@ public class InternalSubCreator extends SubCreator { @Override public void terminate(String name) { - if (this.thread.keySet().contains(name.toLowerCase())) { + if (this.thread.containsKey(name.toLowerCase())) { if (this.thread.get(name.toLowerCase()).process != null && this.thread.get(name.toLowerCase()).process.isAlive()) { Executable.terminate(this.thread.get(name.toLowerCase()).process); } else if (this.thread.get(name.toLowerCase()).isAlive()) { @@ -491,7 +491,7 @@ public class InternalSubCreator extends SubCreator { @Override public void waitFor(String name) throws InterruptedException { - while (this.thread.keySet().contains(name.toLowerCase()) && this.thread.get(name.toLowerCase()).isAlive()) { + while (this.thread.containsKey(name.toLowerCase()) && this.thread.get(name.toLowerCase()).isAlive()) { Thread.sleep(250); } } diff --git a/SubServers.Bungee/src/net/ME1312/SubServers/Bungee/Host/Proxy.java b/SubServers.Bungee/src/net/ME1312/SubServers/Bungee/Host/Proxy.java index 4c5a8698..2ea80395 100644 --- a/SubServers.Bungee/src/net/ME1312/SubServers/Bungee/Host/Proxy.java +++ b/SubServers.Bungee/src/net/ME1312/SubServers/Bungee/Host/Proxy.java @@ -50,7 +50,7 @@ public class Proxy implements ClientHandler, ExtraDataHandler { boolean update = false; if (channel < 0) throw new IllegalArgumentException("Subchannel ID cannot be less than zero"); if (client != null || channel == 0) { - if (!subdata.keySet().contains(channel) || (channel == 0 && (client == null || subdata.get(channel) == null))) { + if (!subdata.containsKey(channel) || (channel == 0 && (client == null || subdata.get(channel) == null))) { update = true; subdata.put(channel, client); if (client != null && (client.getHandler() == null || !equals(client.getHandler()))) client.setHandler(this); diff --git a/SubServers.Bungee/src/net/ME1312/SubServers/Bungee/Host/ServerImpl.java b/SubServers.Bungee/src/net/ME1312/SubServers/Bungee/Host/ServerImpl.java index 80cb669e..5fa61d02 100644 --- a/SubServers.Bungee/src/net/ME1312/SubServers/Bungee/Host/ServerImpl.java +++ b/SubServers.Bungee/src/net/ME1312/SubServers/Bungee/Host/ServerImpl.java @@ -105,7 +105,7 @@ public class ServerImpl extends BungeeServerInfo implements Server { boolean update = false; if (channel < 0) throw new IllegalArgumentException("Subchannel ID cannot be less than zero"); if (client != null || channel == 0) { - if (!subdata.keySet().contains(channel) || (channel == 0 && (client == null || subdata.get(channel) == null))) { + if (!subdata.containsKey(channel) || (channel == 0 && (client == null || subdata.get(channel) == null))) { update = true; subdata.put(channel, (SubDataClient) client); if (client != null && (client.getHandler() == null || !equals(client.getHandler()))) ((SubDataClient) client).setHandler(this); diff --git a/SubServers.Bungee/src/net/ME1312/SubServers/Bungee/Host/SubServerImpl.java b/SubServers.Bungee/src/net/ME1312/SubServers/Bungee/Host/SubServerImpl.java index 7dfd3439..18113d58 100644 --- a/SubServers.Bungee/src/net/ME1312/SubServers/Bungee/Host/SubServerImpl.java +++ b/SubServers.Bungee/src/net/ME1312/SubServers/Bungee/Host/SubServerImpl.java @@ -114,7 +114,7 @@ public abstract class SubServerImpl extends ServerImpl implements SubServer { public SubCreator.ServerTemplate getTemplate() { if (templateV != null) { return templateV; - } else if (templateS != null && getHost().getCreator().getTemplates().keySet().contains(templateS.toLowerCase())) { + } else if (templateS != null && getHost().getCreator().getTemplates().containsKey(templateS.toLowerCase())) { return getHost().getCreator().getTemplate(templateS.toLowerCase()); } else { return null; diff --git a/SubServers.Bungee/src/net/ME1312/SubServers/Bungee/Library/ConfigUpdater.java b/SubServers.Bungee/src/net/ME1312/SubServers/Bungee/Library/ConfigUpdater.java index e401e1b2..3abde874 100644 --- a/SubServers.Bungee/src/net/ME1312/SubServers/Bungee/Library/ConfigUpdater.java +++ b/SubServers.Bungee/src/net/ME1312/SubServers/Bungee/Library/ConfigUpdater.java @@ -324,9 +324,13 @@ public class ConfigUpdater { existing = updated.clone(); i++; - } if (was.compareTo(new Version("22w10a")) <= 0) { + } if (was.compareTo(new Version("22w11a")) <= 0) { if (existing.contains("Lang")) { updated.getMap("Lang").remove("Command.Teleport"); + LinkedList keys = new LinkedList<>(existing.getMap("Lang").getKeys()); + for (String key : keys) if (key.startsWith("Signs.")) { + updated.getMap("Lang").remove(key); + } } existing = updated.clone(); @@ -363,11 +367,11 @@ public class ConfigUpdater { def.put("Bungee.List.Total", "Total players online: $int$"); def.put("Signs.Create", "&aSubServers &2&l\\u00BB&a Server sign activated"); def.put("Signs.Delete", "&aSubServers &2&l\\u00BB&a Server sign removed"); - def.put("Signs.Text.Error", "&f&oSubServers\\n&3$str$\\n&7Unknown Status\\n&8\\u2022 \\u2022 \\u2022 \\u2022 \\u2022 \\u2022 \\u2022"); - def.put("Signs.Text.Offline", "&c&oSubServers\\n&3#subserver.displayname($str$)\\n&4Offline\\n&7Click to Start"); - def.put("Signs.Text.Starting", "&e&oSubServers\\n&3#subserver.displayname($str$)\\n&6Starting\\n&8\\u2022 \\u2022 \\u2022 \\u2022 \\u2022 \\u2022 \\u2022"); - def.put("Signs.Text.Online", "&a&oSubServers\\n&3#subserver.displayname($str$)\\n&2#subserver.players($str$) Online\\n&7Click to Join"); - def.put("Signs.Text.Stopping", "&e&oSubServers\\n&3#subserver.displayname($str$)\\n&6Stopping\\n&8\\u2022 \\u2022 \\u2022 \\u2022 \\u2022 \\u2022 \\u2022"); + def.put("Signs.Text.Unknown", "&f&oSubServers\\n&3$str$\\n&7Unknown Status\\n&8\\u2022 \\u2022 \\u2022 \\u2022 \\u2022 \\u2022 \\u2022"); + def.put("Signs.Text.Offline", "&c&oSubServers\\n&3$str$\\n&4Offline\\n&7Click to Start"); + def.put("Signs.Text.Starting", "&e&oSubServers\\n&3$str$\\n&6Starting\\n&8\\u2022 \\u2022 \\u2022 \\u2022 \\u2022 \\u2022 \\u2022"); + def.put("Signs.Text.Online", "&a&oSubServers\\n&3$str$\\n&2$int$ Online\\n&7Click to Join"); + def.put("Signs.Text.Stopping", "&e&oSubServers\\n&3$str$\\n&6Stopping\\n&8\\u2022 \\u2022 \\u2022 \\u2022 \\u2022 \\u2022 \\u2022"); def.put("Command.Generic.Player-Only", "&cSubServers &4&l\\u00BB&c The console cannot perform this command"); def.put("Command.Generic.Console-Only", "&cSubServers &4&l\\u00BB&c This command is for console use only"); def.put("Command.Generic.Usage", "&7SubServers &8&l\\u00BB&7 Usage: &f$str$"); diff --git a/SubServers.Bungee/src/net/ME1312/SubServers/Bungee/Library/ReplacementScanner.java b/SubServers.Bungee/src/net/ME1312/SubServers/Bungee/Library/ReplacementScanner.java index 353bd004..6e8183dd 100644 --- a/SubServers.Bungee/src/net/ME1312/SubServers/Bungee/Library/ReplacementScanner.java +++ b/SubServers.Bungee/src/net/ME1312/SubServers/Bungee/Library/ReplacementScanner.java @@ -15,7 +15,7 @@ public class ReplacementScanner extends FileScanner { TreeMap> order = new TreeMap>(Comparator.reverseOrder()); for (String key : replacements.keySet()) { int length = key.length(); - if (!order.keySet().contains(length)) order.put(length, new LinkedList<>()); + if (!order.containsKey(length)) order.put(length, new LinkedList<>()); order.get(length).add(key); } diff --git a/SubServers.Bungee/src/net/ME1312/SubServers/Bungee/Network/Packet/PacketAddServer.java b/SubServers.Bungee/src/net/ME1312/SubServers/Bungee/Network/Packet/PacketAddServer.java index 1146b5c7..da06f838 100644 --- a/SubServers.Bungee/src/net/ME1312/SubServers/Bungee/Network/Packet/PacketAddServer.java +++ b/SubServers.Bungee/src/net/ME1312/SubServers/Bungee/Network/Packet/PacketAddServer.java @@ -62,7 +62,7 @@ public class PacketAddServer implements PacketObjectIn, PacketObjectOut ObjectMap opt = new ObjectMap<>((Map)data.getObject(0x0003)); UUID player = (data.contains(0x0004)?data.getUUID(0x0004):null); - if (plugin.api.getServers().keySet().contains(name.toLowerCase())) { + if (plugin.api.getServers().containsKey(name.toLowerCase())) { client.sendPacket(new PacketAddServer(3, tracker)); } else { if (!subserver) { @@ -72,7 +72,7 @@ public class PacketAddServer implements PacketObjectIn, PacketObjectOut } else { client.sendPacket(new PacketAddServer(1, tracker)); } - } else if (!plugin.api.getHosts().keySet().contains(opt.getString("host").toLowerCase())) { + } else if (!plugin.api.getHosts().containsKey(opt.getString("host").toLowerCase())) { client.sendPacket(new PacketAddServer(4, tracker)); } else { if (plugin.api.getHost(opt.getString("host")).addSubServer(player, name, opt.getBoolean("enabled"), opt.getInt("port"), ChatColor.translateAlternateColorCodes('&', Util.unescapeJavaString(opt.getString("motd"))), diff --git a/SubServers.Bungee/src/net/ME1312/SubServers/Bungee/Network/Packet/PacketCommandServer.java b/SubServers.Bungee/src/net/ME1312/SubServers/Bungee/Network/Packet/PacketCommandServer.java index 92d05e01..b4380dd9 100644 --- a/SubServers.Bungee/src/net/ME1312/SubServers/Bungee/Network/Packet/PacketCommandServer.java +++ b/SubServers.Bungee/src/net/ME1312/SubServers/Bungee/Network/Packet/PacketCommandServer.java @@ -59,7 +59,7 @@ public class PacketCommandServer implements PacketObjectIn, PacketObjec UUID target = (data.contains(0x0004)?data.getUUID(0x0004):null); Map servers = plugin.api.getServers(); - if (!server.equals("*") && !servers.keySet().contains(server.toLowerCase())) { + if (!server.equals("*") && !servers.containsKey(server.toLowerCase())) { client.sendPacket(new PacketCommandServer(3, tracker)); } else if (!server.equals("*") && !(target == null && servers.get(server.toLowerCase()) instanceof SubServer) && servers.get(server.toLowerCase()).getSubData()[0] == null) { client.sendPacket(new PacketCommandServer(4, tracker)); diff --git a/SubServers.Bungee/src/net/ME1312/SubServers/Bungee/Network/Packet/PacketCreateServer.java b/SubServers.Bungee/src/net/ME1312/SubServers/Bungee/Network/Packet/PacketCreateServer.java index d7884855..db35aeec 100644 --- a/SubServers.Bungee/src/net/ME1312/SubServers/Bungee/Network/Packet/PacketCreateServer.java +++ b/SubServers.Bungee/src/net/ME1312/SubServers/Bungee/Network/Packet/PacketCreateServer.java @@ -60,15 +60,15 @@ public class PacketCreateServer implements PacketObjectIn, PacketObject if (name.contains(" ")) { client.sendPacket(new PacketCreateServer(3, tracker)); - } else if (plugin.api.getSubServers().keySet().contains(name.toLowerCase()) || SubCreator.isReserved(name)) { + } else if (plugin.api.getSubServers().containsKey(name.toLowerCase()) || SubCreator.isReserved(name)) { client.sendPacket(new PacketCreateServer(4, tracker)); - } else if (!plugin.hosts.keySet().contains(host.toLowerCase())) { + } else if (!plugin.hosts.containsKey(host.toLowerCase())) { client.sendPacket(new PacketCreateServer(5, tracker)); } else if (!plugin.hosts.get(host.toLowerCase()).isAvailable()) { client.sendPacket(new PacketCreateServer(6, tracker)); } else if (!plugin.hosts.get(host.toLowerCase()).isEnabled()) { client.sendPacket(new PacketCreateServer(7, tracker)); - } else if (!plugin.hosts.get(host.toLowerCase()).getCreator().getTemplates().keySet().contains(template.toLowerCase())) { + } else if (!plugin.hosts.get(host.toLowerCase()).getCreator().getTemplates().containsKey(template.toLowerCase())) { client.sendPacket(new PacketCreateServer(8, tracker)); } else if (!plugin.hosts.get(host.toLowerCase()).getCreator().getTemplate(template).isEnabled()) { client.sendPacket(new PacketCreateServer(9, tracker)); diff --git a/SubServers.Bungee/src/net/ME1312/SubServers/Bungee/Network/Packet/PacketDeleteServer.java b/SubServers.Bungee/src/net/ME1312/SubServers/Bungee/Network/Packet/PacketDeleteServer.java index 86ebc2ba..e0085954 100644 --- a/SubServers.Bungee/src/net/ME1312/SubServers/Bungee/Network/Packet/PacketDeleteServer.java +++ b/SubServers.Bungee/src/net/ME1312/SubServers/Bungee/Network/Packet/PacketDeleteServer.java @@ -59,7 +59,7 @@ public class PacketDeleteServer implements PacketObjectIn, PacketObject UUID player = (data.contains(0x0004)?data.getUUID(0x0004):null); Map servers = plugin.api.getServers(); - if (!servers.keySet().contains(name.toLowerCase())) { + if (!servers.containsKey(name.toLowerCase())) { client.sendPacket(new PacketDeleteServer(3, tracker)); } else if (!(servers.get(name.toLowerCase()) instanceof SubServer)) { client.sendPacket(new PacketDeleteServer(4, tracker)); diff --git a/SubServers.Bungee/src/net/ME1312/SubServers/Bungee/Network/Packet/PacketEditServer.java b/SubServers.Bungee/src/net/ME1312/SubServers/Bungee/Network/Packet/PacketEditServer.java index 9e02017a..0ae0c170 100644 --- a/SubServers.Bungee/src/net/ME1312/SubServers/Bungee/Network/Packet/PacketEditServer.java +++ b/SubServers.Bungee/src/net/ME1312/SubServers/Bungee/Network/Packet/PacketEditServer.java @@ -74,7 +74,7 @@ public class PacketEditServer implements PacketObjectIn, PacketObjectOu UUID player = (data.contains(0x0004)?data.getUUID(0x0004):null); Map servers = plugin.api.getServers(); - if (!servers.keySet().contains(name.toLowerCase())) { + if (!servers.containsKey(name.toLowerCase())) { client.sendPacket(new PacketEditServer(3, tracker)); } else if (!(servers.get(name.toLowerCase()) instanceof SubServer)) { client.sendPacket(new PacketEditServer(4, tracker)); diff --git a/SubServers.Bungee/src/net/ME1312/SubServers/Bungee/Network/Packet/PacketLinkExHost.java b/SubServers.Bungee/src/net/ME1312/SubServers/Bungee/Network/Packet/PacketLinkExHost.java index c62a8d11..d41183ef 100644 --- a/SubServers.Bungee/src/net/ME1312/SubServers/Bungee/Network/Packet/PacketLinkExHost.java +++ b/SubServers.Bungee/src/net/ME1312/SubServers/Bungee/Network/Packet/PacketLinkExHost.java @@ -59,12 +59,12 @@ public class PacketLinkExHost implements InitialPacket, PacketObjectIn, public void receive(SubDataClient client, ObjectMap data) { try { Map hosts = plugin.api.getHosts(); - if (hosts.keySet().contains(data.getString(0x0000).toLowerCase())) { + if (hosts.containsKey(data.getString(0x0000).toLowerCase())) { Host host = hosts.get(data.getString(0x0000).toLowerCase()); if (host instanceof ExternalHost) { Integer channel = data.getInt(0x0001); HashMap subdata = Try.all.get(() -> Util.reflect(ExternalHost.class.getDeclaredField("subdata"), host)); - if (!subdata.keySet().contains(channel) || (channel == 0 && subdata.get(0) == null)) { + if (!subdata.containsKey(channel) || (channel == 0 && subdata.get(0) == null)) { ((ExternalHost) host).setSubData(client, channel); Logger.get("SubData").info(client.getAddress().toString() + " has been defined as Host: " + host.getName() + ((channel > 0)?" [+"+channel+"]":"")); queue(host.getName(), () -> client.sendPacket(new PacketLinkExHost(0, null))); diff --git a/SubServers.Bungee/src/net/ME1312/SubServers/Bungee/Network/Packet/PacketLinkProxy.java b/SubServers.Bungee/src/net/ME1312/SubServers/Bungee/Network/Packet/PacketLinkProxy.java index 69596097..6fbdda12 100644 --- a/SubServers.Bungee/src/net/ME1312/SubServers/Bungee/Network/Packet/PacketLinkProxy.java +++ b/SubServers.Bungee/src/net/ME1312/SubServers/Bungee/Network/Packet/PacketLinkProxy.java @@ -66,15 +66,15 @@ public class PacketLinkProxy implements InitialPacket, PacketObjectIn, boolean isnew = false; Proxy proxy; - if (name != null && proxies.keySet().contains(name.toLowerCase())) { + if (name != null && proxies.containsKey(name.toLowerCase())) { proxy = proxies.get(name.toLowerCase()); } else { - proxy = new Proxy((name != null && !proxies.keySet().contains(name.toLowerCase()))?name:null); + proxy = new Proxy((name != null && !proxies.containsKey(name.toLowerCase()))?name:null); isnew = true; plugin.proxies.put(proxy.getName().toLowerCase(), proxy); } HashMap subdata = Try.all.get(() -> Util.reflect(Proxy.class.getDeclaredField("subdata"), proxy)); - if (!subdata.keySet().contains(channel) || (channel == 0 && subdata.get(0) == null)) { + if (!subdata.containsKey(channel) || (channel == 0 && subdata.get(0) == null)) { proxy.setSubData(client, channel); if (isnew) plugin.getPluginManager().callEvent(new SubAddProxyEvent(proxy)); Logger.get("SubData").info(client.getAddress().toString() + " has been defined as Proxy: " + proxy.getName() + ((channel > 0)?" [+"+channel+"]":"")); diff --git a/SubServers.Bungee/src/net/ME1312/SubServers/Bungee/Network/Packet/PacketLinkServer.java b/SubServers.Bungee/src/net/ME1312/SubServers/Bungee/Network/Packet/PacketLinkServer.java index 402d012f..628d3e07 100644 --- a/SubServers.Bungee/src/net/ME1312/SubServers/Bungee/Network/Packet/PacketLinkServer.java +++ b/SubServers.Bungee/src/net/ME1312/SubServers/Bungee/Network/Packet/PacketLinkServer.java @@ -90,7 +90,7 @@ public class PacketLinkServer implements InitialPacket, PacketObjectIn, Server server; Map servers = plugin.api.getServers(); - if (name != null && servers.keySet().contains(name.toLowerCase())) { + if (name != null && servers.containsKey(name.toLowerCase())) { link(client, servers.get(name.toLowerCase()), channel); } else if (address != null) { if ((server = search(address)) != null || (server = create(name, address)) != null) { @@ -139,7 +139,7 @@ public class PacketLinkServer implements InitialPacket, PacketObjectIn, static long last = Calendar.getInstance().getTime().getTime(); private void link(SubDataClient client, Server server, int channel) throws Throwable { HashMap subdata = Try.all.get(() -> Util.reflect(ServerImpl.class.getDeclaredField("subdata"), server)); - if (!subdata.keySet().contains(channel) || (channel == 0 && subdata.get(0) == null)) { + if (!subdata.containsKey(channel) || (channel == 0 && subdata.get(0) == null)) { server.setSubData(client, channel); Logger.get("SubData").info(client.getAddress().toString() + " has been defined as " + ((server instanceof SubServer) ? "SubServer" : "Server") + ": " + server.getName() + ((channel > 0)?" [+"+channel+"]":"")); Runnable register = () -> { diff --git a/SubServers.Bungee/src/net/ME1312/SubServers/Bungee/Network/Packet/PacketRemoveServer.java b/SubServers.Bungee/src/net/ME1312/SubServers/Bungee/Network/Packet/PacketRemoveServer.java index 075b653a..6e1716fa 100644 --- a/SubServers.Bungee/src/net/ME1312/SubServers/Bungee/Network/Packet/PacketRemoveServer.java +++ b/SubServers.Bungee/src/net/ME1312/SubServers/Bungee/Network/Packet/PacketRemoveServer.java @@ -59,7 +59,7 @@ public class PacketRemoveServer implements PacketObjectIn, PacketObject UUID player = (data.contains(0x0003)?data.getUUID(0x0003):null); Map servers = plugin.api.getServers(); - if (!servers.keySet().contains(name.toLowerCase())) { + if (!servers.containsKey(name.toLowerCase())) { client.sendPacket(new PacketRemoveServer(3, tracker)); } else if (!(servers.get(name.toLowerCase()) instanceof SubServer)) { if (force) { diff --git a/SubServers.Bungee/src/net/ME1312/SubServers/Bungee/Network/Packet/PacketRestartServer.java b/SubServers.Bungee/src/net/ME1312/SubServers/Bungee/Network/Packet/PacketRestartServer.java index c00bcb23..ce2b682c 100644 --- a/SubServers.Bungee/src/net/ME1312/SubServers/Bungee/Network/Packet/PacketRestartServer.java +++ b/SubServers.Bungee/src/net/ME1312/SubServers/Bungee/Network/Packet/PacketRestartServer.java @@ -58,7 +58,7 @@ public class PacketRestartServer implements PacketObjectIn, PacketObjec Runnable starter = () -> { Map servers = plugin.api.getServers(); - if (!servers.keySet().contains(name.toLowerCase())) { + if (!servers.containsKey(name.toLowerCase())) { } else if (!(servers.get(name.toLowerCase()) instanceof SubServer)) { } else if (!((SubServer) servers.get(name.toLowerCase())).getHost().isAvailable()) { } else if (!((SubServer) servers.get(name.toLowerCase())).getHost().isEnabled()) { @@ -72,7 +72,7 @@ public class PacketRestartServer implements PacketObjectIn, PacketObjec }; Map servers = plugin.api.getServers(); - if (!servers.keySet().contains(name.toLowerCase())) { + if (!servers.containsKey(name.toLowerCase())) { client.sendPacket(new PacketRestartServer(3, tracker)); } else if (!(servers.get(name.toLowerCase()) instanceof SubServer)) { client.sendPacket(new PacketRestartServer(4, tracker)); diff --git a/SubServers.Bungee/src/net/ME1312/SubServers/Bungee/Network/Packet/PacketStartServer.java b/SubServers.Bungee/src/net/ME1312/SubServers/Bungee/Network/Packet/PacketStartServer.java index fb7b4c56..48d171db 100644 --- a/SubServers.Bungee/src/net/ME1312/SubServers/Bungee/Network/Packet/PacketStartServer.java +++ b/SubServers.Bungee/src/net/ME1312/SubServers/Bungee/Network/Packet/PacketStartServer.java @@ -70,7 +70,7 @@ public class PacketStartServer implements PacketObjectIn, PacketObjectO UUID player = (data.contains(0x0002)?data.getUUID(0x0002):null); Map servers = plugin.api.getServers(); - if (!servers.keySet().contains(name.toLowerCase())) { + if (!servers.containsKey(name.toLowerCase())) { client.sendPacket(new PacketStartServer(3, tracker)); } else if (!(servers.get(name.toLowerCase()) instanceof SubServer)) { client.sendPacket(new PacketStartServer(4, tracker)); diff --git a/SubServers.Bungee/src/net/ME1312/SubServers/Bungee/Network/Packet/PacketStopServer.java b/SubServers.Bungee/src/net/ME1312/SubServers/Bungee/Network/Packet/PacketStopServer.java index bbcde62f..6bcd2e1f 100644 --- a/SubServers.Bungee/src/net/ME1312/SubServers/Bungee/Network/Packet/PacketStopServer.java +++ b/SubServers.Bungee/src/net/ME1312/SubServers/Bungee/Network/Packet/PacketStopServer.java @@ -58,7 +58,7 @@ public class PacketStopServer implements PacketObjectIn, PacketObjectOu UUID player = (data.contains(0x0003)?data.getUUID(0x0003):null); Map servers = plugin.api.getServers(); - if (!name.equals("*") && !servers.keySet().contains(name.toLowerCase())) { + if (!name.equals("*") && !servers.containsKey(name.toLowerCase())) { client.sendPacket(new PacketStopServer(3, tracker)); } else if (!name.equals("*") && !(servers.get(name.toLowerCase()) instanceof SubServer)) { client.sendPacket(new PacketStopServer(4, tracker)); diff --git a/SubServers.Bungee/src/net/ME1312/SubServers/Bungee/Network/Packet/PacketUpdateServer.java b/SubServers.Bungee/src/net/ME1312/SubServers/Bungee/Network/Packet/PacketUpdateServer.java index b700879f..1f262267 100644 --- a/SubServers.Bungee/src/net/ME1312/SubServers/Bungee/Network/Packet/PacketUpdateServer.java +++ b/SubServers.Bungee/src/net/ME1312/SubServers/Bungee/Network/Packet/PacketUpdateServer.java @@ -60,7 +60,7 @@ public class PacketUpdateServer implements PacketObjectIn, PacketObject boolean waitfor = (data.contains(0x0005)?data.getBoolean(0x0005):false); Map servers = plugin.api.getServers(); - if (!servers.keySet().contains(name.toLowerCase())) { + if (!servers.containsKey(name.toLowerCase())) { client.sendPacket(new PacketUpdateServer(3, tracker)); } else if (!(servers.get(name.toLowerCase()) instanceof SubServer)) { client.sendPacket(new PacketUpdateServer(4, tracker)); diff --git a/SubServers.Bungee/src/net/ME1312/SubServers/Bungee/SubAPI.java b/SubServers.Bungee/src/net/ME1312/SubServers/Bungee/SubAPI.java index cb7e9d8c..74cc464c 100644 --- a/SubServers.Bungee/src/net/ME1312/SubServers/Bungee/SubAPI.java +++ b/SubServers.Bungee/src/net/ME1312/SubServers/Bungee/SubAPI.java @@ -95,7 +95,7 @@ public final class SubAPI implements BungeeAPI { */ public void addHostDriver(Class driver, String handle) { Util.nullpo(driver, handle); - if (plugin.hostDrivers.keySet().contains(handle.toUpperCase().replace('-', '_').replace(' ', '_'))) throw new IllegalStateException("Driver already exists: " + handle); + if (plugin.hostDrivers.containsKey(handle.toUpperCase().replace('-', '_').replace(' ', '_'))) throw new IllegalStateException("Driver already exists: " + handle); plugin.hostDrivers.put(handle.toUpperCase().replace('-', '_').replace(' ', '_'), driver); } @@ -317,12 +317,12 @@ public final class SubAPI implements BungeeAPI { for (Server server : getServers().values()) { for (String name : server.getGroups()) { String group = name; - if (conflitresolver.keySet().contains(name.toLowerCase())) { + if (conflitresolver.containsKey(name.toLowerCase())) { group = conflitresolver.get(name.toLowerCase()); } else { conflitresolver.put(name.toLowerCase(), name); } - List list = (groups.keySet().contains(group))?groups.get(group):new LinkedList(); + List list = (groups.containsKey(group))?groups.get(group):new LinkedList(); list.add(server); groups.put(group, list); } @@ -435,7 +435,7 @@ public final class SubAPI implements BungeeAPI { * @return Success status */ public boolean addServer(UUID player, Server server) { - if (getServers().keySet().contains(server.getName().toLowerCase())) throw new InvalidServerException("A Server already exists with this name!"); + if (getServers().containsKey(server.getName().toLowerCase())) throw new InvalidServerException("A Server already exists with this name!"); SubAddServerEvent event = new SubAddServerEvent(player, null, server); plugin.getPluginManager().callEvent(event); if (!event.isCancelled()) { @@ -586,7 +586,7 @@ public final class SubAPI implements BungeeAPI { players.put(id, plugin.rPlayers.get(id)); return players; } else { - return new HashMap<>(); + return Collections.emptyMap(); } } diff --git a/SubServers.Bungee/src/net/ME1312/SubServers/Bungee/SubCommand.java b/SubServers.Bungee/src/net/ME1312/SubServers/Bungee/SubCommand.java index d98d4fa3..b4e6e767 100644 --- a/SubServers.Bungee/src/net/ME1312/SubServers/Bungee/SubCommand.java +++ b/SubServers.Bungee/src/net/ME1312/SubServers/Bungee/SubCommand.java @@ -438,7 +438,7 @@ public final class SubCommand extends Command implements TabExecutor { if (select.subservers.length > 0) { Consumer starter = server -> { Map servers = plugin.api.getServers(); - if (!servers.keySet().contains(server.getName().toLowerCase()) || !(servers.get(server.getName().toLowerCase()) instanceof SubServer)) { + if (!servers.containsKey(server.getName().toLowerCase()) || !(servers.get(server.getName().toLowerCase()) instanceof SubServer)) { sender.sendMessage("SubServers > Could not restart server: Subserver " + server.getName() + " has disappeared"); } else if (!(server = (SubServer) servers.get(server.getName().toLowerCase())).isRunning()) { if (!server.getHost().isAvailable()) { @@ -565,7 +565,7 @@ public final class SubCommand extends Command implements TabExecutor { if (plugin.canSudo) { if (args.length > 1) { Map servers = plugin.api.getServers(); - if (!servers.keySet().contains(args[1].toLowerCase()) || !(servers.get(args[1].toLowerCase()) instanceof SubServer)) { + if (!servers.containsKey(args[1].toLowerCase()) || !(servers.get(args[1].toLowerCase()) instanceof SubServer)) { sender.sendMessage("SubServers > There is no subserver with that name"); } else if (!((SubServer) servers.get(args[1].toLowerCase())).isRunning()) { sender.sendMessage("SubServers > That subserver is not running"); @@ -581,15 +581,15 @@ public final class SubCommand extends Command implements TabExecutor { } } else if (args[0].equalsIgnoreCase("create")) { if (args.length > 3) { - if (plugin.api.getSubServers().keySet().contains(args[1].toLowerCase()) || SubCreator.isReserved(args[1])) { + if (plugin.api.getSubServers().containsKey(args[1].toLowerCase()) || SubCreator.isReserved(args[1])) { sender.sendMessage("SubServers > There is already a subserver with that name"); - } else if (!plugin.hosts.keySet().contains(args[2].toLowerCase())) { + } else if (!plugin.hosts.containsKey(args[2].toLowerCase())) { sender.sendMessage("SubServers > There is no host with that name"); } else if (!plugin.hosts.get(args[2].toLowerCase()).isAvailable()) { sender.sendMessage("SubServers > That host is not available"); } else if (!plugin.hosts.get(args[2].toLowerCase()).isEnabled()) { sender.sendMessage("SubServers > That host is not enabled"); - } else if (!plugin.hosts.get(args[2].toLowerCase()).getCreator().getTemplates().keySet().contains(args[3].toLowerCase())) { + } else if (!plugin.hosts.get(args[2].toLowerCase()).getCreator().getTemplates().containsKey(args[3].toLowerCase())) { sender.sendMessage("SubServers > There is no template with that name"); } else if (!plugin.hosts.get(args[2].toLowerCase()).getCreator().getTemplate(args[3].toLowerCase()).isEnabled()) { sender.sendMessage("SubServers > That template is not enabled"); @@ -857,19 +857,19 @@ public final class SubCommand extends Command implements TabExecutor { String Last = (args.length > 0)?args[args.length - 1]:""; String last = Last.toLowerCase(); - if (sender instanceof ProxiedPlayer && (!players.keySet().contains(((ProxiedPlayer) sender).getUniqueId()) || !players.get(((ProxiedPlayer) sender).getUniqueId()).keySet().contains(((ProxiedPlayer) sender).getServer().getInfo()) + if (sender instanceof ProxiedPlayer && (!players.containsKey(((ProxiedPlayer) sender).getUniqueId()) || !players.get(((ProxiedPlayer) sender).getUniqueId()).containsKey(((ProxiedPlayer) sender).getServer().getInfo()) || !players.get(((ProxiedPlayer) sender).getUniqueId()).get(((ProxiedPlayer) sender).getServer().getInfo()).value())) { - if (players.keySet().contains(((ProxiedPlayer) sender).getUniqueId()) && players.get(((ProxiedPlayer) sender).getUniqueId()).keySet().contains(((ProxiedPlayer) sender).getServer().getInfo()) + if (players.containsKey(((ProxiedPlayer) sender).getUniqueId()) && players.get(((ProxiedPlayer) sender).getUniqueId()).containsKey(((ProxiedPlayer) sender).getServer().getInfo()) && players.get(((ProxiedPlayer) sender).getUniqueId()).get(((ProxiedPlayer) sender).getServer().getInfo()).key() == null) { // do nothing - } else if (!players.keySet().contains(((ProxiedPlayer) sender).getUniqueId()) || !players.get(((ProxiedPlayer) sender).getUniqueId()).keySet().contains(((ProxiedPlayer) sender).getServer().getInfo()) + } else if (!players.containsKey(((ProxiedPlayer) sender).getUniqueId()) || !players.get(((ProxiedPlayer) sender).getUniqueId()).containsKey(((ProxiedPlayer) sender).getServer().getInfo()) || Calendar.getInstance().getTime().getTime() - players.get(((ProxiedPlayer) sender).getUniqueId()).get(((ProxiedPlayer) sender).getServer().getInfo()).key() >= TimeUnit.MINUTES.toMillis(1)) { if (!(((ProxiedPlayer) sender).getServer().getInfo() instanceof Server) || ((Server) ((ProxiedPlayer) sender).getServer().getInfo()).getSubData()[0] == null) { - HashMap> map = (players.keySet().contains(((ProxiedPlayer) sender).getUniqueId()))?players.get(((ProxiedPlayer) sender).getUniqueId()):new HashMap>(); + HashMap> map = (players.containsKey(((ProxiedPlayer) sender).getUniqueId()))?players.get(((ProxiedPlayer) sender).getUniqueId()):new HashMap>(); map.put(((ProxiedPlayer) sender).getServer().getInfo(), new ContainedPair<>(Calendar.getInstance().getTime().getTime(), false)); players.put(((ProxiedPlayer) sender).getUniqueId(), map); } else { - HashMap> map = (players.keySet().contains(((ProxiedPlayer) sender).getUniqueId()))?players.get(((ProxiedPlayer) sender).getUniqueId()):new HashMap>(); + HashMap> map = (players.containsKey(((ProxiedPlayer) sender).getUniqueId()))?players.get(((ProxiedPlayer) sender).getUniqueId()):new HashMap>(); map.put(((ProxiedPlayer) sender).getServer().getInfo(), new ContainedPair<>(null, false)); players.put(((ProxiedPlayer) sender).getUniqueId(), map); ((SubDataClient) ((Server) ((ProxiedPlayer) sender).getServer().getInfo()).getSubData()[0]).sendPacket(new PacketCheckPermission(((ProxiedPlayer) sender).getUniqueId(), "subservers.command", result -> { @@ -1075,7 +1075,7 @@ public final class SubCommand extends Command implements TabExecutor { } else if (args.length == 4) { List list = new ArrayList(); Map hosts = plugin.api.getHosts(); - if (!hosts.keySet().contains(args[2].toLowerCase())) { + if (!hosts.containsKey(args[2].toLowerCase())) { list.add("