From 4f084fde6bf456bebec707c27d1aaf9a59fbdc52 Mon Sep 17 00:00:00 2001 From: Brianna Date: Sat, 26 Oct 2019 14:34:14 -0400 Subject: [PATCH 1/3] Add better syntax for kit command. --- src/main/java/com/songoda/ultimatekits/commands/CommandKit.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/main/java/com/songoda/ultimatekits/commands/CommandKit.java b/src/main/java/com/songoda/ultimatekits/commands/CommandKit.java index cc2f54d..db9b1c8 100644 --- a/src/main/java/com/songoda/ultimatekits/commands/CommandKit.java +++ b/src/main/java/com/songoda/ultimatekits/commands/CommandKit.java @@ -110,7 +110,7 @@ public class CommandKit extends AbstractCommand { @Override public String getSyntax() { - return "/Kit & /Kits"; + return "/Kit & /Kits | /kit [player]"; } @Override From 7561e216af7c1deb6887e23e48680eaf4419a995 Mon Sep 17 00:00:00 2001 From: Brianna Date: Sat, 26 Oct 2019 14:43:49 -0400 Subject: [PATCH 2/3] Allow players to use the /kit --- .../ultimatekits/commands/CommandKit.java | 23 ++++++++----------- 1 file changed, 10 insertions(+), 13 deletions(-) diff --git a/src/main/java/com/songoda/ultimatekits/commands/CommandKit.java b/src/main/java/com/songoda/ultimatekits/commands/CommandKit.java index db9b1c8..018478d 100644 --- a/src/main/java/com/songoda/ultimatekits/commands/CommandKit.java +++ b/src/main/java/com/songoda/ultimatekits/commands/CommandKit.java @@ -5,7 +5,6 @@ import com.songoda.core.gui.GuiManager; import com.songoda.ultimatekits.UltimateKits; import com.songoda.ultimatekits.gui.KitSelectorGui; import com.songoda.ultimatekits.kit.Kit; -import com.songoda.ultimatekits.utils.Methods; import org.bukkit.Bukkit; import org.bukkit.command.CommandSender; import org.bukkit.entity.Player; @@ -33,11 +32,6 @@ public class CommandKit extends AbstractCommand { return ReturnType.SUCCESS; } - if (!sender.hasPermission("ultimatekits.admin")) { - instance.getLocale().getMessage("command.general.noperms").sendPrefixedMessage(sender); - return ReturnType.FAILURE; - } - if (instance.getKitManager().getKit(args[0]) == null) { instance.getLocale().getMessage("command.kit.kitdoesntexist").sendPrefixedMessage(sender); return ReturnType.FAILURE; @@ -47,16 +41,19 @@ public class CommandKit extends AbstractCommand { if (args.length == 1) { // /kit - Gives kit to self. - if (!(sender instanceof Player)) { - instance.getLocale().newMessage("&cYou must be a player to use this command!").sendMessage(sender); - return ReturnType.FAILURE; - } + if (!(sender instanceof Player)) + return ReturnType.NEEDS_PLAYER; - kit.giveKit((Player) sender); + kit.processGenericUse((Player) sender, false); return ReturnType.SUCCESS; } else if (args.length == 2) { // /kit - Gives kit to another player. + if (!sender.hasPermission("ultimatekits.admin")) { + instance.getLocale().getMessage("command.general.noperms").sendPrefixedMessage(sender); + return ReturnType.FAILURE; + } + if (!args[1].equalsIgnoreCase("all") && Bukkit.getPlayer(args[1]) == null) { instance.getLocale().newMessage("&cThat username does not exist, or the user is offline!").sendPrefixedMessage(sender); return ReturnType.FAILURE; @@ -66,13 +63,13 @@ public class CommandKit extends AbstractCommand { String who = player != null ? player.getName() : "everyone"; if (player != null) { - kit.giveKit(player); + kit.processGenericUse(player, true); instance.getLocale().getMessage("event.claim.givesuccess") .processPlaceholder("kit", kit.getShowableName()) .sendPrefixedMessage(sender); } else { Bukkit.getOnlinePlayers().forEach(onlinePlayer -> { - kit.giveKit(onlinePlayer); + kit.processGenericUse(onlinePlayer, true); instance.getLocale().getMessage("event.claim.givesuccess") .processPlaceholder("kit", kit.getShowableName()) .sendPrefixedMessage(sender); From c6a5fc3abb54420de2b946b53b4189f5e26806a2 Mon Sep 17 00:00:00 2001 From: Brianna Date: Sat, 26 Oct 2019 14:44:33 -0400 Subject: [PATCH 3/3] version 2.4.6 --- .gitlab-ci.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml index 28e8074..ee3d5d3 100644 --- a/.gitlab-ci.yml +++ b/.gitlab-ci.yml @@ -4,7 +4,7 @@ stages: variables: name: "UltimateKits" path: "/builds/$CI_PROJECT_PATH" - version: "2.4.5" + version: "2.4.6" build: stage: build