Upstream/VaultAPI
1
0
Fork 0
mirror of https://github.com/MilkBowl/VaultAPI.git synced 2024-11-15 15:05:14 +01:00
Code Issues Projects Releases Wiki Activity

Compare commits

base: Upstream:1.7.1
Branches Tags
Upstream:master
Upstream:gh-pages
Upstream:1.7.1
Upstream:1.7
...
compare: Upstream:master
Branches Tags
Upstream:master
Upstream:gh-pages
Upstream:1.7.1
Upstream:1.7

2 Commits
1.7.1 ... master

Author SHA1 Message Date
Parker Hawke
8bad2c479f Use plugin logger instead of Minecraft logger in README example 
The JavaPlugin class provides plugins with their own logger via getLogger() which is the preferred means of logging content to the console as it prepends the plugin's name. Using a Logger with the Minecraft prefix is non-descript and poor practice because it will not properly source from where the log message is coming. Beginners should not be given this poor practice as an example.
 2023-08-16 08:57:52 -07:00
Parker Hawke
9520d8847e Simplify EconomyResponse#transactionSuccess() 2022-06-27 11:41:44 -07:00
2 changed files with 5 additions and 13 deletions
Show Stats Expand all files Collapse all files

9
README.md
View File

@ -67,8 +67,6 @@ Implementing Vault is quite simple. It requires getting the Economy, Permission,
```java ```java
package com.example.plugin; package com.example.plugin;
import java.util.logging.Logger;
import net.milkbowl.vault.chat.Chat; import net.milkbowl.vault.chat.Chat;
import net.milkbowl.vault.economy.Economy; import net.milkbowl.vault.economy.Economy;
import net.milkbowl.vault.economy.EconomyResponse; import net.milkbowl.vault.economy.EconomyResponse;
@ -82,20 +80,19 @@ import org.bukkit.plugin.java.JavaPlugin;
public class ExamplePlugin extends JavaPlugin { public class ExamplePlugin extends JavaPlugin {
private static final Logger log = Logger.getLogger("Minecraft");
private static Economy econ = null; private static Economy econ = null;
private static Permission perms = null; private static Permission perms = null;
private static Chat chat = null; private static Chat chat = null;
@Override @Override
public void onDisable() { public void onDisable() {
log.info(String.format("[%s] Disabled Version %s", getDescription().getName(), getDescription().getVersion())); getLogger().info(String.format("[%s] Disabled Version %s", getDescription().getName(), getDescription().getVersion()));
} }
@Override @Override
public void onEnable() { public void onEnable() {
if (!setupEconomy() ) { if (!setupEconomy() ) {
log.severe(String.format("[%s] - Disabled due to no Vault dependency found!", getDescription().getName())); getLogger().severe(String.format("[%s] - Disabled due to no Vault dependency found!", getDescription().getName()));
getServer().getPluginManager().disablePlugin(this); getServer().getPluginManager().disablePlugin(this);
return; return;
} }
@ -129,7 +126,7 @@ public class ExamplePlugin extends JavaPlugin {
public boolean onCommand(CommandSender sender, Command command, String commandLabel, String[] args) { public boolean onCommand(CommandSender sender, Command command, String commandLabel, String[] args) {
if(!(sender instanceof Player)) { if(!(sender instanceof Player)) {
log.info("Only players are supported for this Example Plugin, but you should not do this!!!"); getLogger().info("Only players are supported for this Example Plugin, but you should not do this!!!");
return true; return true;
} }

7
src/main/java/net/milkbowl/vault/economy/EconomyResponse.java
View File

@ -79,11 +79,6 @@ public class EconomyResponse {
* @return Value * @return Value
*/ */
public boolean transactionSuccess() { public boolean transactionSuccess() {
switch (type) { return type == ResponseType.SUCCESS;
case SUCCESS:
return true;
default:
return false;
}
} }
} }