From 3896a12166f29453345860b3abb8a5a38022721c Mon Sep 17 00:00:00 2001 From: Nassim Jahnke Date: Sun, 15 Dec 2024 10:05:53 +0100 Subject: [PATCH] [ci skip] Update some text and comments --- .github/ISSUE_TEMPLATE/bug_report.yml | 7 ++++--- .../v1_13to1_12_2/rewriter/PlayerPacketRewriter1_13.java | 8 +++++--- 2 files changed, 9 insertions(+), 6 deletions(-) diff --git a/.github/ISSUE_TEMPLATE/bug_report.yml b/.github/ISSUE_TEMPLATE/bug_report.yml index fbd63578..db73b86b 100644 --- a/.github/ISSUE_TEMPLATE/bug_report.yml +++ b/.github/ISSUE_TEMPLATE/bug_report.yml @@ -19,10 +19,11 @@ body: - type: textarea attributes: - label: Console Error + label: Server/Client Error description: | If you encounter warnings/errors in your console, **paste them with https://mclo.gs/ and put the paste link here**. If the error is small/less than 10 lines, you may put it directly into this field. + **Important**: If you are kicked for `Network Protocol Error` or an encoder/decoder exception, please click the `Open Report Directory` button on your client and paste the newest disconnect file contents. value: | ``` Put the mclo.gs link or text here. @@ -38,7 +39,7 @@ body: Describe the unexpected behavior. If you want to attach screenshots, use the comment field at the bottom of the page. placeholder: | - Example: "Placing signs on 1.13.2 causes text to disappear." + Example: "Placing signs on 1.16.5 causes text to disappear." validations: required: true @@ -49,7 +50,7 @@ body: List the steps on how we can reproduce the issue. Make sure we can easily understand what you mean with each step. placeholder: | Example: - 1. Login with a 1.13.2 client + 1. Login with a 1.16.5 client 2. Place a sign 3. The sign text is displayed wrong validations: diff --git a/common/src/main/java/com/viaversion/viabackwards/protocol/v1_13to1_12_2/rewriter/PlayerPacketRewriter1_13.java b/common/src/main/java/com/viaversion/viabackwards/protocol/v1_13to1_12_2/rewriter/PlayerPacketRewriter1_13.java index 602a29b8..3b5bb5ca 100644 --- a/common/src/main/java/com/viaversion/viabackwards/protocol/v1_13to1_12_2/rewriter/PlayerPacketRewriter1_13.java +++ b/common/src/main/java/com/viaversion/viabackwards/protocol/v1_13to1_12_2/rewriter/PlayerPacketRewriter1_13.java @@ -367,12 +367,14 @@ public class PlayerPacketRewriter1_13 extends RewriterBase case "MC|AdvCmd" -> { byte type = wrapper.read(Types.BYTE); if (type == 0) { - //Information from https://wiki.vg/index.php?title=Plugin_channels&oldid=14089 - //The Notchain client only uses this for command block minecarts and uses MC|AutoCmd for blocks, but the Notchian server still accepts it for either. + //Information from https://wiki.vg/index.php?title=Plugin_channels&oldid=14089 (see web archive) + //The Vanilla client only uses this for command block minecarts and uses MC|AutoCmd for blocks, but the server still accepts it for either. //Maybe older versions used this and we need to implement this? The issue is that we would have to save the command block types wrapper.setPacketType(ServerboundPackets1_13.SET_COMMAND_BLOCK); wrapper.cancel(); - protocol.getLogger().warning("Client send MC|AdvCmd custom payload to update command block, weird!"); + if (!Via.getConfig().isSuppressConversionWarnings()) { + protocol.getLogger().warning("Client send MC|AdvCmd custom payload to update command block, weird!"); + } } else if (type == 1) { wrapper.setPacketType(ServerboundPackets1_13.SET_COMMAND_MINECART); wrapper.write(Types.VAR_INT, wrapper.read(Types.INT)); //Entity Id