Move auto detect to the version list screen

src/main/java/de/florianmichael/viafabricplus/ViaFabricPlus.java

@@ -22,6 +22,7 @@ package de.florianmichael.viafabricplus;
 import de.florianmichael.viafabricplus.event.PostGameLoadCallback;
 import de.florianmichael.viafabricplus.fixes.ClientsideFixes;
 import de.florianmichael.viafabricplus.protocolhack.ProtocolHack;
+import de.florianmichael.viafabricplus.protocolhack.util.VersionEnumExtension;
 import de.florianmichael.viafabricplus.save.SaveManager;
 import de.florianmichael.viafabricplus.settings.SettingsManager;
 import de.florianmichael.viafabricplus.util.ClassLoaderPriorityUtil;
@@ -62,6 +63,7 @@ public class ViaFabricPlus {
     public void bootstrap() {
         directory.mkdir();
         ClassLoaderPriorityUtil.loadOverridingJars(directory); // Load overriding jars first so other code can access the new classes
+        VersionEnumExtension.init(); // Register extra VersionEnum values
 
         settingsManager = new SettingsManager();
         saveManager = new SaveManager(settingsManager);

src/main/java/de/florianmichael/viafabricplus/injection/mixin/base/connect/MixinClientConnection.java

@@ -26,6 +26,7 @@ import de.florianmichael.viafabricplus.injection.access.IClientConnection;
 import de.florianmichael.viafabricplus.injection.access.IPerformanceLog;
 import de.florianmichael.viafabricplus.protocolhack.ProtocolHack;
 import de.florianmichael.viafabricplus.protocolhack.netty.ViaFabricPlusVLLegacyPipeline;
+import de.florianmichael.viafabricplus.protocolhack.util.VersionEnumExtension;
 import io.netty.bootstrap.AbstractBootstrap;
 import io.netty.bootstrap.Bootstrap;
 import io.netty.channel.*;
@@ -127,17 +128,23 @@ public abstract class MixinClientConnection extends SimpleChannelInboundHandler<
 
     @Inject(method = "connect(Ljava/net/InetSocketAddress;ZLnet/minecraft/network/ClientConnection;)Lio/netty/channel/ChannelFuture;", at = @At("HEAD"))
     private static void setTargetVersion(InetSocketAddress address, boolean useEpoll, ClientConnection connection, CallbackInfoReturnable<ChannelFuture> cir) {
-        if (((IClientConnection) connection).viaFabricPlus$getTargetVersion() == null) {
-            ((IClientConnection) connection).viaFabricPlus$setTargetVersion(ProtocolHack.getTargetVersion());
+        VersionEnum targetVersion = ((IClientConnection) connection).viaFabricPlus$getTargetVersion();
+        if (targetVersion == null) { // No server specific override
+            targetVersion = ProtocolHack.getTargetVersion();
         }
+        if (targetVersion == VersionEnumExtension.AUTO_DETECT) { // Auto-detect enabled (when pinging always use native version). Auto-detect is resolved in ConnectScreen mixin
+            targetVersion = ProtocolHack.NATIVE_VERSION;
+        }
+
+        ((IClientConnection) connection).viaFabricPlus$setTargetVersion(targetVersion);
     }
 
     @Redirect(method = "connect(Ljava/net/InetSocketAddress;ZLnet/minecraft/network/ClientConnection;)Lio/netty/channel/ChannelFuture;", at = @At(value = "INVOKE", target = "Lio/netty/bootstrap/Bootstrap;channel(Ljava/lang/Class;)Lio/netty/bootstrap/AbstractBootstrap;", remap = false))
     private static AbstractBootstrap<?, ?> useRakNetChannelFactory(Bootstrap instance, Class<? extends Channel> channelTypeClass, @Local(argsOnly = true) ClientConnection clientConnection) {
         if (VersionEnum.bedrockLatest.equals(((IClientConnection) clientConnection).viaFabricPlus$getTargetVersion())) {
             return instance.channelFactory(channelTypeClass == EpollSocketChannel.class ?
-                            RakChannelFactory.client(EpollDatagramChannel.class) :
-                            RakChannelFactory.client(NioDatagramChannel.class)
+                    RakChannelFactory.client(EpollDatagramChannel.class) :
+                    RakChannelFactory.client(NioDatagramChannel.class)
             );
         }
 

src/main/java/de/florianmichael/viafabricplus/injection/mixin/base/integration/MixinConnectScreen_1.java

@@ -19,14 +19,13 @@
 
 package de.florianmichael.viafabricplus.injection.mixin.base.integration;
 
-import com.viaversion.viaversion.api.protocol.version.ProtocolVersion;
 import de.florianmichael.viafabricplus.ViaFabricPlus;
 import de.florianmichael.viafabricplus.injection.access.IServerInfo;
 import de.florianmichael.viafabricplus.protocolhack.ProtocolHack;
 import de.florianmichael.viafabricplus.protocolhack.provider.vialegacy.ViaFabricPlusClassicMPPassProvider;
+import de.florianmichael.viafabricplus.protocolhack.util.ProtocolVersionDetector;
+import de.florianmichael.viafabricplus.protocolhack.util.VersionEnumExtension;
 import de.florianmichael.viafabricplus.settings.impl.AuthenticationSettings;
-import de.florianmichael.viafabricplus.settings.impl.GeneralSettings;
-import net.lenni0451.mcping.MCPing;
 import net.minecraft.client.gui.screen.ConnectScreen;
 import net.minecraft.client.network.ServerInfo;
 import net.minecraft.client.session.Session;
@@ -70,26 +69,18 @@ public abstract class MixinConnectScreen_1 {
     @Inject(method = "run", at = @At(value = "INVOKE", target = "Lnet/minecraft/network/ClientConnection;connect(Ljava/net/InetSocketAddress;ZLnet/minecraft/network/ClientConnection;)Lio/netty/channel/ChannelFuture;", shift = At.Shift.BEFORE), locals = LocalCapture.CAPTURE_FAILHARD)
     private void setServerInfo(CallbackInfo ci, InetSocketAddress inetSocketAddress) {
         final IServerInfo mixinServerInfo = (IServerInfo) this.field_40415;
-        final VersionEnum targetVersion = mixinServerInfo.viaFabricPlus$forcedVersion();
+        VersionEnum targetVersion = ProtocolHack.getTargetVersion();
 
-        if (targetVersion != null && !mixinServerInfo.viaFabricPlus$passedDirectConnectScreen()) {
-            ProtocolHack.setTargetVersion(targetVersion);
-        } else if (GeneralSettings.global().autoDetectVersion.getValue()) {
-            this.field_2416.setStatus(Text.translatable("base.viafabricplus.detecting_server_version"));
-            MCPing
-                    .pingModern(-1)
-                    .address(inetSocketAddress.getHostString(), inetSocketAddress.getPort())
-                    .noResolve()
-                    .timeout(1000, 1000)
-                    .exceptionHandler(t -> {
-                    })
-                    .responseHandler(r -> {
-                        if (ProtocolVersion.isRegistered(r.version.protocol)) {
-                            ProtocolHack.setTargetVersion(VersionEnum.fromProtocolId(r.version.protocol));
-                        }
-                    })
-                    .getSync();
+        if (mixinServerInfo.viaFabricPlus$forcedVersion() != null && !mixinServerInfo.viaFabricPlus$passedDirectConnectScreen()) {
+            targetVersion = mixinServerInfo.viaFabricPlus$forcedVersion();
         }
+
+        if (targetVersion == VersionEnumExtension.AUTO_DETECT) {
+            this.field_2416.setStatus(Text.translatable("base.viafabricplus.detecting_server_version"));
+            targetVersion = ProtocolVersionDetector.get(inetSocketAddress, ProtocolHack.NATIVE_VERSION);
+        }
+
+        ProtocolHack.setTargetVersion(targetVersion, true);
     }
 
 }

src/main/java/de/florianmichael/viafabricplus/injection/mixin/base/integration/MixinDebugHud.java

@@ -63,10 +63,13 @@ public abstract class MixinDebugHud {
         if (!GeneralSettings.global().showExtraInformationInDebugHud.getValue()) {
             return;
         }
-        if (MinecraftClient.getInstance().isInSingleplayer() || ProtocolHack.getTargetVersion() == ProtocolHack.NATIVE_VERSION) {
+        if (MinecraftClient.getInstance().isInSingleplayer() && MinecraftClient.getInstance().player != null) {
             return;
         }
         final UserConnection userConnection = ProtocolHack.getPlayNetworkUserConnection();
+        if (userConnection == null) { // Via is not translating this session
+            return;
+        }
 
         final List<String> information = new ArrayList<>();
         information.add("");

src/main/java/de/florianmichael/viafabricplus/injection/mixin/base/integration/MixinMultiplayerServerListPinger_1.java

@@ -19,10 +19,8 @@
 
 package de.florianmichael.viafabricplus.injection.mixin.base.integration;
 
-import com.viaversion.viaversion.api.connection.UserConnection;
 import de.florianmichael.viafabricplus.injection.access.IClientConnection;
 import de.florianmichael.viafabricplus.injection.access.IServerInfo;
-import de.florianmichael.viafabricplus.protocolhack.ProtocolHack;
 import net.minecraft.SharedConstants;
 import net.minecraft.client.network.ServerInfo;
 import net.minecraft.network.ClientConnection;
@@ -74,7 +72,7 @@ public abstract class MixinMultiplayerServerListPinger_1 implements ClientQueryP
             // version to the client so its detection doesn't break when checking for serverVersion == clientVersion, but since
             // ViaLegacy doesn't do that, we have to do it ourselves
             isCompatible = LegacyProtocolVersion.getRealProtocolVersion(version.getVersion()) == this.field_3776.protocolVersion;
-        } else if (ProtocolHack.getTargetVersion().equals(VersionEnum.bedrockLatest)) {
+        } else if (version.equals(VersionEnum.bedrockLatest)) {
             // Bedrock edition doesn't have a protocol id like the Java edition, ViaBedrock also has its own protocol id offset
             // Which we need to remove to get the real protocol id
             isCompatible = version.getVersion() - BedrockProtocolVersion.PROTOCOL_ID_OVERLAP_PREVENTION_OFFSET == this.field_3776.protocolVersion;

src/main/java/de/florianmichael/viafabricplus/protocolhack/ProtocolHack.java

@@ -31,6 +31,7 @@ import com.viaversion.viaversion.api.protocol.packet.State;
 import com.viaversion.viaversion.connection.UserConnectionImpl;
 import com.viaversion.viaversion.protocol.ProtocolPipelineImpl;
 import de.florianmichael.viafabricplus.event.ChangeProtocolVersionCallback;
+import de.florianmichael.viafabricplus.event.DisconnectCallback;
 import de.florianmichael.viafabricplus.event.PostViaVersionLoadCallback;
 import de.florianmichael.viafabricplus.injection.access.IClientConnection;
 import de.florianmichael.viafabricplus.protocolhack.command.ViaFabricPlusVLCommandHandler;
@@ -88,6 +89,11 @@ public class ProtocolHack {
      */
     private static VersionEnum targetVersion = NATIVE_VERSION;
 
+    /**
+     * This field stores the previous selected version if {@link #setTargetVersion(VersionEnum, boolean)} is called with revertOnDisconnect set to true
+     */
+    private static VersionEnum previousVersion = null;
+
     /**
      * Injects the ViaFabricPlus pipeline with all ViaVersion elements into a Minecraft pipeline
      *
@@ -130,12 +136,25 @@ public class ProtocolHack {
      *
      * @param newVersion the target version
      */
-    public static void setTargetVersion(VersionEnum newVersion) {
+    public static void setTargetVersion(final VersionEnum newVersion) {
+        setTargetVersion(newVersion, false);
+    }
+
+    /**
+     * Sets the target version
+     *
+     * @param newVersion         the target version
+     * @param revertOnDisconnect if true, the previous version will be set when the player disconnects from the server
+     */
+    public static void setTargetVersion(final VersionEnum newVersion, final boolean revertOnDisconnect) {
         if (newVersion == null) return;
 
         final VersionEnum oldVersion = targetVersion;
         targetVersion = newVersion;
         if (oldVersion != newVersion) {
+            if (revertOnDisconnect) {
+                previousVersion = oldVersion;
+            }
             ChangeProtocolVersionCallback.EVENT.invoker().onChangeProtocolVersion(oldVersion, targetVersion);
         }
     }
@@ -209,6 +228,13 @@ public class ProtocolHack {
      * @return A CompletableFuture that will be completed when the initialization is done
      */
     public static CompletableFuture<Void> init(final File directory) {
+        DisconnectCallback.EVENT.register(() -> {
+            if (previousVersion != null) { // Revert the version if the player disconnects and a previous version is set
+                setTargetVersion(previousVersion);
+                previousVersion = null;
+            }
+        });
+
         patchConfigs(directory);
 
         // Register command callback for /viaversion and /viafabricplus

src/main/java/de/florianmichael/viafabricplus/protocolhack/util/ProtocolVersionDetector.java

@@ -0,0 +1,58 @@
+/*
+ * This file is part of ViaFabricPlus - https://github.com/FlorianMichael/ViaFabricPlus
+ * Copyright (C) 2021-2023 FlorianMichael/EnZaXD
+ * Copyright (C) 2023      RK_01/RaphiMC and contributors
+ *
+ * This program is free software: you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation, either version 3 of the License, or
+ * (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program.  If not, see <http://www.gnu.org/licenses/>.
+ */
+package de.florianmichael.viafabricplus.protocolhack.util;
+
+import com.viaversion.viaversion.api.protocol.version.ProtocolVersion;
+import net.lenni0451.mcping.MCPing;
+import net.lenni0451.mcping.responses.MCPingResponse;
+import net.raphimc.vialoader.util.VersionEnum;
+
+import java.net.InetSocketAddress;
+
+public class ProtocolVersionDetector {
+
+    private static final int TIMEOUT = 3000;
+
+    public static VersionEnum get(final InetSocketAddress serverAddress, final VersionEnum clientVersion) {
+        MCPingResponse response = MCPing
+                .pingModern(clientVersion.getOriginalVersion())
+                .address(serverAddress)
+                .noResolve()
+                .timeout(TIMEOUT, TIMEOUT)
+                .getSync();
+
+        if (response.version.protocol == clientVersion.getOriginalVersion()) { // If the server is on the same version as the client, we can just connect
+            return clientVersion;
+        } else { // Else ping again with protocol id -1 to get the protocol id of the server
+            response = MCPing
+                    .pingModern(-1)
+                    .address(serverAddress)
+                    .noResolve()
+                    .timeout(TIMEOUT, TIMEOUT)
+                    .getSync();
+
+            if (ProtocolVersion.isRegistered(response.version.protocol)) { // If the protocol is registered, we can use it
+                return VersionEnum.fromProtocolId(response.version.protocol);
+            } else {
+                throw new RuntimeException("Unsupported protocol version: " + response.version.protocol);
+            }
+        }
+    }
+
+}

src/main/java/de/florianmichael/viafabricplus/protocolhack/util/VersionEnumExtension.java

@@ -0,0 +1,43 @@
+/*
+ * This file is part of ViaFabricPlus - https://github.com/FlorianMichael/ViaFabricPlus
+ * Copyright (C) 2021-2023 FlorianMichael/EnZaXD
+ * Copyright (C) 2023      RK_01/RaphiMC and contributors
+ *
+ * This program is free software: you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation, either version 3 of the License, or
+ * (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program.  If not, see <http://www.gnu.org/licenses/>.
+ */
+package de.florianmichael.viafabricplus.protocolhack.util;
+
+import com.viaversion.viaversion.api.protocol.version.ProtocolVersion;
+import net.lenni0451.reflect.Enums;
+import net.lenni0451.reflect.stream.RStream;
+import net.raphimc.vialoader.util.VersionEnum;
+
+import java.util.Map;
+
+public class VersionEnumExtension {
+
+    private static final ProtocolVersion autoDetect = ProtocolVersion.register(-2, "Auto Detect (1.7+ servers)");
+    public static final VersionEnum AUTO_DETECT = Enums.newInstance(VersionEnum.class, "AUTO_DETECT", VersionEnum.UNKNOWN.ordinal(), new Class<?>[]{ProtocolVersion.class}, new Object[]{autoDetect});
+
+    static {
+        Enums.addEnumInstance(VersionEnum.class, AUTO_DETECT);
+        RStream.of(VersionEnum.class).fields().by("VERSION_REGISTRY").<Map<ProtocolVersion, VersionEnum>>get().put(autoDetect, AUTO_DETECT);
+        VersionEnum.SORTED_VERSIONS.add(AUTO_DETECT);
+    }
+
+    public static void init() {
+        // calls static initializer
+    }
+
+}

src/main/java/de/florianmichael/viafabricplus/settings/impl/GeneralSettings.java

@@ -19,9 +19,9 @@
 
 package de.florianmichael.viafabricplus.settings.impl;
 
-import de.florianmichael.viafabricplus.settings.base.SettingGroup;
 import de.florianmichael.viafabricplus.settings.base.BooleanSetting;
 import de.florianmichael.viafabricplus.settings.base.ModeSetting;
+import de.florianmichael.viafabricplus.settings.base.SettingGroup;
 import net.minecraft.client.gui.widget.ButtonWidget;
 import net.minecraft.text.Text;
 
@@ -48,7 +48,6 @@ public class GeneralSettings extends SettingGroup {
     public final BooleanSetting saveSelectedProtocolVersion = new BooleanSetting(this, Text.translatable("general_settings.viafabricplus.save_selected_protocol_version"), true);
     public final BooleanSetting showExtraInformationInDebugHud = new BooleanSetting(this, Text.translatable("general_settings.viafabricplus.extra_information_in_debug_hud"), true);
     public final BooleanSetting showClassicLoadingProgressInConnectScreen = new BooleanSetting(this, Text.translatable("general_settings.viafabricplus.show_classic_loading_progress"), true);
-    public final BooleanSetting autoDetectVersion = new BooleanSetting(this, Text.translatable("general_settings.viafabricplus.auto_detect_version"), false);
     public final BooleanSetting showAdvertisedServerVersion = new BooleanSetting(this, Text.translatable("general_settings.viafabricplus.show_advertised_server_version"), true);
     public final ModeSetting ignorePacketTranslationErrors = new ModeSetting(this, Text.translatable("general_settings.viafabricplus.ignore_packet_translation_errors"),
             Text.translatable("base.viafabricplus.kick"),

src/main/resources/assets/viafabricplus/lang/en_us.json

@@ -39,7 +39,6 @@
   "general_settings.viafabricplus.multiplayer_screen_button_orientation": "Multiplayer screen button orientation",
   "general_settings.viafabricplus.add_server_screen_button_orientation": "Add server screen button orientation",
   "general_settings.viafabricplus.filter_creative_tabs": "Remove not available items from creative tab",
-  "general_settings.viafabricplus.auto_detect_version": "Auto detect version",
   "general_settings.viafabricplus.show_advertised_server_version": "Show advertised/server version in Multiplayer",
   "general_settings.viafabricplus.ignore_packet_translation_errors": "Ignore packet translation errors",
   "general_settings.viafabricplus.load_skins_and_skulls_in_legacy_versions": "Load skins and skulls in legacy versions",

src/main/resources/assets/viafabricplus/lang/es_ar.json

@@ -37,7 +37,6 @@
   "general_settings.viafabricplus.multiplayer_screen_button_orientation": "Orientación de los botones de la pantalla multijugador",
   "general_settings.viafabricplus.add_server_screen_button_orientation": "Orientación del boton Añadir servidor",
   "general_settings.viafabricplus.filter_creative_tabs": "eliminar items no disponibles de la pestaña del creativo",
-  "general_settings.viafabricplus.auto_detect_version": "Auto detectar versión",
   "general_settings.viafabricplus.show_advertised_server_version": "Mostrar version anunciada del servidor in multijugador",
   "general_settings.viafabricplus.ignore_packet_translation_errors": "Ignorar error de traducciones de paquete",
 

src/main/resources/assets/viafabricplus/lang/es_cl.json

@@ -37,7 +37,6 @@
   "general_settings.viafabricplus.multiplayer_screen_button_orientation": "Orientación de los botones de la pantalla multijugador",
   "general_settings.viafabricplus.add_server_screen_button_orientation": "Orientación del boton Añadir servidor",
   "general_settings.viafabricplus.filter_creative_tabs": "eliminar items no disponibles de la pestaña del creativo",
-  "general_settings.viafabricplus.auto_detect_version": "Auto detectar versión",
   "general_settings.viafabricplus.show_advertised_server_version": "Mostrar version anunciada del servidor in multijugador",
   "general_settings.viafabricplus.ignore_packet_translation_errors": "Ignorar error de traducciones de paquete",
 

src/main/resources/assets/viafabricplus/lang/es_ec.json

@@ -37,7 +37,6 @@
   "general_settings.viafabricplus.multiplayer_screen_button_orientation": "Orientación de los botones de la pantalla multijugador",
   "general_settings.viafabricplus.add_server_screen_button_orientation": "Orientación del boton Añadir servidor",
   "general_settings.viafabricplus.filter_creative_tabs": "eliminar items no disponibles de la pestaña del creativo",
-  "general_settings.viafabricplus.auto_detect_version": "Auto detectar versión",
   "general_settings.viafabricplus.show_advertised_server_version": "Mostrar version anunciada del servidor in multijugador",
   "general_settings.viafabricplus.ignore_packet_translation_errors": "Ignorar error de traducciones de paquete",
 

src/main/resources/assets/viafabricplus/lang/es_es.json

@@ -37,7 +37,6 @@
   "general_settings.viafabricplus.multiplayer_screen_button_orientation": "Orientación de los botones de la pantalla multijugador",
   "general_settings.viafabricplus.add_server_screen_button_orientation": "Orientación del boton Añadir servidor",
   "general_settings.viafabricplus.filter_creative_tabs": "eliminar items no disponibles de la pestaña del creativo",
-  "general_settings.viafabricplus.auto_detect_version": "Auto detectar versión",
   "general_settings.viafabricplus.show_advertised_server_version": "Mostrar version anunciada del servidor in multijugador",
   "general_settings.viafabricplus.ignore_packet_translation_errors": "Ignorar error de traducciones de paquete",
 

src/main/resources/assets/viafabricplus/lang/es_mx.json

@@ -37,7 +37,6 @@
   "general_settings.viafabricplus.multiplayer_screen_button_orientation": "Orientación de los botones de la pantalla multijugador",
   "general_settings.viafabricplus.add_server_screen_button_orientation": "Orientación del boton Añadir servidor",
   "general_settings.viafabricplus.filter_creative_tabs": "eliminar items no disponibles de la pestaña del creativo",
-  "general_settings.viafabricplus.auto_detect_version": "Auto detectar versión",
   "general_settings.viafabricplus.show_advertised_server_version": "Mostrar version anunciada del servidor in multijugador",
   "general_settings.viafabricplus.ignore_packet_translation_errors": "Ignorar error de traducciones de paquete",
 

src/main/resources/assets/viafabricplus/lang/es_uy.json

@@ -37,7 +37,6 @@
   "general_settings.viafabricplus.multiplayer_screen_button_orientation": "Orientación de los botones de la pantalla multijugador",
   "general_settings.viafabricplus.add_server_screen_button_orientation": "Orientación del boton Añadir servidor",
   "general_settings.viafabricplus.filter_creative_tabs": "eliminar items no disponibles de la pestaña del creativo",
-  "general_settings.viafabricplus.auto_detect_version": "Auto detectar versión",
   "general_settings.viafabricplus.show_advertised_server_version": "Mostrar version anunciada del servidor in multijugador",
   "general_settings.viafabricplus.ignore_packet_translation_errors": "Ignorar error de traducciones de paquete",
 

src/main/resources/assets/viafabricplus/lang/es_ve.json

@@ -37,7 +37,6 @@
   "general_settings.viafabricplus.multiplayer_screen_button_orientation": "Orientación de los botones de la pantalla multijugador",
   "general_settings.viafabricplus.add_server_screen_button_orientation": "Orientación del boton Añadir servidor",
   "general_settings.viafabricplus.filter_creative_tabs": "eliminar items no disponibles de la pestaña del creativo",
-  "general_settings.viafabricplus.auto_detect_version": "Auto detectar versión",
   "general_settings.viafabricplus.show_advertised_server_version": "Mostrar version anunciada del servidor in multijugador",
   "general_settings.viafabricplus.ignore_packet_translation_errors": "Ignorar error de traducciones de paquete",
 

src/main/resources/assets/viafabricplus/lang/fi_fi.json

@@ -20,7 +20,6 @@
   "general_settings.viafabricplus.main": "Pää-napin suunta",
   "general_settings.viafabricplus.filter_creative_tabs": "Poista saavuttamattomat esineet Luova-välilehdestä",
   "general_settings.viafabricplus.protocolsync": "Automaattisesti vaihda asetuksia version mukaan",
-  "general_settings.viafabricplus.auto_detect_version": "Havaitse versio automaattisesti",
 
   "experimental.viafabricplus.chunkborderfix": "Korjaa chunk-rajat",
   "experimental.viafabricplus.watermovement": "Vesi-liikkeen reunan havaitseminen",

src/main/resources/assets/viafabricplus/lang/fr_fr.json

@@ -19,7 +19,6 @@
   "general_settings.viafabricplus.main": "Orientation du bouton principal",
   "general_settings.viafabricplus.filter_creative_tabs": "Supprimer les éléments non disponibles de l'inventaire créatif",
   "general_settings.viafabricplus.protocolsync": "Modifier automatiquement les paramètres en fonction de la version utilisée",
-  "general_settings.viafabricplus.auto_detect_version": "Détecter automatiquement la version",
 
   "experimental.viafabricplus.chunkborderfix": "Réparer les bordures de Chunk",
   "experimental.viafabricplus.watermovement": "Détection des bords du mouvement de l'eau",

src/main/resources/assets/viafabricplus/lang/hu_hu.json

@@ -29,7 +29,6 @@
   
   "general_settings.viafabricplus.add_server_screen_button_orientation": "Elhelyezése a gombnak a Szerver felvétele képernyőn",
   "general_settings.viafabricplus.show_advertised_server_version": "Hirdetett/szerver verzió megjelenítése Többjátékos módban",
-  "general_settings.viafabricplus.auto_detect_version": "Automatikus verziófelismerés",
   "general_settings.viafabricplus.show_classic_loading_progress": "Klasszikus folyamatjelző mutatása a csatlakozási képernyőn",
   "general_settings.viafabricplus.filter_creative_tabs": "Nem elérhető tárgyak eltávolítása a kreatív felszerelésből",
   "general_settings.viafabricplus.extra_information_in_debug_hud": "Extra információ mutatása a Debug HUD-ban",

src/main/resources/assets/viafabricplus/lang/pl_pl.json

@@ -39,7 +39,6 @@
   "general_settings.viafabricplus.multiplayer_screen_button_orientation": "Lokalizacja przycisku w menu multiplayer",
   "general_settings.viafabricplus.add_server_screen_button_orientation": "Pozycja przycisku ustawiania wersji w ekranie dodawania serwera",
   "general_settings.viafabricplus.filter_creative_tabs": "Usuwaj niedostępne przedmioty z ekwipunku trybu kreatywnego",
-  "general_settings.viafabricplus.auto_detect_version": "Automatycznie wykrywaj wersję gry",
   "general_settings.viafabricplus.show_advertised_server_version": "Pokazuj informacje dotyczące tłumaczenia pakietów po najechaniu na ikonę pingu w menu multiplayer",
   "general_settings.viafabricplus.ignore_packet_translation_errors": "Sposób obsługiwania błędów tłumaczenia pakietów",
   "general_settings.viafabricplus.load_skins_and_skulls_in_legacy_versions": "Ładuj skórki graczy w starszych wersjach gry",

src/main/resources/assets/viafabricplus/lang/ru_ru.json

@@ -39,7 +39,6 @@
   "general_settings.viafabricplus.multiplayer_screen_button_orientation": "Позиция кнопки в меню сетевой игры",
   "general_settings.viafabricplus.add_server_screen_button_orientation": "Позиция кнопки в меню добавления сервера",
   "general_settings.viafabricplus.filter_creative_tabs": "Убрать недоступные предметы из творческого инвентаря",
-  "general_settings.viafabricplus.auto_detect_version": "Автоматическое определение версии",
   "general_settings.viafabricplus.show_advertised_server_version": "Дополнительные сведения о версии сервера в сетевой игре",
   "general_settings.viafabricplus.ignore_packet_translation_errors": "Ошибки преобразования пакетов",
   "general_settings.viafabricplus.load_skins_and_skulls_in_legacy_versions": "Скины и головы игроков в старых версиях",

src/main/resources/assets/viafabricplus/lang/uk_ua.json

@@ -38,7 +38,6 @@
   "general_settings.viafabricplus.multiplayer_screen_button_orientation": "Орієнтація кнопки мультиплеєру",
   "general_settings.viafabricplus.filter_creative_tabs": "Видалити недоступні предмети з меню креативу",
   "general_settings.viafabricplus.protocolsync": "Автоматично змінювати налаштування для вибраної версії",
-  "general_settings.viafabricplus.auto_detect_version": "Автоматично відсліджувати версію",
   "general_settings.viafabricplus.show_advertised_server_version": "Показувати рекламовану/серверну версію в багатокористувацькій грі",
   "general_settings.viafabricplus.ignore_packet_translation_errors": "Ігнорувати помилки перекладу пакетів",
   "general_settings.viafabricplus.load_skins_and_skulls_in_legacy_versions": "Завантажувати скіни та черепи на старих версіях",

src/main/resources/assets/viafabricplus/lang/zh_cn.json

@@ -38,7 +38,6 @@
   "general_settings.viafabricplus.multiplayer_screen_button_orientation": "多人游戏界面的按钮位置",
   "general_settings.viafabricplus.add_server_screen_button_orientation": "编辑服务器页面按钮位置",
   "general_settings.viafabricplus.filter_creative_tabs": "从创造模式选项卡中移除不可用的物品",
-  "general_settings.viafabricplus.auto_detect_version": "自动检测版本",
   "general_settings.viafabricplus.show_advertised_server_version": "在服务器列表-延迟中显示连接所用版本/服务器版本",
   "general_settings.viafabricplus.ignore_packet_translation_errors": "忽略数据包转换错误",
   "general_settings.viafabricplus.load_skins_and_skulls_in_legacy_versions": "加载旧版本皮肤和头颅",
@@ -96,4 +95,4 @@
   "classic4j_library.viafabricplus.error.password": "无效密码",
   "classic4j_library.viafabricplus.error.verification": "用户尚未验证电子邮箱地址！",
   "classic4j_library.viafabricplus.error.logincode": "已请求身份验证。请查看你的电子邮箱！"
-}
+}

src/main/resources/assets/viafabricplus/lang/zh_hk.json

@@ -38,7 +38,6 @@
   "general_settings.viafabricplus.multiplayer_screen_button_orientation": "多人游戲界面嘅按鈕位置",
   "general_settings.viafabricplus.add_server_screen_button_orientation": "伺服器界面嘅按鈕位置",
   "general_settings.viafabricplus.filter_creative_tabs": "從創造模式物品欄內移除唔可用嘅物品",
-  "general_settings.viafabricplus.auto_detect_version": "自動偵測版本",
   "general_settings.viafabricplus.show_advertised_server_version": "在多人遊戲介面顯示伺服器所需版本和實際版本",
   "general_settings.viafabricplus.ignore_packet_translation_errors": "忽略數據包錯誤",
   "general_settings.viafabricplus.load_skins_and_skulls_in_legacy_versions": "載入舊版本嘅外觀和頭顱",
@@ -96,4 +95,4 @@
   "classic4j_library.viafabricplus.error.password": "無效嘅密碼",
   "classic4j_library.viafabricplus.error.verification": "用戶尚未驗證電子郵箱位址",
   "classic4j_library.viafabricplus.error.logincode": "已請求身份驗證。請查看你嘅電郵！"
-}
+}

src/main/resources/assets/viafabricplus/lang/zh_tw.json

@@ -38,7 +38,6 @@
   "general_settings.viafabricplus.multiplayer_screen_button_orientation": "多人遊戲畫面按鈕方向",
   "general_settings.viafabricplus.add_server_screen_button_orientation": "新增伺服器畫面按鈕方向",
   "general_settings.viafabricplus.filter_creative_tabs": "從創造模式物品欄移除不可用的物品",
-  "general_settings.viafabricplus.auto_detect_version": "自動偵測版本",
   "general_settings.viafabricplus.show_advertised_server_version": "在多人遊戲介面顯示伺服器所需版本和實際版本",
   "general_settings.viafabricplus.ignore_packet_translation_errors": "忽略封包轉換錯誤",
   "general_settings.viafabricplus.load_skins_and_skulls_in_legacy_versions": "在舊版中載入外觀和頭顱",
@@ -96,4 +95,4 @@
   "classic4j_library.viafabricplus.error.password": "無效的密碼。",
   "classic4j_library.viafabricplus.error.verification": "使用者尚未驗證電子郵件地址。",
   "classic4j_library.viafabricplus.error.logincode": "要求多重要素驗證。請檢查你的電子郵件。"
-}
+}