From 79310f83be530d04570255ac23e2c04255479082 Mon Sep 17 00:00:00 2001 From: FlorianMichael Date: Fri, 6 Dec 2024 23:19:07 +0100 Subject: [PATCH] Print warning on raw packet sending --- .../ViaFabricPlusPickItemProvider.java | 39 +++++++++++++++++++ .../viaversion/ViaFabricPlusVLLoader.java | 2 + 2 files changed, 41 insertions(+) create mode 100644 src/main/java/de/florianmichael/viafabricplus/protocoltranslator/impl/provider/viaversion/ViaFabricPlusPickItemProvider.java diff --git a/src/main/java/de/florianmichael/viafabricplus/protocoltranslator/impl/provider/viaversion/ViaFabricPlusPickItemProvider.java b/src/main/java/de/florianmichael/viafabricplus/protocoltranslator/impl/provider/viaversion/ViaFabricPlusPickItemProvider.java new file mode 100644 index 00000000..0b770c73 --- /dev/null +++ b/src/main/java/de/florianmichael/viafabricplus/protocoltranslator/impl/provider/viaversion/ViaFabricPlusPickItemProvider.java @@ -0,0 +1,39 @@ +/* + * This file is part of ViaFabricPlus - https://github.com/FlorianMichael/ViaFabricPlus + * Copyright (C) 2021-2024 FlorianMichael/EnZaXD and RK_01/RaphiMC + * Copyright (C) 2023-2024 contributors + * + * This program is free software: you can redistribute it and/or modify + * it under the terms of the GNU General Public License as published by + * the Free Software Foundation, either version 3 of the License, or + * (at your option) any later version. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + * + * You should have received a copy of the GNU General Public License + * along with this program. If not, see . + */ + +package de.florianmichael.viafabricplus.protocoltranslator.impl.provider.viaversion; + +import com.viaversion.viaversion.api.Via; +import com.viaversion.viaversion.api.connection.UserConnection; +import com.viaversion.viaversion.api.minecraft.BlockPosition; +import com.viaversion.viaversion.protocols.v1_21_2to1_21_4.provider.PickItemProvider; + +public class ViaFabricPlusPickItemProvider extends PickItemProvider { + + @Override + public void pickItemFromBlock(UserConnection connection, BlockPosition blockPosition, boolean includeData) { + Via.getPlatform().getLogger().severe("Tried to remap >=1.21.4 PICK_ITEM_FROM_BLOCK packet which is impossible without breaking the content! Find the cause and fix it!"); + } + + @Override + public void pickItemFromEntity(UserConnection connection, int entityId, boolean includeData) { + Via.getPlatform().getLogger().severe("Tried to remap >=1.21.4 PICK_ITEM_FROM_ENTITY packet which is impossible without breaking the content! Find the cause and fix it!"); + } + +} diff --git a/src/main/java/de/florianmichael/viafabricplus/protocoltranslator/impl/viaversion/ViaFabricPlusVLLoader.java b/src/main/java/de/florianmichael/viafabricplus/protocoltranslator/impl/viaversion/ViaFabricPlusVLLoader.java index 0cdbac70..aa04a8b9 100644 --- a/src/main/java/de/florianmichael/viafabricplus/protocoltranslator/impl/viaversion/ViaFabricPlusVLLoader.java +++ b/src/main/java/de/florianmichael/viafabricplus/protocoltranslator/impl/viaversion/ViaFabricPlusVLLoader.java @@ -26,6 +26,7 @@ import com.viaversion.viaversion.api.protocol.version.VersionProvider; import com.viaversion.viaversion.protocols.v1_12_2to1_13.provider.PlayerLookTargetProvider; import com.viaversion.viaversion.protocols.v1_15_2to1_16.provider.PlayerAbilitiesProvider; import com.viaversion.viaversion.protocols.v1_18_2to1_19.provider.AckSequenceProvider; +import com.viaversion.viaversion.protocols.v1_21_2to1_21_4.provider.PickItemProvider; import com.viaversion.viaversion.protocols.v1_8to1_9.provider.HandItemProvider; import de.florianmichael.viafabricplus.event.PostViaVersionLoadCallback; import de.florianmichael.viafabricplus.protocoltranslator.impl.provider.viabedrock.ViaFabricPlusNettyPipelineProvider; @@ -56,6 +57,7 @@ public class ViaFabricPlusVLLoader extends VLLoader { providers.use(PlayerAbilitiesProvider.class, new ViaFabricPlusPlayerAbilitiesProvider()); providers.use(SignableCommandArgumentsProvider.class, new ViaFabricPlusCommandArgumentsProvider()); providers.use(AckSequenceProvider.class, new ViaFabricPlusAckSequenceProvider()); + providers.use(PickItemProvider.class, new ViaFabricPlusPickItemProvider()); providers.use(OldAuthProvider.class, new ViaFabricPlusOldAuthProvider()); providers.use(ClassicWorldHeightProvider.class, new ViaFabricPlusClassicWorldHeightProvider());