Upstream/ViaFabricPlus
1
0
Fork 0
mirror of https://github.com/ViaVersion/ViaFabricPlus.git synced 2024-11-22 11:56:21 +01:00
Code Issues Packages Projects Releases Wiki Activity

Make users aware of unexpected behaviour/issues with overriding jar loading

Browse Source
This commit is contained in:
FlorianMichael 2024-10-10 09:37:25 +02:00
parent 52ff352ef6
commit 8f5da3106a
No known key found for this signature in database
GPG Key ID: C2FB87E71C425126
1 changed files with 9 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
src/main/java/de/florianmichael/viafabricplus/util/ClassLoaderPriorityUtil.java
View File

@ -22,6 +22,7 @@ package de.florianmichael.viafabricplus.util;
import de.florianmichael.viafabricplus.ViaFabricPlus;
import net.lenni0451.reflect.ClassLoaders;
import net.lenni0451.reflect.stream.RStream;
import org.apache.logging.log4j.Logger;
import org.jetbrains.annotations.ApiStatus;
import java.io.File;
@ -36,6 +37,8 @@ public class ClassLoaderPriorityUtil {
* Loads all overriding jars
*/
public static void loadOverridingJars(final File directory) {
final Logger logger = ViaFabricPlus.global().getLogger();
try {
final File jarsDirectory = new File(directory, "jars");
if (!jarsDirectory.exists()) {
@ -49,18 +52,22 @@ public class ClassLoaderPriorityUtil {
try {
final ClassLoader actualLoader = RStream.of(oldLoader).fields().by("urlLoader").get();
Thread.currentThread().setContextClassLoader(actualLoader);
logger.warn("================================");
logger.warn("OVERRIDING JARS LOADING! THIS CAN CAUSE UNEXPECTED BEHAVIOR AND ISSUES!");
for (File file : files) {
if (file.getName().endsWith(".jar")) {
ClassLoaders.loadToFront(file.toURI().toURL());
ViaFabricPlus.global().getLogger().warn("Loaded overriding jar {}", file.getName());
logger.warn(" -> {}", file.getName());
}
}
logger.warn("================================");
} finally {
Thread.currentThread().setContextClassLoader(oldLoader);
}
}
} catch (Throwable e) {
ViaFabricPlus.global().getLogger().error("Failed to load overriding jars", e);
logger.error("Failed to load overriding jars", e);
}
}