From ed73cde50b694bb0f565b10b8b46fa05d4545890 Mon Sep 17 00:00:00 2001 From: FlorianMichael Date: Fri, 11 Oct 2024 10:28:47 +0200 Subject: [PATCH] Remove wrong injection causing sprinting to never reset in <= 1.14.4 Closes https://github.com/ViaVersion/ViaFabricPlus/issues/577 --- docs/MAINTAINING.md | 1 - .../fixes/minecraft/entity/MixinClientPlayerEntity.java | 5 ----- 2 files changed, 6 deletions(-) diff --git a/docs/MAINTAINING.md b/docs/MAINTAINING.md index 6aee503c..17026d62 100644 --- a/docs/MAINTAINING.md +++ b/docs/MAINTAINING.md @@ -12,7 +12,6 @@ These steps are the usual process for updating ViaFabricPlus to a new version of As well as the versions in the `dependencies` block in the `build.gradle` file. 2. Update the `NATIVE_VERSION` field in the ProtocolTranslator class to the new version 3. Check all mixins in the injection package if they still apply correctly, here is a list of some critical ones: - - `MixinClientPlayerEntity#removeBl8Boolean` - `MixinClientWorld#tickEntity` and `MixinClientWorld#tickPassenger` - `MixinPlayer#getBlockBreakingSpeed` 4. Decompile the game source code with the tool of your choice. diff --git a/src/main/java/de/florianmichael/viafabricplus/injection/mixin/fixes/minecraft/entity/MixinClientPlayerEntity.java b/src/main/java/de/florianmichael/viafabricplus/injection/mixin/fixes/minecraft/entity/MixinClientPlayerEntity.java index 41bca931..924b2e08 100644 --- a/src/main/java/de/florianmichael/viafabricplus/injection/mixin/fixes/minecraft/entity/MixinClientPlayerEntity.java +++ b/src/main/java/de/florianmichael/viafabricplus/injection/mixin/fixes/minecraft/entity/MixinClientPlayerEntity.java @@ -145,11 +145,6 @@ public abstract class MixinClientPlayerEntity extends AbstractClientPlayerEntity return ProtocolTranslator.getTargetVersion().newerThan(ProtocolVersion.v1_14_4) && instance.hasVehicle(); } - @ModifyVariable(method = "tickMovement", at = @At(value = "LOAD", ordinal = 4), ordinal = 4) - private boolean removeBl8Boolean(boolean value) { - return ProtocolTranslator.getTargetVersion().newerThan(ProtocolVersion.v1_14_4) && value; - } - @Inject(method = "tickMovement()V", slice = @Slice(from = @At(value = "INVOKE", target = "Lnet/minecraft/client/network/ClientPlayerEntity;isCamera()Z")), at = @At(value = "FIELD", target = "Lnet/minecraft/client/input/Input;sneaking:Z", ordinal = 0))