diff --git a/docs/UPDATE_INSTRUCTIONS.md b/docs/UPDATE_INSTRUCTIONS.md index 28ace890..f18b81b8 100644 --- a/docs/UPDATE_INSTRUCTIONS.md +++ b/docs/UPDATE_INSTRUCTIONS.md @@ -57,7 +57,7 @@ ViaFabricPlus uses Gradle, to make sure that it is installed properly you can ch => If you are unsure if a change is relevant, ask in the ViaVersion discord, in general you should only implement changes which could be detected by a server side anti cheat. -7. Update protocol constants in the `ItemTranslator` class +7. Update protocol constants in the `VFPProtocol` class 8. Check the ViaVersion/upstream protocol implementation for issues and report them if necessary or if these issues can't be fixed, without tons of work, implement a workaround in ViaFabricPlus. 9. Run the game and check all GUIs and other visuals for issues. diff --git a/src/main/java/de/florianmichael/viafabricplus/ViaFabricPlus.java b/src/main/java/de/florianmichael/viafabricplus/ViaFabricPlus.java index a00b434b..654d82fc 100644 --- a/src/main/java/de/florianmichael/viafabricplus/ViaFabricPlus.java +++ b/src/main/java/de/florianmichael/viafabricplus/ViaFabricPlus.java @@ -20,7 +20,6 @@ package de.florianmichael.viafabricplus; import de.florianmichael.viafabricplus.event.PostGameLoadCallback; -import de.florianmichael.viafabricplus.event.PostViaVersionLoadCallback; import de.florianmichael.viafabricplus.fixes.ClientsideFixes; import de.florianmichael.viafabricplus.protocoltranslator.ProtocolTranslator; import de.florianmichael.viafabricplus.save.SaveManager; @@ -75,7 +74,6 @@ public class ViaFabricPlus { PostGameLoadCallback.EVENT.register(() -> { loadingFuture.join(); saveManager.init(); - PostViaVersionLoadCallback.EVENT.invoker().onPostViaVersionLoad(); }); } diff --git a/src/main/java/de/florianmichael/viafabricplus/protocoltranslator/impl/viaversion/ViaFabricPlusVLLoader.java b/src/main/java/de/florianmichael/viafabricplus/protocoltranslator/impl/viaversion/ViaFabricPlusVLLoader.java index fe0897ae..f1b82765 100644 --- a/src/main/java/de/florianmichael/viafabricplus/protocoltranslator/impl/viaversion/ViaFabricPlusVLLoader.java +++ b/src/main/java/de/florianmichael/viafabricplus/protocoltranslator/impl/viaversion/ViaFabricPlusVLLoader.java @@ -27,6 +27,7 @@ import com.viaversion.viaversion.protocols.protocol1_13to1_12_2.providers.Player import com.viaversion.viaversion.protocols.protocol1_16to1_15_2.provider.PlayerAbilitiesProvider; import com.viaversion.viaversion.protocols.protocol1_19to1_18_2.provider.AckSequenceProvider; import com.viaversion.viaversion.protocols.protocol1_9to1_8.providers.HandItemProvider; +import de.florianmichael.viafabricplus.event.PostViaVersionLoadCallback; import de.florianmichael.viafabricplus.protocoltranslator.impl.provider.viabedrock.ViaFabricPlusNettyPipelineProvider; import de.florianmichael.viafabricplus.protocoltranslator.impl.provider.viabedrock.ViaFabricPlusTransferProvider; import de.florianmichael.viafabricplus.protocoltranslator.impl.provider.vialegacy.*; @@ -69,6 +70,8 @@ public class ViaFabricPlusVLLoader extends VLLoader { providers.use(NettyPipelineProvider.class, new ViaFabricPlusNettyPipelineProvider()); providers.use(TransferProvider.class, new ViaFabricPlusTransferProvider()); + + PostViaVersionLoadCallback.EVENT.invoker().onPostViaVersionLoad(); } }