From 54daa11ce4c4fac9079d76a232858cc149cb77d6 Mon Sep 17 00:00:00 2001 From: FlorianMichael Date: Wed, 23 Oct 2024 17:02:45 +0200 Subject: [PATCH] Fix ProtocolVersion#isKnown javadoc to make difference with isRegistered more clear --- .../viaversion/api/protocol/version/ProtocolVersion.java | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/api/src/main/java/com/viaversion/viaversion/api/protocol/version/ProtocolVersion.java b/api/src/main/java/com/viaversion/viaversion/api/protocol/version/ProtocolVersion.java index baea37d25..2facea3aa 100644 --- a/api/src/main/java/com/viaversion/viaversion/api/protocol/version/ProtocolVersion.java +++ b/api/src/main/java/com/viaversion/viaversion/api/protocol/version/ProtocolVersion.java @@ -287,12 +287,12 @@ public class ProtocolVersion implements Comparable { } /** - * Returns whether the protocol is set. Should only be unknown for unregistered protocols returned by {@link #getProtocol(int)}. + * Returns whether the protocol version is {@link #unknown}. For checking if the protocol version is registered, use {@link #isRegistered(VersionType, int)} * - * @return true if the protocol is set + * @return true if the protocol version is unknown */ public boolean isKnown() { - return version != -1; + return this != unknown; } /**