From 78aecbddf8d93094ab4bc7430fed2b4a84165293 Mon Sep 17 00:00:00 2001
From: RK_01 <50594595+RaphiMC@users.noreply.github.com>
Date: Sun, 18 Feb 2024 21:55:14 +0100
Subject: [PATCH] Don't add base protocols when using special versions (#3704)

---
 .../viaversion/api/protocol/version/VersionType.java       | 1 +
 .../viaversion/viaversion/protocols/base/BaseProtocol.java | 7 +++++--
 2 files changed, 6 insertions(+), 2 deletions(-)

diff --git a/api/src/main/java/com/viaversion/viaversion/api/protocol/version/VersionType.java b/api/src/main/java/com/viaversion/viaversion/api/protocol/version/VersionType.java
index 0674e06f4..e8d7160de 100644
--- a/api/src/main/java/com/viaversion/viaversion/api/protocol/version/VersionType.java
+++ b/api/src/main/java/com/viaversion/viaversion/api/protocol/version/VersionType.java
@@ -59,6 +59,7 @@ public enum VersionType {
      * Any version that doesn't fit in the above categories (e.g. April Fools).
      * <p>
      * Protocol versions using this type must override the compareTo method.
+     * Protocol versions using this type must add base protocols to the pipeline manually.
      */
     SPECIAL
 }
\ No newline at end of file
diff --git a/common/src/main/java/com/viaversion/viaversion/protocols/base/BaseProtocol.java b/common/src/main/java/com/viaversion/viaversion/protocols/base/BaseProtocol.java
index 465d912ef..d33ef3c18 100644
--- a/common/src/main/java/com/viaversion/viaversion/protocols/base/BaseProtocol.java
+++ b/common/src/main/java/com/viaversion/viaversion/protocols/base/BaseProtocol.java
@@ -30,6 +30,7 @@ import com.viaversion.viaversion.api.protocol.packet.State;
 import com.viaversion.viaversion.api.protocol.packet.provider.PacketTypesProvider;
 import com.viaversion.viaversion.api.protocol.version.ProtocolVersion;
 import com.viaversion.viaversion.api.protocol.version.VersionProvider;
+import com.viaversion.viaversion.api.protocol.version.VersionType;
 import com.viaversion.viaversion.api.type.Type;
 import com.viaversion.viaversion.protocols.base.packet.BaseClientboundPacket;
 import com.viaversion.viaversion.protocols.base.packet.BasePacketTypesProvider;
@@ -93,7 +94,9 @@ public class BaseProtocol extends AbstractProtocol<BaseClientboundPacket, BaseCl
             }
 
             // Add Base Protocol
-            pipeline.add(Via.getManager().getProtocolManager().getBaseProtocol(serverProtocol));
+            if (!serverProtocol.getVersionType().equals(VersionType.SPECIAL)) {
+                pipeline.add(Via.getManager().getProtocolManager().getBaseProtocol(serverProtocol));
+            }
 
             if (Via.getManager().isDebug()) {
                 Via.getPlatform().getLogger().info("User connected with protocol: " + info.protocolVersion() + " and serverProtocol: " + info.serverProtocolVersion());
@@ -139,4 +142,4 @@ public class BaseProtocol extends AbstractProtocol<BaseClientboundPacket, BaseCl
     protected PacketTypesProvider<BaseClientboundPacket, BaseClientboundPacket, BaseServerboundPacket, BaseServerboundPacket> createPacketTypesProvider() {
         return BasePacketTypesProvider.INSTANCE;
     }
-}
+}
\ No newline at end of file