From d48d0a21db4a04da04965b86f970b2ed71dc3835 Mon Sep 17 00:00:00 2001 From: Nassim Jahnke Date: Sat, 2 Nov 2024 22:53:29 +0100 Subject: [PATCH] Prettify error messages --- .../exception/InformativeException.java | 17 +++++++++++++---- 1 file changed, 13 insertions(+), 4 deletions(-) diff --git a/api/src/main/java/com/viaversion/viaversion/exception/InformativeException.java b/api/src/main/java/com/viaversion/viaversion/exception/InformativeException.java index d2cb0e139..4afc16d3a 100644 --- a/api/src/main/java/com/viaversion/viaversion/exception/InformativeException.java +++ b/api/src/main/java/com/viaversion/viaversion/exception/InformativeException.java @@ -22,11 +22,13 @@ */ package com.viaversion.viaversion.exception; +import com.viaversion.viaversion.api.Via; import java.util.ArrayList; import java.util.List; import org.checkerframework.checker.nullness.qual.Nullable; public class InformativeException extends RuntimeException { + private static final int MAX_MESSAGE_LENGTH = 5_000; private final List dataEntries = new ArrayList<>(); private boolean shouldBePrinted = true; private int sources; @@ -58,14 +60,21 @@ public class InformativeException extends RuntimeException { @Override public String getMessage() { - StringBuilder builder = new StringBuilder("Please report this on the Via support Discord or open an issue on the relevant GitHub repository\n"); + final StringBuilder builder = new StringBuilder("Please report this on the Via support Discord or open an issue on the relevant GitHub repository\n"); boolean first = true; - for (DataEntry entry : dataEntries) { + for (final DataEntry entry : dataEntries) { if (!first) { builder.append(", "); + } else { + first = false; } - builder.append(entry.name()).append(": ").append(entry.value()); - first = false; + + builder.append(entry.name()).append(": "); + String s = String.valueOf(entry.value()); + if (!Via.getManager().isDebug() && s.length() > 10 && builder.length() + s.length() > MAX_MESSAGE_LENGTH) { + s = s.substring(0, MAX_MESSAGE_LENGTH - builder.length()) + "..."; + } + builder.append(s.replaceAll("\\s", "")); } return builder.toString(); }