Upstream/Waterfall
1
0
Fork 0
mirror of https://github.com/PaperMC/Waterfall.git synced 2024-09-28 22:47:49 +02:00
Code Issues Projects Releases Wiki Activity
73e6de29cc
Waterfall/BungeeCord-Patches/0061-Don-t-send-exceptions-to-the-client-during-kicks-etc.patch

32 lines
1.4 KiB
Diff
Raw Normal View History

Updated Upstream (BungeeCord) Upstream has released updates that appear to apply and compile correctly. This update has not been tested by PaperMC and as with ANY update, please do your own testing BungeeCord Changes: 5e7dcc48 #3382: Use the correct write method for ChatChain in ClientChat packet 5cdba87b #3377: Add additional checks for protocol length limits
2022-08-20 18:43:03 +02:00
From ab3fe51154af6559ace6fba45542f6ad982f339f Mon Sep 17 00:00:00 2001
Don't send exceptions to the client during kicks, etc The info here is often not filtered down and can often contain internal information during these kicks which server owners are generally not happy with sharing, i.e. potential IP addresses, etc We'll have to dump the cause to the console manually to ensure that data is still sent, but, a wider fix here is probably needed which allows for retaining much of the overall context here, i.e. who was this exception assocated with?
2022-03-22 15:59:09 +01:00
From: Shane Freeder <theboyetronic@gmail.com>
Date: Tue, 22 Mar 2022 14:56:44 +0000
Subject: [PATCH] Don't send exceptions to the client during kicks, etc
The info here is often not filtered down and can often contain
internal information during these kicks which server owners are
generally not happy with sharing, i.e. potential IP addresses, etc
We'll have to dump the cause to the console manually to ensure that
data is still sent, but, a wider fix here is probably needed which
allows for retaining much of the overall context here, i.e. who
was this exception assocated with?
diff --git a/proxy/src/main/java/net/md_5/bungee/UserConnection.java b/proxy/src/main/java/net/md_5/bungee/UserConnection.java
Updated Upstream (BungeeCord) (#762) Co-authored-by: Thomas A <thomas.a@erisium.com>
2022-07-03 17:06:31 +02:00
index eb236957..b44d13e5 100644
Don't send exceptions to the client during kicks, etc The info here is often not filtered down and can often contain internal information during these kicks which server owners are generally not happy with sharing, i.e. potential IP addresses, etc We'll have to dump the cause to the console manually to ensure that data is still sent, but, a wider fix here is probably needed which allows for retaining much of the overall context here, i.e. who was this exception assocated with?
2022-03-22 15:59:09 +01:00
--- a/proxy/src/main/java/net/md_5/bungee/UserConnection.java
+++ b/proxy/src/main/java/net/md_5/bungee/UserConnection.java
Updated Upstream (BungeeCord) (#741)
2022-06-07 19:12:20 +02:00
@@ -399,7 +399,8 @@ public final class UserConnection implements ProxiedPlayer
Don't send exceptions to the client during kicks, etc The info here is often not filtered down and can often contain internal information during these kicks which server owners are generally not happy with sharing, i.e. potential IP addresses, etc We'll have to dump the cause to the console manually to ensure that data is still sent, but, a wider fix here is probably needed which allows for retaining much of the overall context here, i.e. who was this exception assocated with?
2022-03-22 15:59:09 +01:00
private String connectionFailMessage(Throwable cause)
{
Updated Upstream (BungeeCord) Upstream has released updates that appear to apply and compile correctly. This update has not been tested by PaperMC and as with ANY update, please do your own testing BungeeCord Changes: 862bb2ac #3258: Only show detailed connect exception to admins
2022-04-25 18:52:14 +02:00
- return groups.contains( "admin" ) ? Util.exception( cause, false ) : cause.getClass().getName();
+ bungee.getLogger().log(Level.WARNING, "Error occurred processing connection for " + this.name + " " + Util.exception( cause, false )); // Waterfall
+ return ""; // Waterfall
Don't send exceptions to the client during kicks, etc The info here is often not filtered down and can often contain internal information during these kicks which server owners are generally not happy with sharing, i.e. potential IP addresses, etc We'll have to dump the cause to the console manually to ensure that data is still sent, but, a wider fix here is probably needed which allows for retaining much of the overall context here, i.e. who was this exception assocated with?
2022-03-22 15:59:09 +01:00
}
@Override
--
Updated Upstream (BungeeCord) Upstream has released updates that appear to apply and compile correctly. This update has not been tested by PaperMC and as with ANY update, please do your own testing BungeeCord Changes: 5e7dcc48 #3382: Use the correct write method for ChatChain in ClientChat packet 5cdba87b #3377: Add additional checks for protocol length limits
2022-08-20 18:43:03 +02:00
2.37.2
Don't send exceptions to the client during kicks, etc The info here is often not filtered down and can often contain internal information during these kicks which server owners are generally not happy with sharing, i.e. potential IP addresses, etc We'll have to dump the cause to the console manually to ensure that data is still sent, but, a wider fix here is probably needed which allows for retaining much of the overall context here, i.e. who was this exception assocated with?
2022-03-22 15:59:09 +01:00
Reference in New Issue Copy Permalink