Twenty Seventeen: Correct issues with hidden overflow and height on site header

In -r39124, some additional issues were introduced:

* The 'overflow: hidden' on the `.site-header;` was added to prevent a side-scrolling issue, but it ended up cutting off the menu. It looks like the cause of the side-scroll was related to how the scroll down icon was rotated, so it's addressed by rotating the icon and not the `<a>`.
* Also, `min-height` doesn't play well with `display: table;` in Firefox. So it's addressed with just `height`.

Props laurelfulford, sami.keijonen.

See #38543.

Built from https://develop.svn.wordpress.org/trunk@39129


git-svn-id: http://core.svn.wordpress.org/trunk@39069 1a063a9b-81f0-0310-95a4-ce76da25c4cd
This commit is contained in:
David A. Kennedy 2016-11-04 17:12:57 +00:00
parent 50b2c6cf2c
commit 0a3d034962
2 changed files with 7 additions and 6 deletions

View File

@ -1542,7 +1542,6 @@ body {
.site-header {
background-color: #fafafa;
position: relative;
overflow: hidden;
}
/* Site branding */
@ -1636,9 +1635,8 @@ body:not(.title-tagline-hidden) .site-branding-text {
.has-header-image.twentyseventeen-front-page .custom-header,
.has-header-image.home.blog .custom-header {
display: table;
height: 100%;
min-height: 300px;
min-height: 75vh;
height: 300px;
height: 75vh;
width: 100%;
}
@ -3257,7 +3255,7 @@ object {
.has-header-image.twentyseventeen-front-page .custom-header,
.has-header-image.home.blog .custom-header {
display: block;
min-height: 0;
height: auto;
}
.custom-header-image {
@ -3521,6 +3519,9 @@ object {
padding: 1em;
position: absolute;
right: 0;
}
.site-header .menu-scroll-down .icon {
-webkit-transform: rotate(90deg); /* Chrome, Safari, Opera */
-ms-transform: rotate(90deg); /* IE 9 */
transform: rotate(90deg);

View File

@ -4,7 +4,7 @@
*
* @global string $wp_version
*/
$wp_version = '4.7-beta1-39128';
$wp_version = '4.7-beta1-39129';
/**
* Holds the WordPress DB revision, increments when changes are made to the WordPress DB schema.