Upstream/WordPress
1
0
Fork 0
mirror of https://github.com/WordPress/WordPress.git synced 2024-12-23 09:37:42 +01:00
Code Issues Projects Releases Wiki Activity

Check is_callable() in do_shortcode_tag(), not add_shortcode().

Browse Source 
Add a `_doing_it_wrong()` in `do_shortcode_tag()` when `is_callable()` is `false`.

Props aaroncampbell.
See #32445.

Built from https://develop.svn.wordpress.org/trunk@32867


git-svn-id: http://core.svn.wordpress.org/trunk@32838 1a063a9b-81f0-0310-95a4-ce76da25c4cd
This commit is contained in:
Scott Taylor 2015-06-19 21:33:25 +00:00
parent ec6dfc7f2b
commit 0c866cfa79
2 changed files with 8 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
wp-includes/shortcodes.php
View File

@ -88,9 +88,7 @@ $shortcode_tags = array();
*/ */
function add_shortcode($tag, $func) { function add_shortcode($tag, $func) {
global $shortcode_tags; global $shortcode_tags;
$shortcode_tags[ $tag ] = $func;
if ( is_callable($func) )
$shortcode_tags[$tag] = $func;
} }
/** /**
@ -282,6 +280,12 @@ function do_shortcode_tag( $m ) {
$tag = $m[2]; $tag = $m[2];
$attr = shortcode_parse_atts( $m[3] ); $attr = shortcode_parse_atts( $m[3] );
if ( ! is_callable( $shortcode_tags[ $tag ] ) ) {
$message = sprintf( __( 'Attempting to parse a shortcode without a valid callback: %s' ), $tag );
_doing_it_wrong( __FUNCTION__, $message, '4.3.0' );
return $m[0];
}
if ( isset( $m[5] ) ) { if ( isset( $m[5] ) ) {
// enclosing tag - extra parameter // enclosing tag - extra parameter
return $m[1] . call_user_func( $shortcode_tags[$tag], $attr, $m[5], $tag ) . $m[6]; return $m[1] . call_user_func( $shortcode_tags[$tag], $attr, $m[5], $tag ) . $m[6];

2
wp-includes/version.php
View File

@ -4,7 +4,7 @@
* *
* @global string $wp_version * @global string $wp_version
*/ */
$wp_version = '4.3-alpha-32866'; $wp_version = '4.3-alpha-32867';
/** /**
* Holds the WordPress DB revision, increments when changes are made to the WordPress DB schema. * Holds the WordPress DB revision, increments when changes are made to the WordPress DB schema.