Upstream/WordPress
1
0
Fork 0
mirror of https://github.com/WordPress/WordPress.git synced 2024-12-23 01:27:36 +01:00
Code Issues Projects Releases Wiki Activity

Media: Only add aria-describedby in img_caption_shortcode() if a non-empty attachment ID attribute was provided.

Browse Source 
See #34595.
Built from https://develop.svn.wordpress.org/trunk@42693


git-svn-id: http://core.svn.wordpress.org/trunk@42521 1a063a9b-81f0-0310-95a4-ce76da25c4cd
This commit is contained in:
Sergey Biryukov 2018-02-11 15:20:30 +00:00
parent dffe5deb97
commit 0f2b559d05
2 changed files with 25 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

39
wp-includes/media.php
View File

@ -1543,11 +1543,12 @@ function img_caption_shortcode( $attr, $content = null ) {
$atts = shortcode_atts(
array(
'id' => '',
'align' => 'alignnone',
'width' => '',
'caption' => '',
'class' => '',
'id' => '',
'caption_id' => '',
'align' => 'alignnone',
'width' => '',
'caption' => '',
'class' => '',
), $attr, 'caption'
);
@ -1556,12 +1557,20 @@ function img_caption_shortcode( $attr, $content = null ) {
return $content;
}
$caption_id = '';
if ( ! empty( $atts['id'] ) ) {
if ( $atts['id'] ) {
$att_id = esc_attr( sanitize_html_class( $atts['id'] ) );
$atts['id'] = 'id="' . $att_id . '" ';
$caption_id = 'caption-' . str_replace( '_', '-', $att_id );
if ( ! $atts['caption_id'] ) {
$atts['caption_id'] = 'caption-' . str_replace( '_', '-', $att_id );
}
}
$describedby = '';
if ( $atts['caption_id'] ) {
$describedby = 'aria-describedby="' . $atts['caption_id'] . '" ';
$atts['caption_id'] = 'id="' . $atts['caption_id'] . '" ';
}
$class = trim( 'wp-caption ' . $atts['align'] . ' ' . $atts['class'] );
@ -1594,15 +1603,15 @@ function img_caption_shortcode( $attr, $content = null ) {
if ( $html5 ) {
$html = sprintf(
'<figure %s%sclass="%s" aria-describedby="%s">%s%s</figure>',
'<figure %s%s%sclass="%s">%s%s</figure>',
$atts['id'],
$describedby,
$style,
esc_attr( $class ),
$caption_id,
do_shortcode( $content ),
sprintf(
'<figcaption id="%s" class="wp-caption-text">%s</figcaption>',
$caption_id,
'<figcaption %sclass="wp-caption-text">%s</figcaption>',
$atts['caption_id'],
$atts['caption']
)
);
@ -1612,10 +1621,10 @@ function img_caption_shortcode( $attr, $content = null ) {
$atts['id'],
$style,
esc_attr( $class ),
str_replace( '<img ', '<img aria-describedby="' . $caption_id . '" ', do_shortcode( $content ) ),
str_replace( '<img ', '<img ' . $describedby, do_shortcode( $content ) ),
sprintf(
'<p id="%s" class="wp-caption-text">%s</p>',
$caption_id,
$atts['caption_id'],
$atts['caption']
)
);

2
wp-includes/version.php
View File

@ -4,7 +4,7 @@
*
* @global string $wp_version
*/
$wp_version = '5.0-alpha-42692';
$wp_version = '5.0-alpha-42693';
/**
* Holds the WordPress DB revision, increments when changes are made to the WordPress DB schema.