XML-RPC: Only escape what we need to in wp.editPage, this allows for passwords with the special characters "' to work in a request.

Props redsweater for initial Patch.
Fixes #32703

Built from https://develop.svn.wordpress.org/trunk@32993


git-svn-id: http://core.svn.wordpress.org/trunk@32964 1a063a9b-81f0-0310-95a4-ce76da25c4cd
This commit is contained in:
Dion Hulse 2015-06-29 02:07:23 +00:00
parent 4605417b1c
commit 2a35e075d7
2 changed files with 10 additions and 6 deletions

View File

@ -2747,15 +2747,19 @@ class wp_xmlrpc_server extends IXR_Server {
* @return array|IXR_Error * @return array|IXR_Error
*/ */
public function wp_editPage( $args ) { public function wp_editPage( $args ) {
// Items not escaped here will be escaped in editPost. // Items will be escaped in mw_editPost.
$page_id = (int) $this->escape($args[1]); $page_id = (int) $args[1];
$username = $this->escape($args[2]); $username = $args[2];
$password = $this->escape($args[3]); $password = $args[3];
$content = $args[4]; $content = $args[4];
$publish = $args[5]; $publish = $args[5];
if ( !$user = $this->login($username, $password) ) $escaped_username = $this->escape( $username );
$escaped_password = $this->escape( $password );
if ( !$user = $this->login( $escaped_username, $escaped_password ) ) {
return $this->error; return $this->error;
}
/** This action is documented in wp-includes/class-wp-xmlrpc-server.php */ /** This action is documented in wp-includes/class-wp-xmlrpc-server.php */
do_action( 'xmlrpc_call', 'wp.editPage' ); do_action( 'xmlrpc_call', 'wp.editPage' );

View File

@ -4,7 +4,7 @@
* *
* @global string $wp_version * @global string $wp_version
*/ */
$wp_version = '4.3-alpha-32992'; $wp_version = '4.3-alpha-32993';
/** /**
* Holds the WordPress DB revision, increments when changes are made to the WordPress DB schema. * Holds the WordPress DB revision, increments when changes are made to the WordPress DB schema.