Upstream/WordPress
1
0
Fork 0
mirror of https://github.com/WordPress/WordPress.git synced 2024-12-23 09:37:42 +01:00
Code Issues Projects Releases Wiki Activity

Check for empty meta keys. Props Denis-de-Bernardy, markedwards. fixes #7953

Browse Source 
git-svn-id: http://svn.automattic.com/wordpress/trunk@10711 1a063a9b-81f0-0310-95a4-ce76da25c4cd
This commit is contained in:
ryan 2009-03-04 22:59:16 +00:00
parent f8ada7a44a
commit 423b468ebf
1 changed files with 18 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
wp-includes/post.php
View File

@ -510,6 +510,9 @@ function get_posts($args = null) {
* @return bool False for failure. True for success. * @return bool False for failure. True for success.
*/ */
function add_post_meta($post_id, $meta_key, $meta_value, $unique = false) { function add_post_meta($post_id, $meta_key, $meta_value, $unique = false) {
if ( !$meta_key )
return false;
global $wpdb; global $wpdb;
// make sure meta is added to the post, not a revision // make sure meta is added to the post, not a revision
@ -558,6 +561,9 @@ function delete_post_meta($post_id, $meta_key, $meta_value = '') {
$meta_key = stripslashes( $meta_key ); $meta_key = stripslashes( $meta_key );
$meta_value = maybe_serialize( stripslashes_deep($meta_value) ); $meta_value = maybe_serialize( stripslashes_deep($meta_value) );
if ( !$meta_key )
return false;
if ( empty( $meta_value ) ) if ( empty( $meta_value ) )
$meta_id = $wpdb->get_var( $wpdb->prepare( "SELECT meta_id FROM $wpdb->postmeta WHERE post_id = %d AND meta_key = %s", $post_id, $meta_key ) ); $meta_id = $wpdb->get_var( $wpdb->prepare( "SELECT meta_id FROM $wpdb->postmeta WHERE post_id = %d AND meta_key = %s", $post_id, $meta_key ) );
else else
@ -589,6 +595,9 @@ function delete_post_meta($post_id, $meta_key, $meta_value = '') {
* @return mixed Will be an array if $single is false. Will be value of meta data field if $single is true. * @return mixed Will be an array if $single is false. Will be value of meta data field if $single is true.
*/ */
function get_post_meta($post_id, $key, $single = false) { function get_post_meta($post_id, $key, $single = false) {
if ( !$key )
return '';
$post_id = (int) $post_id; $post_id = (int) $post_id;
$meta_cache = wp_cache_get($post_id, 'post_meta'); $meta_cache = wp_cache_get($post_id, 'post_meta');
@ -637,6 +646,9 @@ function update_post_meta($post_id, $meta_key, $meta_value, $prev_value = '') {
// expected_slashed ($meta_key) // expected_slashed ($meta_key)
$meta_key = stripslashes($meta_key); $meta_key = stripslashes($meta_key);
if ( !$meta_key )
return false;
if ( ! $wpdb->get_var( $wpdb->prepare( "SELECT meta_key FROM $wpdb->postmeta WHERE meta_key = %s AND post_id = %d", $meta_key, $post_id ) ) ) { if ( ! $wpdb->get_var( $wpdb->prepare( "SELECT meta_key FROM $wpdb->postmeta WHERE meta_key = %s AND post_id = %d", $meta_key, $post_id ) ) ) {
return add_post_meta($post_id, $meta_key, $meta_value); return add_post_meta($post_id, $meta_key, $meta_value);
} }
@ -666,6 +678,9 @@ function update_post_meta($post_id, $meta_key, $meta_value, $prev_value = '') {
* @return bool Whether the post meta key was deleted from the database * @return bool Whether the post meta key was deleted from the database
*/ */
function delete_post_meta_by_key($post_meta_key) { function delete_post_meta_by_key($post_meta_key) {
if ( !$post_meta_key )
return false;
global $wpdb; global $wpdb;
if ( $wpdb->query($wpdb->prepare("DELETE FROM $wpdb->postmeta WHERE meta_key = %s", $post_meta_key)) ) { if ( $wpdb->query($wpdb->prepare("DELETE FROM $wpdb->postmeta WHERE meta_key = %s", $post_meta_key)) ) {
/** @todo Get post_ids and delete cache */ /** @todo Get post_ids and delete cache */
@ -739,6 +754,9 @@ function get_post_custom_keys( $post_id = 0 ) {
* @return array Meta field values. * @return array Meta field values.
*/ */
function get_post_custom_values( $key = '', $post_id = 0 ) { function get_post_custom_values( $key = '', $post_id = 0 ) {
if ( !$key )
return null;
$custom = get_post_custom($post_id); $custom = get_post_custom($post_id);
return isset($custom[$key]) ? $custom[$key] : null; return isset($custom[$key]) ? $custom[$key] : null;