From 463b7c4620307f603a2fe3f127f782cc445d3e1b Mon Sep 17 00:00:00 2001 From: Scott Taylor Date: Fri, 16 May 2014 15:19:14 +0000 Subject: [PATCH] Eliminate use of `extract()` in `wp_xmlrpc_server::mw_editPost()` (MetaWeblog API, y'all). A lot of the extracted variables are overwritten by being explicitly set later. Only set variables that would otherwise not be present with `compact()` is called. See #22400. Built from https://develop.svn.wordpress.org/trunk@28448 git-svn-id: http://core.svn.wordpress.org/trunk@28275 1a063a9b-81f0-0310-95a4-ce76da25c4cd --- wp-includes/class-wp-xmlrpc-server.php | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/wp-includes/class-wp-xmlrpc-server.php b/wp-includes/class-wp-xmlrpc-server.php index 3ab6938fa8..55bc8f4afb 100644 --- a/wp-includes/class-wp-xmlrpc-server.php +++ b/wp-includes/class-wp-xmlrpc-server.php @@ -4727,7 +4727,14 @@ class wp_xmlrpc_server extends IXR_Server { } $this->escape($postdata); - extract($postdata, EXTR_SKIP); + + $ID = $postdata['ID']; + $post_content = $postdata['post_content']; + $post_title = $postdata['post_title']; + $post_excerpt = $postdata['post_excerpt']; + $post_password = $postdata['post_password']; + $post_parent = $postdata['post_parent']; + $menu_order = $postdata['menu_order']; // Let WordPress manage slug if none was provided. $post_name = ""; @@ -4747,6 +4754,7 @@ class wp_xmlrpc_server extends IXR_Server { if ( isset($content_struct['wp_page_order']) ) $menu_order = $content_struct['wp_page_order']; + $page_template = null; if ( ! empty( $content_struct['wp_page_template'] ) && 'page' == $post_type ) $page_template = $content_struct['wp_page_template'];