Upstream/WordPress
1
0
Fork 0
mirror of https://github.com/WordPress/WordPress.git synced 2025-01-22 08:11:52 +01:00
Code Issues Projects Releases Wiki Activity

List tables: Yet more primary column fallbacks.

Browse Source 
Some custom list tables override enough methods for the column definition fallback to never kick in, so let's ensure that toggling columns only applies when a primary column is defined in some way. We also need to show a toggle button when we can when there are no row actions.

props Chouby, obenland, ocean90.
fixes #33313.

Built from https://develop.svn.wordpress.org/trunk@33623


git-svn-id: http://core.svn.wordpress.org/trunk@33590 1a063a9b-81f0-0310-95a4-ce76da25c4cd
This commit is contained in:
Helen Hou-Sandí 2015-08-17 15:38:25 +00:00
parent dfcf1d0035
commit 50e42e8a07
6 changed files with 12 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
wp-admin/css/list-tables-rtl.css
View File

@ -1764,9 +1764,8 @@ div.action-links,
font-size: 14px;
}
.wp-list-table th:not(.column-primary),
.wp-list-table th:not(.column-primary),
.wp-list-table tr:not(.inline-edit-row):not(.no-items) td:not(.column-primary):not(.check-column) {
.wp-list-table th.column-primary ~ th,
.wp-list-table tr:not(.inline-edit-row):not(.no-items) td.column-primary ~ td:not(.check-column) {
display: none;
}
@ -1780,7 +1779,7 @@ div.action-links,
width: 35px;
}
.wp-list-table .toggle-row {
.wp-list-table .column-primary .toggle-row {
display: block;
}
@ -1795,7 +1794,7 @@ div.action-links,
padding-left: 50px; /* space for toggle button */
}
.wp-list-table tr:not(.inline-edit-row):not(.no-items) td:not(.column-primary):not(.check-column) {
.wp-list-table tr:not(.inline-edit-row):not(.no-items) td.column-primary ~ td:not(.check-column) {
padding: 3px 35% 3px 8px;
}

9
wp-admin/css/list-tables.css
View File

@ -1764,9 +1764,8 @@ div.action-links,
font-size: 14px;
}
.wp-list-table th:not(.column-primary),
.wp-list-table th:not(.column-primary),
.wp-list-table tr:not(.inline-edit-row):not(.no-items) td:not(.column-primary):not(.check-column) {
.wp-list-table th.column-primary ~ th,
.wp-list-table tr:not(.inline-edit-row):not(.no-items) td.column-primary ~ td:not(.check-column) {
display: none;
}
@ -1780,7 +1779,7 @@ div.action-links,
width: 35px;
}
.wp-list-table .toggle-row {
.wp-list-table .column-primary .toggle-row {
display: block;
}
@ -1795,7 +1794,7 @@ div.action-links,
padding-right: 50px; /* space for toggle button */
}
.wp-list-table tr:not(.inline-edit-row):not(.no-items) td:not(.column-primary):not(.check-column) {
.wp-list-table tr:not(.inline-edit-row):not(.no-items) td.column-primary ~ td:not(.check-column) {
padding: 3px 8px 3px 35%;
}

2
wp-admin/css/wp-admin-rtl.min.css vendored
View File

File diff suppressed because one or more lines are too long

2
wp-admin/css/wp-admin.min.css vendored
View File

File diff suppressed because one or more lines are too long

2
wp-admin/includes/class-wp-list-table.php
View File

@ -1258,7 +1258,7 @@ class WP_List_Table {
* @return string The row actions output. In this case, an empty string.
*/
protected function handle_row_actions( $item, $column_name, $primary ) {
return '';
return $column_name == $primary ? '<button type="button" class="toggle-row"><span class="screen-reader-text">' . __( 'Show more details' ) . '</span></button>' : '';
}
/**

2
wp-includes/version.php
View File

@ -4,7 +4,7 @@
*
* @global string $wp_version
*/
$wp_version = '4.3-RC2-33622';
$wp_version = '4.3-RC2-33623';
/**
* Holds the WordPress DB revision, increments when changes are made to the WordPress DB schema.