Upstream
/
WordPress
mirror of https://github.com/WordPress/WordPress.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

Site Health: Improve vertical alignment of icons in test result descriptions. 

This change removes redundant CSS properties for different health check statuses in favor of utilizing the `.dashicons` class already in Core to define them more consistently. This also fixes the vertical alignment issues.

Merges [45309] to the 5.2 branch.

Props chetan200891, Clorith, desrosj.
Fixes #46940.
Built from https://develop.svn.wordpress.org/branches/5.2@45314


git-svn-id: http://core.svn.wordpress.org/branches/5.2@45125 1a063a9b-81f0-0310-95a4-ce76da25c4cd
This commit is contained in:
desrosj 2019-05-15 19:52:54 +00:00
parent 6d0e5ee9d0
commit 5bb4b73062
6 changed files with 5 additions and 23 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
wp-admin/css/site-health-rtl.css
View File

@ -153,32 +153,23 @@
.health-check-body .pass::before,
.health-check-body .good::before {
content: "\f147";
display: inline-block;
color: #46b450;
font-family: dashicons;
vertical-align: top;
}
.health-check-body .warning::before {
content: "\f460";
display: inline-block;
color: #ffb900;
font-family: dashicons;
}
.health-check-body .info::before {
content: "\f348";
display: inline-block;
color: #00a0d2;
font-family: dashicons;
}
.health-check-body .fail::before,
.health-check-body .error::before {
content: "\f335";
display: inline-block;
color: #dc3232;
font-family: dashicons;
}
.site-health-copy-buttons {

2
wp-admin/css/site-health-rtl.min.css vendored
View File

File diff suppressed because one or more lines are too long

9
wp-admin/css/site-health.css
View File

@ -153,32 +153,23 @@
.health-check-body .pass::before,
.health-check-body .good::before {
content: "\f147";
display: inline-block;
color: #46b450;
font-family: dashicons;
vertical-align: top;
}
.health-check-body .warning::before {
content: "\f460";
display: inline-block;
color: #ffb900;
font-family: dashicons;
}
.health-check-body .info::before {
content: "\f348";
display: inline-block;
color: #00a0d2;
font-family: dashicons;
}
.health-check-body .fail::before,
.health-check-body .error::before {
content: "\f335";
display: inline-block;
color: #dc3232;
font-family: dashicons;
}
.site-health-copy-buttons {

2
wp-admin/css/site-health.min.css vendored
View File

File diff suppressed because one or more lines are too long

4
wp-admin/includes/class-wp-site-health.php
View File

@ -889,7 +889,7 @@ class WP_Site_Health {
$result['status'] = 'recommended';
}
$failures[ $library ] = "<span class='$class'><span class='screen-reader-text'>$screen_reader</span></span> $message";
$failures[ $library ] = "<span class='dashicons $class'><span class='screen-reader-text'>$screen_reader</span></span> $message";
}
}
@ -1487,7 +1487,7 @@ class WP_Site_Health {
}
$output .= sprintf(
'<li><span class="%s"><span class="screen-reader-text">%s</span></span> %s</li>',
'<li><span class="dashicons %s"><span class="screen-reader-text">%s</span></span> %s</li>',
esc_attr( $test->severity ),
$severity_string,
$test->description

2
wp-includes/version.php
View File

@ -13,7 +13,7 @@
*
* @global string $wp_version
*/
$wp_version = '5.2.1-alpha-45313';
$wp_version = '5.2.1-alpha-45314';
/**
* Holds the WordPress DB revision, increments when changes are made to the WordPress DB schema.