Upstream/WordPress
1
0
Fork 0
mirror of https://github.com/WordPress/WordPress.git synced 2024-11-16 07:35:39 +01:00
Code Issues Projects Releases Wiki Activity

REST API: Fix incorrect uses of rest_sanitize_value_from_schema().

Browse Source 
In the `check_username()` and `check_password()` callbacks in the Users controller cast the provided request value to a string. The `rest_sanitize_value_from_schema()` function was being used incorrectly which was causing unintended request parsing. 
In `rest_sanitize_request_arg()` do not pass nonexistent third parameter for the `rest_sanitize_value_from_schema()` function.

Props jnylen0, joehoyle, rachelbaker, ocean90.
Fixes #38984.
Built from https://develop.svn.wordpress.org/trunk@39400


git-svn-id: http://core.svn.wordpress.org/trunk@39340 1a063a9b-81f0-0310-95a4-ce76da25c4cd
This commit is contained in:
Rachel Baker 2016-12-01 02:12:41 +00:00
parent 396c93121c
commit 606c9905ef
3 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
wp-includes/rest-api.php
View File

@ -840,7 +840,7 @@ function rest_sanitize_request_arg( $value, $request, $param ) {
} }
$args = $attributes['args'][ $param ]; $args = $attributes['args'][ $param ];
return rest_sanitize_value_from_schema( $value, $args, $param ); return rest_sanitize_value_from_schema( $value, $args );
} }
/** /**

4
wp-includes/rest-api/endpoints/class-wp-rest-users-controller.php
View File

@ -1027,7 +1027,7 @@ class WP_REST_Users_Controller extends WP_REST_Controller {
* @return WP_Error|string The sanitized username, if valid, otherwise an error. * @return WP_Error|string The sanitized username, if valid, otherwise an error.
*/ */
public function check_username( $value, $request, $param ) { public function check_username( $value, $request, $param ) {
$username = (string) rest_sanitize_value_from_schema( $value, $request, $param ); $username = (string) $value;
if ( ! validate_username( $username ) ) { if ( ! validate_username( $username ) ) {
return new WP_Error( 'rest_user_invalid_username', __( 'Username contains invalid characters.' ), array( 'status' => 400 ) ); return new WP_Error( 'rest_user_invalid_username', __( 'Username contains invalid characters.' ), array( 'status' => 400 ) );
@ -1056,7 +1056,7 @@ class WP_REST_Users_Controller extends WP_REST_Controller {
* @return WP_Error|string The sanitized password, if valid, otherwise an error. * @return WP_Error|string The sanitized password, if valid, otherwise an error.
*/ */
public function check_user_password( $value, $request, $param ) { public function check_user_password( $value, $request, $param ) {
$password = (string) rest_sanitize_value_from_schema( $value, $request, $param ); $password = (string) $value;
if ( empty( $password ) ) { if ( empty( $password ) ) {
return new WP_Error( 'rest_user_invalid_password', __( 'Passwords cannot be empty.' ), array( 'status' => 400 ) ); return new WP_Error( 'rest_user_invalid_password', __( 'Passwords cannot be empty.' ), array( 'status' => 400 ) );

2
wp-includes/version.php
View File

@ -4,7 +4,7 @@
* *
* @global string $wp_version * @global string $wp_version
*/ */
$wp_version = '4.8-alpha-39397'; $wp_version = '4.8-alpha-39400';
/** /**
* Holds the WordPress DB revision, increments when changes are made to the WordPress DB schema. * Holds the WordPress DB revision, increments when changes are made to the WordPress DB schema.