Administration: Display a notice in the Site Health pages when JavaScript is off.

- displays an error notice when JavaScript is off, consistently with other admin screens that depend on JavaScript
- keeps the main `h1` visible

Minor clean-ups:
- makes code indentation consistent in `site-health.php` and `site-health-info.php`
- removes a couple of `<div class="wp-clearfix"></div>` as that's not the intended usage of `wp-clearfix` (those divs didn't do anything anyways)

Fixes #46717.

Built from https://develop.svn.wordpress.org/trunk@45076


git-svn-id: http://core.svn.wordpress.org/trunk@44885 1a063a9b-81f0-0310-95a4-ce76da25c4cd

wp-admin/site-health-info.php

@@ -29,14 +29,13 @@ $health_check_site_status = new WP_Site_Health();
 
 require_once( ABSPATH . 'wp-admin/admin-header.php' );
 ?>
-
 <div class="health-check-header">
 	<div class="health-check-title-section">
 		<h1>
 			<?php _ex( 'Site Health', 'Menu, Section and Page Title' ); ?>
 		</h1>
 
-			<div class="site-health-progress loading">
+		<div class="site-health-progress hide-if-no-js loading">
 			<svg role="img" aria-hidden="true" focusable="false" width="100%" height="100%" viewBox="0 0 200 200" version="1.1" xmlns="http://www.w3.org/2000/svg">
 				<circle r="90" cx="100" cy="100" fill="transparent" stroke-dasharray="565.48" stroke-dashoffset="0"></circle>
 				<circle id="bar" r="90" cx="100" cy="100" fill="transparent" stroke-dasharray="565.48" stroke-dashoffset="0"></circle>
@@ -46,7 +45,7 @@ require_once( ABSPATH . 'wp-admin/admin-header.php' );
 		</div>
 	</div>
 
-		<nav class="health-check-tabs-wrapper" aria-label="<?php esc_attr_e( 'Secondary menu' ); ?>">
+	<nav class="health-check-tabs-wrapper hide-if-no-js" aria-label="<?php esc_attr_e( 'Secondary menu' ); ?>">
 		<a href="<?php echo esc_url( admin_url( 'site-health.php' ) ); ?>" class="health-check-tab">
 			<?php _e( 'Status' ); ?>
 		</a>
@@ -55,11 +54,13 @@ require_once( ABSPATH . 'wp-admin/admin-header.php' );
 			<?php _e( 'Info' ); ?>
 		</a>
 	</nav>
-
-		<div class="wp-clearfix"></div>
 </div>
 
-	<div class="health-check-body">
+<div class="notice notice-error hide-if-js">
+	<p><?php _e( 'The Site Health check requires JavaScript.' ); ?></p>
+</div>
+
+<div class="health-check-body hide-if-no-js">
 	<?php
 	WP_Debug_Data::check_for_updates();
 

wp-admin/site-health.php

@@ -34,14 +34,13 @@ $health_check_site_status->check_wp_version_check_exists();
 
 require_once( ABSPATH . 'wp-admin/admin-header.php' );
 ?>
-
 <div class="health-check-header">
 	<div class="health-check-title-section">
 		<h1>
 			<?php _ex( 'Site Health', 'Menu, Section and Page Title' ); ?>
 		</h1>
 
-		<div class="site-health-progress loading">
+		<div class="site-health-progress hide-if-no-js loading">
 			<svg role="img" aria-hidden="true" focusable="false" width="100%" height="100%" viewBox="0 0 200 200" version="1.1" xmlns="http://www.w3.org/2000/svg">
 				<circle r="90" cx="100" cy="100" fill="transparent" stroke-dasharray="565.48" stroke-dashoffset="0"></circle>
 				<circle id="bar" r="90" cx="100" cy="100" fill="transparent" stroke-dasharray="565.48" stroke-dashoffset="0"></circle>
@@ -51,7 +50,7 @@ require_once( ABSPATH . 'wp-admin/admin-header.php' );
 		</div>
 	</div>
 
-	<nav class="health-check-tabs-wrapper" aria-label="<?php esc_attr_e( 'Secondary menu' ); ?>">
+	<nav class="health-check-tabs-wrapper hide-if-no-js" aria-label="<?php esc_attr_e( 'Secondary menu' ); ?>">
 		<a href="<?php echo esc_url( admin_url( 'site-health.php' ) ); ?>" class="health-check-tab active" aria-current="true">
 			<?php _e( 'Status' ); ?>
 		</a>
@@ -60,11 +59,13 @@ require_once( ABSPATH . 'wp-admin/admin-header.php' );
 			<?php _e( 'Info' ); ?>
 		</a>
 	</nav>
-
-	<div class="wp-clearfix"></div>
 </div>
 
-<div class="health-check-body">
+<div class="notice notice-error hide-if-js">
+	<p><?php _e( 'The Site Health check requires JavaScript.' ); ?></p>
+</div>
+
+<div class="health-check-body hide-if-no-js">
 	<div class="site-status-all-clear hide">
 		<p class="icon">
 			<span class="dashicons dashicons-yes"></span>

wp-includes/version.php

@@ -13,7 +13,7 @@
  *
  * @global string $wp_version
  */
-$wp_version = '5.2-beta1-45075';
+$wp_version = '5.2-beta1-45076';
 
 /**
  * Holds the WordPress DB revision, increments when changes are made to the WordPress DB schema.