Upstream/WordPress
1
0
Fork 0
mirror of https://github.com/WordPress/WordPress.git synced 2024-12-22 17:18:32 +01:00
Code Issues Projects Releases Wiki Activity

Comments: Add rel="nofollow ugc" attribute when converting plain URLs to <a> tags in comments via make_clickable().

Browse Source 
Introduce `make_clickable_rel` filter for the `rel` value that is added to URL matches converted to links.

This is a follow-up to [46349], which added the `rel="nofollow ugc"` attribute to existing `<a>` tags in comments via `wp_rel_ugc()`.

UGC stands for User Generated Content, and the `ugc` attribute value is recommended for links within user generated content, such as comments and forum posts.

See https://webmasters.googleblog.com/2019/09/evolving-nofollow-new-ways-to-identify.html.

Props blogginglife, SergeyBiryukov.
Reviewed by desrosj, audrasjb.
Fixes #48022.
Built from https://develop.svn.wordpress.org/trunk@46564


git-svn-id: http://core.svn.wordpress.org/trunk@46361 1a063a9b-81f0-0310-95a4-ce76da25c4cd
This commit is contained in:
Sergey Biryukov 2019-10-21 20:41:04 +00:00
parent cfec48cc31
commit 654c413990
2 changed files with 31 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

33
wp-includes/formatting.php
View File

@ -2835,7 +2835,24 @@ function _make_url_clickable_cb( $matches ) {
return $matches[0]; return $matches[0];
} }
return $matches[1] . "<a href=\"$url\" rel=\"nofollow\">$url</a>" . $suffix; if ( 'comment_text' === current_filter() ) {
$rel = 'nofollow ugc';
} else {
$rel = 'nofollow';
}
/**
* Filters the rel value that is added to URL matches converted to links.
*
* @since 5.3.0
*
* @param string $rel The rel value.
* @param string $url The matched URL being converted to a link tag.
*/
$rel = apply_filters( 'make_clickable_rel', $rel, $url );
$rel = esc_attr( $rel );
return $matches[1] . "<a href=\"$url\" rel=\"$rel\">$url</a>" . $suffix;
} }
/** /**
@ -2865,7 +2882,17 @@ function _make_web_ftp_clickable_cb( $matches ) {
return $matches[0]; return $matches[0];
} }
return $matches[1] . "<a href=\"$dest\" rel=\"nofollow\">$dest</a>$ret"; if ( 'comment_text' === current_filter() ) {
$rel = 'nofollow ugc';
} else {
$rel = 'nofollow';
}
/** This filter is documented in wp-includes/formatting.php */
$rel = apply_filters( 'make_clickable_rel', $rel, $dest );
$rel = esc_attr( $rel );
return $matches[1] . "<a href=\"$dest\" rel=\"$rel\">$dest</a>$ret";
} }
/** /**
@ -3148,7 +3175,7 @@ function wp_targeted_link_rel_callback( $matches ) {
* *
* @since 5.1.0 * @since 5.1.0
* *
* @param string The rel values. * @param string $rel The rel values.
* @param string $link_html The matched content of the link tag including all HTML attributes. * @param string $link_html The matched content of the link tag including all HTML attributes.
*/ */
$rel = apply_filters( 'wp_targeted_link_rel', 'noopener noreferrer', $link_html ); $rel = apply_filters( 'wp_targeted_link_rel', 'noopener noreferrer', $link_html );

2
wp-includes/version.php
View File

@ -13,7 +13,7 @@
* *
* @global string $wp_version * @global string $wp_version
*/ */
$wp_version = '5.3-RC1-46563'; $wp_version = '5.3-RC1-46564';
/** /**
* Holds the WordPress DB revision, increments when changes are made to the WordPress DB schema. * Holds the WordPress DB revision, increments when changes are made to the WordPress DB schema.