Customize: Remove Vimeo validation for external videos.

Following [39128], this removes the validation logic for Vimeo URLs from
`_validate_external_header_video()` since WP does not support the
display of videos from Vimeo by default.

This also includes a change to using `esc_url_raw()` instead of `esc_url()`
on the URL value to avoid unexpected behavior from the inclusion of HTML
entities.

Props peterwilsoncc, westonruter.
Fixes #38544.
Built from https://develop.svn.wordpress.org/trunk@39148


git-svn-id: http://core.svn.wordpress.org/trunk@39088 1a063a9b-81f0-0310-95a4-ce76da25c4cd
This commit is contained in:
Joe McGill 2016-11-05 18:32:35 +00:00
parent 7b3445c312
commit 68b4181985
2 changed files with 4 additions and 5 deletions

View File

@ -3768,11 +3768,10 @@ final class WP_Customize_Manager {
* @return mixed * @return mixed
*/ */
public function _validate_external_header_video( $validity, $value ) { public function _validate_external_header_video( $validity, $value ) {
$video = esc_url( $value ); $video = esc_url_raw( $value );
if ( $video ) { if ( $video ) {
if ( ! preg_match( '#^https?://(?:www\.)?(?:youtube\.com/watch|youtu\.be/)#', $video ) if ( ! preg_match( '#^https?://(?:www\.)?(?:youtube\.com/watch|youtu\.be/)#', $video ) ) {
&& ! preg_match( '#^https?://(.+\.)?vimeo\.com/.*#', $video ) ) { $validity->add( 'invalid_url', __( 'Please enter a valid YouTube URL.' ) );
$validity->add( 'invalid_url', __( 'Please enter a valid YouTube or Vimeo video URL.' ) );
} }
} }
return $validity; return $validity;

View File

@ -4,7 +4,7 @@
* *
* @global string $wp_version * @global string $wp_version
*/ */
$wp_version = '4.7-beta2-39147'; $wp_version = '4.7-beta2-39148';
/** /**
* Holds the WordPress DB revision, increments when changes are made to the WordPress DB schema. * Holds the WordPress DB revision, increments when changes are made to the WordPress DB schema.