Upstream/WordPress
1
0
Fork 0
mirror of https://github.com/WordPress/WordPress.git synced 2024-11-14 22:56:19 +01:00
Code Issues Projects Releases Wiki Activity

Scripts: Fix a PHP error in admin-ajax calls.

Browse Source 
When making an ajax request, `wp_enqueue_registered_block_scripts_and_styles()` checked if `is_admin()` was true before accessing `$current_screen`, rather than checking if `$current_screen` was defined. This is usually fine, execept for in ajax requests.

Props ocean90, foreverpinetree, pento.
See #45203.


Built from https://develop.svn.wordpress.org/branches/5.0@43893


git-svn-id: http://core.svn.wordpress.org/branches/5.0@43722 1a063a9b-81f0-0310-95a4-ce76da25c4cd
This commit is contained in:
Gary Pendergast 2018-11-12 23:38:47 +00:00
parent 31692a5f6e
commit 6b97594e65
2 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
wp-includes/script-loader.php
View File

@ -2252,7 +2252,7 @@ function script_concat_settings() {
function wp_common_block_scripts_and_styles() { function wp_common_block_scripts_and_styles() {
global $current_screen; global $current_screen;
if ( is_admin() && ! $current_screen->is_block_editor() ) { if ( ( $current_screen instanceof WP_Screen ) && ! $current_screen->is_block_editor() ) {
return; return;
} }
@ -2286,7 +2286,7 @@ function wp_common_block_scripts_and_styles() {
function wp_enqueue_registered_block_scripts_and_styles() { function wp_enqueue_registered_block_scripts_and_styles() {
global $current_screen; global $current_screen;
$is_editor = ( is_admin() && $current_screen->is_block_editor() ); $is_editor = ( ( $current_screen instanceof WP_Screen ) && $current_screen->is_block_editor() );
$block_registry = WP_Block_Type_Registry::get_instance(); $block_registry = WP_Block_Type_Registry::get_instance();
foreach ( $block_registry->get_all_registered() as $block_name => $block_type ) { foreach ( $block_registry->get_all_registered() as $block_name => $block_type ) {

2
wp-includes/version.php
View File

@ -4,7 +4,7 @@
* *
* @global string $wp_version * @global string $wp_version
*/ */
$wp_version = '5.0-beta3-43892'; $wp_version = '5.0-beta3-43893';
/** /**
* Holds the WordPress DB revision, increments when changes are made to the WordPress DB schema. * Holds the WordPress DB revision, increments when changes are made to the WordPress DB schema.