diff --git a/wp-includes/class-wp-user-query.php b/wp-includes/class-wp-user-query.php index a40d4103dc..9b9087dceb 100644 --- a/wp-includes/class-wp-user-query.php +++ b/wp-includes/class-wp-user-query.php @@ -235,8 +235,8 @@ class WP_User_Query { * - 'user_status' * - 'spam' (only available on multisite installs) * - 'deleted' (only available on multisite installs) - * - 'all' for all fields - * - 'all_with_meta' to include meta fields. + * - 'all' for all fields and loads user meta. + * - 'all_with_meta' Deprecated. Use 'all'. * Default 'all'. * @type string $who Type of users to query. Accepts 'authors'. * Default empty (all users). @@ -310,9 +310,7 @@ class WP_User_Query { $this->query_fields[] = "$wpdb->users.$field"; } $this->query_fields = implode( ',', $this->query_fields ); - } elseif ( 'all' === $qv['fields'] ) { - $this->query_fields = "$wpdb->users.*"; - } elseif ( ! in_array( $qv['fields'], $allowed_fields, true ) ) { + } elseif ( 'all_with_meta' === $qv['fields'] || 'all' === $qv['fields'] || ! in_array( $qv['fields'], $allowed_fields, true ) ) { $this->query_fields = "$wpdb->users.ID"; } else { $field = 'id' === strtolower( $qv['fields'] ) ? 'ID' : sanitize_key( $qv['fields'] ); @@ -808,7 +806,7 @@ class WP_User_Query { {$this->query_limit} "; - if ( is_array( $qv['fields'] ) || 'all' === $qv['fields'] ) { + if ( is_array( $qv['fields'] ) ) { $this->results = $wpdb->get_results( $this->request ); } else { $this->results = $wpdb->get_col( $this->request ); @@ -842,19 +840,19 @@ class WP_User_Query { foreach ( $this->results as $result ) { $result->id = $result->ID; } - } elseif ( 'all_with_meta' === $qv['fields'] ) { + } elseif ( 'all_with_meta' === $qv['fields'] || 'all' === $qv['fields'] ) { cache_users( $this->results ); $r = array(); foreach ( $this->results as $userid ) { - $r[ $userid ] = new WP_User( $userid, '', $qv['blog_id'] ); + if ( 'all_with_meta' === $qv['fields'] ) { + $r[ $userid ] = new WP_User( $userid, '', $qv['blog_id'] ); + } else { + $r[] = new WP_User( $userid, '', $qv['blog_id'] ); + } } $this->results = $r; - } elseif ( 'all' === $qv['fields'] ) { - foreach ( $this->results as $key => $user ) { - $this->results[ $key ] = new WP_User( $user, '', $qv['blog_id'] ); - } } } diff --git a/wp-includes/version.php b/wp-includes/version.php index 2d401f9d4f..a2d6af5c9e 100644 --- a/wp-includes/version.php +++ b/wp-includes/version.php @@ -16,7 +16,7 @@ * * @global string $wp_version */ -$wp_version = '6.1-alpha-53654'; +$wp_version = '6.1-alpha-53655'; /** * Holds the WordPress DB revision, increments when changes are made to the WordPress DB schema.