Upstream
/
WordPress
mirror of https://github.com/WordPress/WordPress.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

`hackificator` doesn't like mixed single/double-quoted attributes. These were 2 lingering instances in the admin. 

See #27881.

Built from https://develop.svn.wordpress.org/trunk@28530


git-svn-id: http://core.svn.wordpress.org/trunk@28356 1a063a9b-81f0-0310-95a4-ce76da25c4cd
This commit is contained in:
Scott Taylor 2014-05-19 17:10:15 +00:00
parent 09ecc213c8
commit 7415ae10a3
2 changed files with 18 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

23
wp-admin/options.php
View File

@ -230,18 +230,19 @@ foreach ( (array) $options as $option ) :
$class = 'all-options';
}
$name = esc_attr( $option->option_name );
echo "
?>
<tr>
<th scope='row'><label for='$name'>" . esc_html( $option->option_name ) . "</label></th>
<td>";
if ( strpos( $value, "\n" ) !== false )
echo "<textarea class='$class' name='$name' id='$name' cols='30' rows='5'>" . esc_textarea( $value ) . "</textarea>";
else
echo "<input class='regular-text $class' type='text' name='$name' id='$name' value='" . esc_attr( $value ) . "'" . disabled( $disabled, true, false ) . " />";
echo "</td>
</tr>";
endforeach;
?>
<th scope="row"><label for="<?php echo $name ?>"><?php echo esc_html( $option->option_name ); ?></label></th>
<td>
<?php if ( strpos( $value, "\n" ) !== false ) : ?>
<textarea class="<?php echo $class ?>" name="<?php echo $name ?>" id="<?php echo $name ?>" cols="30" rows="5"><?php
echo esc_textarea( $value );
?></textarea>
<?php else: ?>
<input class="regular-text <?php echo $class ?>" type="text" name="<?php echo $name ?>" id="<?php echo $name ?>" value="<?php echo esc_attr( $value ) ?>"<?php disabled( $disabled, true ) ?> />
<?php endif ?></td>
</tr>
<?php endforeach; ?>
</table>
<input type="hidden" name="page_options" value="<?php echo esc_attr( implode( ',', $options_to_update ) ); ?>" />

10
wp-admin/update-core.php
View File

@ -608,10 +608,12 @@ if ( 'upgrade-core' == $action ) {
$title = __('Update Themes');
require_once(ABSPATH . 'wp-admin/admin-header.php');
echo '<div class="wrap">';
echo '<h2>' . esc_html__('Update Themes') . '</h2>';
echo "<iframe src='$url' style='width: 100%; height: 100%; min-height: 750px;' frameborder='0'></iframe>";
echo '</div>';
?>
<div class="wrap">
<h2><?php echo esc_html__('Update Themes') ?></h2>
<iframe src="<?php echo $url ?>" style="width: 100%; height: 100%; min-height: 750px;" frameborder="0"></iframe>
</div>
<?php
include(ABSPATH . 'wp-admin/admin-footer.php');
} elseif ( 'do-translation-upgrade' == $action ) {