Upstream/WordPress
1
0
Fork 0
mirror of https://github.com/WordPress/WordPress.git synced 2024-09-25 22:02:57 +02:00
Code Issues Projects Releases Wiki Activity

Accessibility: Improve buttons placement in the Comments Quick edit/Reply form.

Browse Source 
Proximity of related information is an inclusive design principle that benefits everyone and it's particularly important for users with reduced visual field, low vision, or other vision or cognitive impairments. User interface controls that are logically grouped should be placed close to each other.
Also, this change makes the buttons visual order and the DOM order match.

Fixes #45972.

Built from https://develop.svn.wordpress.org/trunk@44757


git-svn-id: http://core.svn.wordpress.org/trunk@44589 1a063a9b-81f0-0310-95a4-ce76da25c4cd
This commit is contained in:
Andrea Fercia 2019-02-20 22:09:50 +00:00
parent 34b3b388fd
commit 7f977760a1
6 changed files with 24 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
wp-admin/css/list-tables-rtl.css
View File

@ -152,10 +152,19 @@
overflow: hidden;
}
#replysubmit .reply-submit-buttons {
margin-bottom: 0;
}
#replysubmit .button {
margin-left: 5px;
}
#replysubmit .spinner {
float: none;
margin: -4px 0 0;
}
#replyrow.inline-edit-row fieldset.comment-reply {
font-size: inherit;
line-height: inherit;

2
wp-admin/css/list-tables-rtl.min.css vendored
View File

File diff suppressed because one or more lines are too long

9
wp-admin/css/list-tables.css
View File

@ -152,10 +152,19 @@
overflow: hidden;
}
#replysubmit .reply-submit-buttons {
margin-bottom: 0;
}
#replysubmit .button {
margin-right: 5px;
}
#replysubmit .spinner {
float: none;
margin: -4px 0 0;
}
#replyrow.inline-edit-row fieldset.comment-reply {
font-size: inherit;
line-height: inherit;

2
wp-admin/css/list-tables.min.css vendored
View File

File diff suppressed because one or more lines are too long

7
wp-admin/includes/template.php
View File

@ -479,16 +479,15 @@ function wp_comment_reply( $position = 1, $checkbox = false, $mode = 'single', $
</div>
<div id="replysubmit" class="submit">
<p>
<a href="#comments-form" class="save button button-primary alignright">
<p class="reply-submit-buttons">
<a href="#comments-form" class="save button button-primary">
<span id="addbtn" style="display: none;"><?php _e( 'Add Comment' ); ?></span>
<span id="savebtn" style="display: none;"><?php _e( 'Update Comment' ); ?></span>
<span id="replybtn" style="display: none;"><?php _e( 'Submit Reply' ); ?></span>
</a>
<a href="#comments-form" class="cancel button alignleft"><?php _e( 'Cancel' ); ?></a>
<a href="#comments-form" class="cancel button"><?php _e( 'Cancel' ); ?></a>
<span class="waiting spinner"></span>
</p>
<br class="clear" />
<div class="notice notice-error notice-alt inline hidden">
<p class="error"></p>
</div>

2
wp-includes/version.php
View File

@ -13,7 +13,7 @@
*
* @global string $wp_version
*/
$wp_version = '5.2-alpha-44756';
$wp_version = '5.2-alpha-44757';
/**
* Holds the WordPress DB revision, increments when changes are made to the WordPress DB schema.