From 81df9bffc5ffdda9cd7c16dadef21b574f9ee922 Mon Sep 17 00:00:00 2001 From: Konstantin Obenland Date: Thu, 18 Jun 2015 15:51:26 +0000 Subject: [PATCH] Use https for Google API external libraries. Google recommends it and users are more likely to have the https version cached in their browser already. Props rommelxcastro. Fixes #32552. Built from https://develop.svn.wordpress.org/trunk@32843 git-svn-id: http://core.svn.wordpress.org/trunk@32814 1a063a9b-81f0-0310-95a4-ce76da25c4cd --- wp-admin/css/press-this-editor-rtl.css | 2 +- wp-admin/css/press-this-editor.css | 2 +- wp-content/themes/twentyfifteen/functions.php | 2 +- wp-content/themes/twentyfourteen/functions.php | 2 +- wp-content/themes/twentythirteen/functions.php | 2 +- wp-content/themes/twentytwelve/functions.php | 3 +-- .../js/tinymce/plugins/compat3x/css/dialog.css | 2 +- wp-includes/script-loader.php | 18 +++++++++--------- wp-includes/version.php | 2 +- 9 files changed, 17 insertions(+), 18 deletions(-) diff --git a/wp-admin/css/press-this-editor-rtl.css b/wp-admin/css/press-this-editor-rtl.css index 74d2c25be7..cf8ba74f7c 100644 --- a/wp-admin/css/press-this-editor-rtl.css +++ b/wp-admin/css/press-this-editor-rtl.css @@ -6,7 +6,7 @@ Press This TinyMCE editor styles :) /** * Links */ -@import url("//fonts.googleapis.com/css?family=Open+Sans:400italic,700italic,400,600,700"); +@import url("https://fonts.googleapis.com/css?family=Open+Sans:400italic,700italic,400,600,700"); a { color: #0073aa; } diff --git a/wp-admin/css/press-this-editor.css b/wp-admin/css/press-this-editor.css index 886b8f450f..098921f94d 100644 --- a/wp-admin/css/press-this-editor.css +++ b/wp-admin/css/press-this-editor.css @@ -6,7 +6,7 @@ Press This TinyMCE editor styles :) /** * Links */ -@import url("//fonts.googleapis.com/css?family=Open+Sans:400italic,700italic,400,600,700"); +@import url("https://fonts.googleapis.com/css?family=Open+Sans:400italic,700italic,400,600,700"); a { color: #0073aa; } diff --git a/wp-content/themes/twentyfifteen/functions.php b/wp-content/themes/twentyfifteen/functions.php index 1a8e8a3a38..e109a2bcff 100644 --- a/wp-content/themes/twentyfifteen/functions.php +++ b/wp-content/themes/twentyfifteen/functions.php @@ -198,7 +198,7 @@ function twentyfifteen_fonts_url() { $fonts_url = add_query_arg( array( 'family' => urlencode( implode( '|', $fonts ) ), 'subset' => urlencode( $subsets ), - ), '//fonts.googleapis.com/css' ); + ), 'https://fonts.googleapis.com/css' ); } return $fonts_url; diff --git a/wp-content/themes/twentyfourteen/functions.php b/wp-content/themes/twentyfourteen/functions.php index 5bf5ce03b9..4e65214a0f 100644 --- a/wp-content/themes/twentyfourteen/functions.php +++ b/wp-content/themes/twentyfourteen/functions.php @@ -215,7 +215,7 @@ function twentyfourteen_font_url() { 'family' => urlencode( 'Lato:300,400,700,900,300italic,400italic,700italic' ), 'subset' => urlencode( 'latin,latin-ext' ), ); - $font_url = add_query_arg( $query_args, '//fonts.googleapis.com/css' ); + $font_url = add_query_arg( $query_args, 'https://fonts.googleapis.com/css' ); } return $font_url; diff --git a/wp-content/themes/twentythirteen/functions.php b/wp-content/themes/twentythirteen/functions.php index 9c85c993f3..e87761f223 100644 --- a/wp-content/themes/twentythirteen/functions.php +++ b/wp-content/themes/twentythirteen/functions.php @@ -146,7 +146,7 @@ function twentythirteen_fonts_url() { 'family' => urlencode( implode( '|', $font_families ) ), 'subset' => urlencode( 'latin,latin-ext' ), ); - $fonts_url = add_query_arg( $query_args, '//fonts.googleapis.com/css' ); + $fonts_url = add_query_arg( $query_args, 'https://fonts.googleapis.com/css' ); } return $fonts_url; diff --git a/wp-content/themes/twentytwelve/functions.php b/wp-content/themes/twentytwelve/functions.php index f877ab7d67..8d5facf0f7 100644 --- a/wp-content/themes/twentytwelve/functions.php +++ b/wp-content/themes/twentytwelve/functions.php @@ -113,12 +113,11 @@ function twentytwelve_get_font_url() { elseif ( 'vietnamese' == $subset ) $subsets .= ',vietnamese'; - $protocol = is_ssl() ? 'https' : 'http'; $query_args = array( 'family' => 'Open+Sans:400italic,700italic,400,700', 'subset' => $subsets, ); - $font_url = add_query_arg( $query_args, "$protocol://fonts.googleapis.com/css" ); + $font_url = add_query_arg( $query_args, 'https://fonts.googleapis.com/css' ); } return $font_url; diff --git a/wp-includes/js/tinymce/plugins/compat3x/css/dialog.css b/wp-includes/js/tinymce/plugins/compat3x/css/dialog.css index 2b8cb13b64..4d1f29ff46 100644 --- a/wp-includes/js/tinymce/plugins/compat3x/css/dialog.css +++ b/wp-includes/js/tinymce/plugins/compat3x/css/dialog.css @@ -1,4 +1,4 @@ -@import url(//fonts.googleapis.com/css?family=Open+Sans:300italic,400italic,600italic,300,400,600&subset=latin-ext,latin); +@import url("https://fonts.googleapis.com/css?family=Open+Sans:300italic,400italic,600italic,300,400,600&subset=latin-ext,latin"); /* Generic */ body { diff --git a/wp-includes/script-loader.php b/wp-includes/script-loader.php index 1da93a4734..71e07f5500 100644 --- a/wp-includes/script-loader.php +++ b/wp-includes/script-loader.php @@ -149,14 +149,14 @@ function wp_default_scripts( &$scripts ) { $scripts->add( 'wp-lists', "/wp-includes/js/wp-lists$suffix.js", array( 'wp-ajax-response', 'jquery-color' ), false, 1 ); // WordPress no longer uses or bundles Prototype or script.aculo.us. These are now pulled from an external source. - $scripts->add( 'prototype', '//ajax.googleapis.com/ajax/libs/prototype/1.7.1.0/prototype.js', array(), '1.7.1'); - $scripts->add( 'scriptaculous-root', '//ajax.googleapis.com/ajax/libs/scriptaculous/1.9.0/scriptaculous.js', array('prototype'), '1.9.0'); - $scripts->add( 'scriptaculous-builder', '//ajax.googleapis.com/ajax/libs/scriptaculous/1.9.0/builder.js', array('scriptaculous-root'), '1.9.0'); - $scripts->add( 'scriptaculous-dragdrop', '//ajax.googleapis.com/ajax/libs/scriptaculous/1.9.0/dragdrop.js', array('scriptaculous-builder', 'scriptaculous-effects'), '1.9.0'); - $scripts->add( 'scriptaculous-effects', '//ajax.googleapis.com/ajax/libs/scriptaculous/1.9.0/effects.js', array('scriptaculous-root'), '1.9.0'); - $scripts->add( 'scriptaculous-slider', '//ajax.googleapis.com/ajax/libs/scriptaculous/1.9.0/slider.js', array('scriptaculous-effects'), '1.9.0'); - $scripts->add( 'scriptaculous-sound', '//ajax.googleapis.com/ajax/libs/scriptaculous/1.9.0/sound.js', array( 'scriptaculous-root' ), '1.9.0' ); - $scripts->add( 'scriptaculous-controls', '//ajax.googleapis.com/ajax/libs/scriptaculous/1.9.0/controls.js', array('scriptaculous-root'), '1.9.0'); + $scripts->add( 'prototype', 'https://ajax.googleapis.com/ajax/libs/prototype/1.7.1.0/prototype.js', array(), '1.7.1'); + $scripts->add( 'scriptaculous-root', 'https://ajax.googleapis.com/ajax/libs/scriptaculous/1.9.0/scriptaculous.js', array('prototype'), '1.9.0'); + $scripts->add( 'scriptaculous-builder', 'https://ajax.googleapis.com/ajax/libs/scriptaculous/1.9.0/builder.js', array('scriptaculous-root'), '1.9.0'); + $scripts->add( 'scriptaculous-dragdrop', 'https://ajax.googleapis.com/ajax/libs/scriptaculous/1.9.0/dragdrop.js', array('scriptaculous-builder', 'scriptaculous-effects'), '1.9.0'); + $scripts->add( 'scriptaculous-effects', 'https://ajax.googleapis.com/ajax/libs/scriptaculous/1.9.0/effects.js', array('scriptaculous-root'), '1.9.0'); + $scripts->add( 'scriptaculous-slider', 'https://ajax.googleapis.com/ajax/libs/scriptaculous/1.9.0/slider.js', array('scriptaculous-effects'), '1.9.0'); + $scripts->add( 'scriptaculous-sound', 'https://ajax.googleapis.com/ajax/libs/scriptaculous/1.9.0/sound.js', array( 'scriptaculous-root' ), '1.9.0' ); + $scripts->add( 'scriptaculous-controls', 'https://ajax.googleapis.com/ajax/libs/scriptaculous/1.9.0/controls.js', array('scriptaculous-root'), '1.9.0'); $scripts->add( 'scriptaculous', false, array('scriptaculous-dragdrop', 'scriptaculous-slider', 'scriptaculous-controls') ); // not used in core, replaced by Jcrop.js @@ -650,7 +650,7 @@ function wp_default_styles( &$styles ) { } // Hotlink Open Sans, for now - $open_sans_font_url = "//fonts.googleapis.com/css?family=Open+Sans:300italic,400italic,600italic,300,400,600&subset=$subsets"; + $open_sans_font_url = "https://fonts.googleapis.com/css?family=Open+Sans:300italic,400italic,600italic,300,400,600&subset=$subsets"; } // Register a stylesheet for the selected admin color scheme. diff --git a/wp-includes/version.php b/wp-includes/version.php index 2be2d22664..dae3188f0e 100644 --- a/wp-includes/version.php +++ b/wp-includes/version.php @@ -4,7 +4,7 @@ * * @global string $wp_version */ -$wp_version = '4.3-alpha-32842'; +$wp_version = '4.3-alpha-32843'; /** * Holds the WordPress DB revision, increments when changes are made to the WordPress DB schema.