Upstream/WordPress
1
0
Fork 0
mirror of https://github.com/WordPress/WordPress.git synced 2024-11-14 14:45:45 +01:00
Code Issues Projects Releases Wiki Activity

Shortcodes: don't allow unclosed HTML elements in attributes

Browse Source 
Merges [34134] for 3.7 branch

Built from https://develop.svn.wordpress.org/branches/3.7@34150


git-svn-id: http://core.svn.wordpress.org/branches/3.7@34118 1a063a9b-81f0-0310-95a4-ce76da25c4cd
This commit is contained in:
Nikolay Bachiyski 2015-09-14 22:50:08 +00:00
parent 24a1b34acc
commit 82dac61d61
2 changed files with 11 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
wp-includes/media.php
View File

@ -634,6 +634,8 @@ function img_caption_shortcode($attr, $content = null) {
$content = $matches[1]; $content = $matches[1];
$attr['caption'] = trim( $matches[2] ); $attr['caption'] = trim( $matches[2] );
} }
} elseif ( strpos( $attr['caption'], '<' ) !== false ) {
$attr['caption'] = wp_kses( $attr['caption'], 'post' );
} }
// Allow plugins/themes to override the default caption template. // Allow plugins/themes to override the default caption template.

9
wp-includes/shortcodes.php
View File

@ -448,6 +448,15 @@ function shortcode_parse_atts($text) {
elseif (isset($m[8])) elseif (isset($m[8]))
$atts[] = stripcslashes($m[8]); $atts[] = stripcslashes($m[8]);
} }
// Reject any unclosed HTML elements
foreach( $atts as &$value ) {
if ( false !== strpos( $value, '<' ) ) {
if ( 1 !== preg_match( '/^[^<]*+(?:<[^>]*+>[^<]*+)*+$/', $value ) ) {
$value = '';
}
}
}
} else { } else {
$atts = ltrim($text); $atts = ltrim($text);
} }